From 3616f145e1c4a29cd8d1d743e247a7f672c4755e Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Mon, 19 Oct 2020 10:33:45 +0200
Subject: [PATCH 01/35] textual

---
 client/src/cmdhficlass.c | 91 ++++++++++++++++++++--------------------
 1 file changed, 45 insertions(+), 46 deletions(-)

diff --git a/client/src/cmdhficlass.c b/client/src/cmdhficlass.c
index dd025852f..e9aaa1880 100644
--- a/client/src/cmdhficlass.c
+++ b/client/src/cmdhficlass.c
@@ -428,51 +428,51 @@ static void fuse_config(const picopass_hdr *hdr) {
     uint16_t otp = (hdr->conf.otp[1] << 8 | hdr->conf.otp[0]);
 
     PrintAndLogEx(INFO, "    Raw: " _YELLOW_("%s"), sprint_hex((uint8_t*)&hdr->conf, 8));
-    PrintAndLogEx(INFO, "         " _YELLOW_("%02X") ".....................  App limit", hdr->conf.app_limit);
+    PrintAndLogEx(INFO, "         " _YELLOW_("%02X") ".....................  app limit", hdr->conf.app_limit);
     PrintAndLogEx(INFO, "            " _YELLOW_("%04X") " ( %5u )......  OTP", otp, otp);
-    PrintAndLogEx(INFO, "                  " _YELLOW_("%02X") "............  Block write lock", hdr->conf.block_writelock);
-    PrintAndLogEx(INFO, "                     " _YELLOW_("%02X") ".........  Chip", hdr->conf.chip_config);
-    PrintAndLogEx(INFO, "                        " _YELLOW_("%02X") "......  Mem", hdr->conf.mem_config);
+    PrintAndLogEx(INFO, "                  " _YELLOW_("%02X") "............  block write lock", hdr->conf.block_writelock);
+    PrintAndLogEx(INFO, "                     " _YELLOW_("%02X") ".........  chip", hdr->conf.chip_config);
+    PrintAndLogEx(INFO, "                        " _YELLOW_("%02X") "......  mem", hdr->conf.mem_config);
     PrintAndLogEx(INFO, "                           " _YELLOW_("%02X") "...  EAS", hdr->conf.eas);
-    PrintAndLogEx(INFO, "                              " _YELLOW_("%02X") "  Fuses", hdr->conf.fuses);
+    PrintAndLogEx(INFO, "                              " _YELLOW_("%02X") "  fuses", hdr->conf.fuses);
 
     uint8_t fuses = hdr->conf.fuses;
 
     PrintAndLogEx(INFO, "  Fuses:");
     if (isset(fuses, FUSE_FPERS))
-        PrintAndLogEx(SUCCESS, "    mode..... " _GREEN_("Personalization (programmable)"));
+        PrintAndLogEx(SUCCESS, "    mode......... " _GREEN_("Personalization (programmable)"));
     else
-        PrintAndLogEx(SUCCESS, "    mode..... " _YELLOW_("Application (locked)"));
+        PrintAndLogEx(SUCCESS, "    mode......... " _YELLOW_("Application (locked)"));
 
     if (isset(fuses, FUSE_CODING1)) {
-        PrintAndLogEx(SUCCESS, "    coding.. RFU");
+        PrintAndLogEx(SUCCESS, "    coding...... RFU");
     } else {
         if (isset(fuses, FUSE_CODING0))
-            PrintAndLogEx(SUCCESS, "    coding... " _YELLOW_("ISO 14443-2 B / 15693"));
+            PrintAndLogEx(SUCCESS, "    coding....... " _YELLOW_("ISO 14443-2 B / 15693"));
         else
-            PrintAndLogEx(SUCCESS, "    coding... " _YELLOW_("ISO 14443-B only"));
+            PrintAndLogEx(SUCCESS, "    coding....... " _YELLOW_("ISO 14443-B only"));
     }
 
     uint8_t pagemap = get_pagemap(hdr);
     switch (pagemap) {
         case 0x0:
-            PrintAndLogEx(INFO, "    crypt.... No auth possible. Read only if RA is enabled");
+            PrintAndLogEx(INFO, "    crypt........ No auth possible. Read only if RA is enabled");
             break;
         case 0x1:
-            PrintAndLogEx(SUCCESS, "    crypt.... Non secured page");
+            PrintAndLogEx(SUCCESS, "    crypt........ Non secured page");
             break;
         case 0x2:
-            PrintAndLogEx(INFO, "    crypt.... Secured page, keys locked");
+            PrintAndLogEx(INFO, "    crypt........ Secured page, keys locked");
             break;
         case 0x03:
-            PrintAndLogEx(SUCCESS, "    crypt.... Secured page, " _GREEN_("keys not locked"));
+            PrintAndLogEx(SUCCESS, "    crypt........ Secured page, " _GREEN_("keys not locked"));
             break;
     }
 
     if (isset(fuses, FUSE_RA))
-        PrintAndLogEx(SUCCESS, "    RA....... Read access enabled (non-secure mode)");
+        PrintAndLogEx(SUCCESS, "    RA........... Read access enabled (non-secure mode)");
     else
-        PrintAndLogEx(INFO, "    RA....... Read access not enabled");
+        PrintAndLogEx(INFO, "    RA........... Read access not enabled");
 }
 
 static void getMemConfig(uint8_t mem_cfg, uint8_t chip_cfg, uint8_t *app_areas, uint8_t *kb) {
@@ -545,23 +545,23 @@ static void mem_app_config(const picopass_hdr *hdr) {
     PrintAndLogEx(INFO, "    AA1 blocks %u { 0x06 - 0x%02X (06 - %02d) }", app1_limit, app1_limit + 5, app1_limit + 5);
     PrintAndLogEx(INFO, "    AA2 blocks %u { 0x%02X - 0x%02X (%02d - %02d) }", app2_limit - app1_limit, app1_limit + 5 + 1, app2_limit, app1_limit + 5 + 1, app2_limit);
 
-    PrintAndLogEx(INFO, "------------------------ " _CYAN_("KeyAccess") " -------------------------");
-    PrintAndLogEx(INFO, " Kd = Debit key (AA1),  Kc = Credit key (AA2)");
+    PrintAndLogEx(INFO, "------------------------- " _CYAN_("KeyAccess") " ------------------------");
+    PrintAndLogEx(INFO, " * Kd, Debit key, AA1    Kc, Credit key, AA2 *");
     uint8_t book = isset(mem, 0x20);
     if (book) {
-        PrintAndLogEx(INFO, "     Read A - Kd");
-        PrintAndLogEx(INFO, "     Read B - Kc");
-        PrintAndLogEx(INFO, "    Write A - Kd");
-        PrintAndLogEx(INFO, "    Write B - Kc");
-        PrintAndLogEx(INFO, "      Debit - Kd or Kc");
-        PrintAndLogEx(INFO, "     Credit - Kc");
+        PrintAndLogEx(INFO, "    Read A....... debit");
+        PrintAndLogEx(INFO, "    Read B....... credit");
+        PrintAndLogEx(INFO, "    Write A...... debit");
+        PrintAndLogEx(INFO, "    Write B...... credit");
+        PrintAndLogEx(INFO, "    Debit........ debit or credit");
+        PrintAndLogEx(INFO, "    Credit....... credit");
     } else {
-        PrintAndLogEx(INFO, "     Read A - Kd or Kc");
-        PrintAndLogEx(INFO, "     Read B - Kd or Kc");
-        PrintAndLogEx(INFO, "    Write A - Kc");
-        PrintAndLogEx(INFO, "    Write B - Kc");
-        PrintAndLogEx(INFO, "      Debit - Kd or Kc");
-        PrintAndLogEx(INFO, "     Credit - Kc");
+        PrintAndLogEx(INFO, "    Read A....... debit or credit");
+        PrintAndLogEx(INFO, "    Read B....... debit or credit");
+        PrintAndLogEx(INFO, "    Write A...... credit");
+        PrintAndLogEx(INFO, "    Write B...... credit");
+        PrintAndLogEx(INFO, "    Debit........ debit or credit");
+        PrintAndLogEx(INFO, "    redit........ credit");
     }
 }
 
@@ -3539,33 +3539,33 @@ int info_iclass(void) {
         picopass_ns_hdr *ns_hdr = (picopass_ns_hdr *)resp.data.asBytes;
 
         PrintAndLogEx(NORMAL, "");
-        PrintAndLogEx(INFO, "--- " _CYAN_("Tag Information") " --------------------------");
-        PrintAndLogEx(INFO, "-------------------------------------------------------------");
+        PrintAndLogEx(INFO, "--------------------- " _CYAN_("Tag Information") " ----------------------");
+        PrintAndLogEx(INFO, "------------------------------------------------------------");
 
         if (readStatus & FLAG_ICLASS_CSN) {
-            PrintAndLogEx(SUCCESS, "    CSN: " _GREEN_("%s") "  (uid)", sprint_hex(hdr->csn, sizeof(hdr->csn)));
+            PrintAndLogEx(SUCCESS, "    CSN: " _GREEN_("%s") " uid", sprint_hex(hdr->csn, sizeof(hdr->csn)));
         }
 
         if (readStatus & FLAG_ICLASS_CONF) {
-            PrintAndLogEx(SUCCESS, " Config: %s  (Card configuration)", sprint_hex((uint8_t *)&hdr->conf, sizeof(hdr->conf)));
+            PrintAndLogEx(SUCCESS, " Config: %s card configuration", sprint_hex((uint8_t *)&hdr->conf, sizeof(hdr->conf)));
         }
 
         // page mapping.  If fuse0|1 == 0x01, card is in non-secure mode, with CSN, CONF, AIA as top 3 blocks.
         // page9 in http://www.proxmark.org/files/Documents/13.56%20MHz%20-%20iClass/DS%20Picopass%202KS%20V1-0.pdf
         uint8_t pagemap = get_pagemap(hdr);
         if (pagemap == PICOPASS_NON_SECURE_PAGEMODE) {
-            PrintAndLogEx(SUCCESS, "    AIA: %s  (Application Issuer area)", sprint_hex(ns_hdr->app_issuer_area, sizeof(ns_hdr->app_issuer_area)));
+            PrintAndLogEx(SUCCESS, "    AIA: %s application issuer area", sprint_hex(ns_hdr->app_issuer_area, sizeof(ns_hdr->app_issuer_area)));
         } else {
 
             if (readStatus & FLAG_ICLASS_CC) {
-                PrintAndLogEx(SUCCESS, "E-purse: %s  (Card challenge, CC)", sprint_hex(hdr->epurse, sizeof(hdr->epurse)));
+                PrintAndLogEx(SUCCESS, "E-purse: %s Card challenge, CC", sprint_hex(hdr->epurse, sizeof(hdr->epurse)));
             }
 
-            PrintAndLogEx(SUCCESS, "     Kd: %s  (Debit key, hidden)", sprint_hex(hdr->key_d, sizeof(hdr->key_d)));
-            PrintAndLogEx(SUCCESS, "     Kc: %s  (Credit key, hidden)", sprint_hex(hdr->key_c, sizeof(hdr->key_c)));
+            PrintAndLogEx(SUCCESS, "     Kd: %s debit key, hidden", sprint_hex(hdr->key_d, sizeof(hdr->key_d)));
+            PrintAndLogEx(SUCCESS, "     Kc: %s credit key, hidden", sprint_hex(hdr->key_c, sizeof(hdr->key_c)));
 
             if (readStatus & FLAG_ICLASS_AIA) {
-                PrintAndLogEx(SUCCESS, "    AIA: %s  (Application Issuer area)", sprint_hex(hdr->app_issuer_area, sizeof(hdr->app_issuer_area)));
+                PrintAndLogEx(SUCCESS, "    AIA: %s application issuer area", sprint_hex(hdr->app_issuer_area, sizeof(hdr->app_issuer_area)));
             }
         }
 
@@ -3573,7 +3573,7 @@ int info_iclass(void) {
             print_picopass_info(hdr);
         }
 
-        PrintAndLogEx(INFO, "------ " _CYAN_("Fingerprint") " ------");
+        PrintAndLogEx(INFO, "------------------------ " _CYAN_("Fingerprint") " -----------------------");
 
         uint8_t aia[8];
         if (pagemap == PICOPASS_NON_SECURE_PAGEMODE)
@@ -3588,18 +3588,17 @@ int info_iclass(void) {
         bool se_enabled = (memcmp(aia, "\xff\xff\xff\x00\x06\xff\xff\xff", 8) == 0);
 
         if (isHidRange) {
-            PrintAndLogEx(SUCCESS, "CSN is in HID range");
+            PrintAndLogEx(SUCCESS, "    CSN.......... " _YELLOW_("HID range"));
             if (legacy)
-                PrintAndLogEx(SUCCESS, "Credential : " _GREEN_("iCLASS legacy"));
+                PrintAndLogEx(SUCCESS, "    Credential... " _GREEN_("iCLASS legacy"));
             if (se_enabled)
-                PrintAndLogEx(SUCCESS, "Credential : " _GREEN_("iCLASS SE"));
-
+                PrintAndLogEx(SUCCESS, "    Credential... " _GREEN_("iCLASS SE"));
         } else {
-            PrintAndLogEx(SUCCESS, _YELLOW_("PicoPass")" (CSN is not in HID range)");
+            PrintAndLogEx(SUCCESS, "    CSN..-.......  " _YELLOW_("outside HID range"));
         }
 
         uint8_t cardtype = get_mem_config(hdr);
-        PrintAndLogEx(SUCCESS, " Card type : " _GREEN_("%s"), card_types[cardtype]);
+        PrintAndLogEx(SUCCESS, "    Card type.... " _GREEN_("%s"), card_types[cardtype]);
     }
 
     DropField();

From 0e4a9fbc346e88ae8ddd8d1d45bf213a7126471d Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Mon, 19 Oct 2020 12:42:26 +0200
Subject: [PATCH 02/35] text

---
 client/src/cmdhw.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/client/src/cmdhw.c b/client/src/cmdhw.c
index f2eff6966..7ad1ba5b8 100644
--- a/client/src/cmdhw.c
+++ b/client/src/cmdhw.c
@@ -792,18 +792,18 @@ void pm3_version(bool verbose, bool oneliner) {
 
         PrintAndLogEx(NORMAL, "\n [ " _YELLOW_("PROXMARK3") " ]");
         if (IfPm3Rdv4Fw() == false) {
-            PrintAndLogEx(NORMAL, "  firmware.........................%s", _GREEN_("PM3OTHER"));
+            PrintAndLogEx(NORMAL, "  firmware.................. %s", _YELLOW_("PM3OTHER"));
             if (IfPm3FpcUsartHost()) {
-                PrintAndLogEx(NORMAL, "  FPC USART for BT add-on..........%s", _GREEN_("present"));
+                PrintAndLogEx(NORMAL, "  FPC USART for BT add-on... %s", _GREEN_("present"));
             }
         } else {
-            PrintAndLogEx(NORMAL, "  firmware.........................%s", _GREEN_("PM3RDV4"));
-            PrintAndLogEx(NORMAL, "  external flash...................%s", IfPm3Flash() ? _GREEN_("present") : _YELLOW_("absent"));
-            PrintAndLogEx(NORMAL, "  smartcard reader.................%s", IfPm3Smartcard() ? _GREEN_("present") : _YELLOW_("absent"));
-            PrintAndLogEx(NORMAL, "  FPC USART for BT add-on..........%s", IfPm3FpcUsartHost() ? _GREEN_("present") : _YELLOW_("absent"));
+            PrintAndLogEx(NORMAL, "  firmware.................. %s", _YELLOW_("PM3RDV4"));
+            PrintAndLogEx(NORMAL, "  external flash............ %s", IfPm3Flash() ? _GREEN_("present") : _YELLOW_("absent"));
+            PrintAndLogEx(NORMAL, "  smartcard reader.......... %s", IfPm3Smartcard() ? _GREEN_("present") : _YELLOW_("absent"));
+            PrintAndLogEx(NORMAL, "  FPC USART for BT add-on... %s", IfPm3FpcUsartHost() ? _GREEN_("present") : _YELLOW_("absent"));
         }
         if (IfPm3FpcUsartDevFromUsb()) {
-            PrintAndLogEx(NORMAL, "  FPC USART for developer..........%s", _GREEN_("present"));
+            PrintAndLogEx(NORMAL, "  FPC USART for developer... %s", _GREEN_("present"));
         }
 
         PrintAndLogEx(NORMAL, "");

From f1d39f7e53718951d9f7923c4a81ccd87c9f08a5 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Mon, 19 Oct 2020 15:48:45 +0200
Subject: [PATCH 03/35] fix support for waveshare 1.54

---
 client/src/cmdhf14a.c       | 10 ++++++++--
 client/src/cmdhfwaveshare.c | 15 +++++++++++++--
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/client/src/cmdhf14a.c b/client/src/cmdhf14a.c
index e9ddbf6c5..837311062 100644
--- a/client/src/cmdhf14a.c
+++ b/client/src/cmdhf14a.c
@@ -1681,10 +1681,16 @@ int infoHF14A(bool verbose, bool do_nack_test, bool do_aid_search) {
                 }
                 getTagLabel(card.uid[0], card.uid[1]);
                 break;
-            case 0x57: // Qualcomm
+            case 0x46:
+                if (memcmp(card.uid, "FSTN10m", 7) == 0) {
+                    isMifareClassic = false;
+                    printTag("Waveshare NFC-Powered e-Paper 1.54\" (please disregard MANUFACTURER mapping above)");
+                }
+                break;
+            case 0x57:
                 if (memcmp(card.uid, "WSDZ10m", 7) == 0) {
                     isMifareClassic = false;
-                    printTag("Waveshare NFC-Powered e-Paper");
+                    printTag("Waveshare NFC-Powered e-Paper (please disregard MANUFACTURER mapping above)");
                 }
                 break;
             default:
diff --git a/client/src/cmdhfwaveshare.c b/client/src/cmdhfwaveshare.c
index 4e5728e7f..1ea7013a1 100644
--- a/client/src/cmdhfwaveshare.c
+++ b/client/src/cmdhfwaveshare.c
@@ -693,11 +693,21 @@ static int start_drawing(uint8_t model_nr, uint8_t *black, uint8_t *red) {
         return PM3_ESOFT;
     }
 
-    if ((card.uidlen != 7) || (memcmp(card.uid, "WSDZ10m", 7) != 0)) {
+    if ((card.uidlen != 7) || ((memcmp(card.uid, "FSTN10m", 7) != 0) && (memcmp(card.uid, "WSDZ10m", 7) != 0))) {
         PrintAndLogEx(WARNING, "Card doesn't look like Waveshare tag");
         DropField();
         return PM3_ESOFT;
     }
+    if (((model_nr != M1in54B) && (memcmp(card.uid, "FSTN10m", 7) == 0))) {
+        PrintAndLogEx(WARNING, "Card is a Waveshare tag 1.54\", not %s", models[model_nr].desc);
+        DropField();
+        return PM3_ESOFT;
+    }
+    if (((model_nr == M1in54B) && (memcmp(card.uid, "FSTN10m", 7) != 0))) {
+        PrintAndLogEx(WARNING, "Card is not a Waveshare tag 1.54\", check your model number");
+        DropField();
+        return PM3_ESOFT;
+    }
     PrintAndLogEx(DEBUG, "model_nr = %d", model_nr);
     int ret;
     PrintAndLogEx(DEBUG, "Step0");
@@ -921,6 +931,7 @@ static int start_drawing(uint8_t model_nr, uint8_t *black, uint8_t *red) {
         msleep(200);
     }
     PrintAndLogEx(DEBUG, "Step11: Wait tag to be ready");
+    PrintAndLogEx(INPLACE, "E-paper Reflashing, Waiting");
     if (model_nr == M2in13B || model_nr == M1in54B) { // Black, white and red screen refresh time is longer, wait first
         msleep(9000);
     } else if (model_nr == M7in5HD) {
@@ -950,7 +961,7 @@ static int start_drawing(uint8_t model_nr, uint8_t *black, uint8_t *red) {
             } else {
                 fail_num++;
                 PrintAndLogEx(INPLACE, "E-paper Reflashing, Waiting");
-                msleep(100);
+                msleep(400);
             }
         }
     }

From daabdf2e31cde2f8f91bb5e10452f05eb08bbdbc Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Mon, 19 Oct 2020 21:21:24 +0200
Subject: [PATCH 04/35] Avoid spurious GCC10 stringop-overflow errors I already
 got them at several occasions

---
 Makefile.defs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Makefile.defs b/Makefile.defs
index 06eb2e36f..4045fb711 100644
--- a/Makefile.defs
+++ b/Makefile.defs
@@ -27,6 +27,9 @@ LD = g++
 SH = sh
 BASH = bash
 PERL = perl
+CCC =foo
+CC_VERSION = $(shell $(CC) -dumpversion 2>/dev/null|sed 's/\..*//')
+CC_VERSION := $(or $(strip $(CC_VERSION)),0)
 
 PATHSEP=/
 PREFIX ?=              /usr/local
@@ -62,7 +65,11 @@ DEFCFLAGS += -Wbad-function-cast -Wredundant-decls -Wmissing-prototypes -Wchar-s
 # Some more warnings we need first to eliminate, so temporarely tolerated:
 DEFCFLAGS += -Wcast-align -Wno-error=cast-align
 DEFCFLAGS += -Wswitch-enum -Wno-error=switch-enum
-
+# GCC 10 has issues with false positives on stringop-overflow, let's disable them for now (cf https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92955, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94335)
+# beware these flags didn't exist for GCC < 7
+ifeq ($(shell expr $(CC_VERSION) \>= 10), 1)
+    DEFCFLAGS += -Wno-stringop-overflow -Wno-error=stringop-overflow
+endif
 ifeq ($(platform),Darwin)
 # their readline has strict-prototype issues
 DEFCFLAGS += -Wno-strict-prototypes

From 8d14b46232b59a451973e67eeaa02266ad97a0d6 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Mon, 19 Oct 2020 21:25:24 +0200
Subject: [PATCH 05/35] waveshare: tolerate (but ignore) alpha channel

---
 client/src/cmdhfwaveshare.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/client/src/cmdhfwaveshare.c b/client/src/cmdhfwaveshare.c
index 1ea7013a1..b47043be2 100644
--- a/client/src/cmdhfwaveshare.c
+++ b/client/src/cmdhfwaveshare.c
@@ -351,7 +351,7 @@ static void map8to1(uint8_t *colormap, uint16_t width, uint16_t height, uint8_t
 static int read_bmp_rgb(uint8_t *bmp, const size_t bmpsize, uint8_t model_nr, uint8_t **black, uint8_t **red, char *filename, bool save_conversions) {
     BMP_HEADER *pbmpheader = (BMP_HEADER *)bmp;
     // check file is full color
-    if (pbmpheader->bpp != 24) {
+    if ((pbmpheader->bpp != 24) && (pbmpheader->bpp != 32)) {
         return PM3_ESOFT;
     }
 
@@ -400,6 +400,8 @@ static int read_bmp_rgb(uint8_t *bmp, const size_t bmpsize, uint8_t model_nr, ui
             chanB[X + (height - Y - 1) * width] = bmp[offset++];
             chanG[X + (height - Y - 1) * width] = bmp[offset++];
             chanR[X + (height - Y - 1) * width] = bmp[offset++];
+            if (pbmpheader->bpp == 32) // Skip Alpha chan
+                offset++;
         }
         // Skip line padding
         offset += width % 4;
@@ -436,6 +438,8 @@ static int read_bmp_rgb(uint8_t *bmp, const size_t bmpsize, uint8_t model_nr, ui
                     bmp[offset++] = chanB[X + (height - Y - 1) * width] & 0xFF;
                     bmp[offset++] = chanG[X + (height - Y - 1) * width] & 0xFF;
                     bmp[offset++] = chanR[X + (height - Y - 1) * width] & 0xFF;
+                    if (pbmpheader->bpp == 32) // Fill Alpha chan
+                        bmp[offset++] = 0xFF;
                 }
                 // Skip line padding
                 offset += width % 4;
@@ -500,6 +504,8 @@ static int read_bmp_rgb(uint8_t *bmp, const size_t bmpsize, uint8_t model_nr, ui
                     bmp[offset++] = chanGrey[X + (height - Y - 1) * width] & 0xFF;
                     bmp[offset++] = chanGrey[X + (height - Y - 1) * width] & 0xFF;
                     bmp[offset++] = chanGrey[X + (height - Y - 1) * width] & 0xFF;
+                    if (pbmpheader->bpp == 32) // Fill Alpha chan
+                        bmp[offset++] = 0xFF;
                 }
                 // Skip line padding
                 offset += width % 4;
@@ -1059,11 +1065,13 @@ static int CmdHF14AWSLoadBmp(const char *Cmd) {
             return PM3_ESOFT;
         }
     } else if (depth == 32) {
-        PrintAndLogEx(ERR, "Error, BMP color depth %i not supported. Remove alpha channel.", depth);
-        free(bmp);
-        return PM3_ESOFT;
+        PrintAndLogEx(DEBUG, "BMP file is a RGBA, we will ignore the Alpha channel");
+        if (read_bmp_rgb(bmp, bytes_read, model_nr, &black, &red, filename, save_conversions) != PM3_SUCCESS) {
+            free(bmp);
+            return PM3_ESOFT;
+        }
     } else {
-        PrintAndLogEx(ERR, "Error, BMP color depth %i not supported. Must be 1 (BW) or 24 (RGB)", depth);
+        PrintAndLogEx(ERR, "Error, BMP color depth %i not supported. Must be 1 (BW), 24 (RGB) or 32 (RGBA)", depth);
         free(bmp);
         return PM3_ESOFT;
     }

From 86ff6aebefeed0759e4529035f05f1758fed8b73 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 00:45:03 +0200
Subject: [PATCH 06/35] vscode

---
 .vscode/launch.json | 55 ++++++++++++++++++++++++++++++++++
 .vscode/tasks.json  | 73 +++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 122 insertions(+), 6 deletions(-)
 create mode 100644 .vscode/launch.json

diff --git a/.vscode/launch.json b/.vscode/launch.json
new file mode 100644
index 000000000..f115c5c7e
--- /dev/null
+++ b/.vscode/launch.json
@@ -0,0 +1,55 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "(gdb) Attach",
+            "type": "cppdbg",
+            "request": "attach",
+            "program": "${cwd}/client/proxmark3",
+            //"processId": "${command:pickProcess}",
+            "processId": "${input:ProcessID}",
+            "MIMode": "gdb",
+            "setupCommands": [
+                {
+                    "description": "Enable pretty-printing for gdb",
+                    "text": "-enable-pretty-printing",
+                    "ignoreFailures": true
+                }
+            ]
+        },{
+            "name": "(gdb) Build & Launch",
+            "type": "cppdbg",
+            "request": "launch",
+            "program": "${cwd}/client/proxmark3",
+            "args": ["/dev/ttyACM0"],
+            "stopAtEntry": false,
+            "cwd": "${workspaceFolder}",
+            "environment": [],
+            "externalConsole": false,
+            "MIMode": "gdb",
+            "setupCommands": [
+                {
+                    "description": "Enable pretty-printing for gdb",
+                    "text": "-enable-pretty-printing",
+                    "ignoreFailures": true
+                }
+            ],
+            "preLaunchTask": "Debug: clean & make client",
+            "miDebuggerPath": "/usr/bin/gdb"
+        }
+    ],
+    "inputs": [
+        {
+            // Using Extension "Tasks Shell Input" https://marketplace.visualstudio.com/items?itemName=augustocdias.tasks-shell-input
+            "id": "ProcessID",
+            "type": "command",
+            "command": "shellCommand.execute",
+            "args": {
+                "command": "pgrep -n proxmark3",
+            }
+        }
+    ]
+}
\ No newline at end of file
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
index 20b68be0e..352f22a42 100644
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -4,24 +4,85 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "label": "build",
+            "label": "Make all & run",
             "type": "shell",
-            "command": "make clean && make all -j$(nproc --all)",
+            "command": "make -j && ./pm3",
             "problemMatcher": [
                 "$gcc"
-            ]
+            ],
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            }
         },
         {
-            "label": "flash fullimage",
+            "label": "Make TARGET",
             "type": "shell",
-            "command": "sudo ./pm3-flash-fullimage",
+            "command": "make ${input:componentType} -j",
+            "problemMatcher": [
+                "$gcc"
+            ],
+            "group": "build",
+        },
+        {
+            "label": "Debug: make client",
+            "type": "shell",
+            "command": "make client -j DEBUG=1",
+            "problemMatcher": [
+                "$gcc"
+            ],
+            "group": "build",
+        },
+        {
+            "label": "Debug: clean & make client",
+            "type": "shell",
+            "command": "make client/clean && make client -j DEBUG=1",
+            "problemMatcher": [
+                "$gcc"
+            ],
+            "group": "build",
+        },
+        {
+            "label": "Flash fullimage",
+            "type": "shell",
+            "command": "./pm3-flash-fullimage",
             "problemMatcher": []
         },
         {
             "label": "FLASH BOOTROM",
             "type": "shell",
-            "command": "sudo ./pm3-flash-bootrom",
+            "command": "./pm3-flash-bootrom",
             "problemMatcher": []
+        },
+        {
+            "label": "Run client",
+            "type": "shell",
+            "command": "./pm3",
+            "problemMatcher": [],
+            "dependsOn": [
+                "Release: build client"
+            ]
+        }
+    ],
+    "inputs": [
+        {
+            "type": "pickString",
+            "id": "componentType",
+            "description": "What Makefile target do you want to execute?",
+            "options": [
+                "all",
+                "client",
+                "bootrom",
+                "fullimage",
+                "recovery",
+                "clean",
+                "install",
+                "uninstall",
+                "style",
+                "miscchecks",
+                "check",
+            ],
+            "default": "all"
         }
     ]
 }
\ No newline at end of file

From ec820db997af8c9a7508d21b204a72a2debb0204 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 01:00:00 +0200
Subject: [PATCH 07/35] Add DEBUG flag to Makefile

---
 Makefile.defs                           | 12 +++++++++---
 doc/md/Development/Makefile-vs-CMake.md |  5 +++--
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/Makefile.defs b/Makefile.defs
index 4045fb711..a06cbb31e 100644
--- a/Makefile.defs
+++ b/Makefile.defs
@@ -51,9 +51,15 @@ else
     RANLIB= ranlib
 endif
 
-DEFCXXFLAGS = -Wall -Werror -O3 -pipe
-DEFCFLAGS = -Wall -Werror -O3 -fstrict-aliasing -pipe
-DEFLDFLAGS =
+ifeq ($(DEBUG),1)
+  DEFCXXFLAGS = -g -O0 -pipe
+  DEFCFLAGS = -g -O0 -fstrict-aliasing -pipe
+  DEFLDFLAGS =
+else
+  DEFCXXFLAGS = -Wall -Werror -O3 -pipe
+  DEFCFLAGS = -Wall -Werror -O3 -fstrict-aliasing -pipe
+  DEFLDFLAGS =
+endif
 # Next ones are activated only if SANITIZE=1
 ifeq ($(SANITIZE),1)
   DEFCFLAGS += -g -fsanitize=address -fno-omit-frame-pointer
diff --git a/doc/md/Development/Makefile-vs-CMake.md b/doc/md/Development/Makefile-vs-CMake.md
index 314cd1e7a..6fa95066c 100644
--- a/doc/md/Development/Makefile-vs-CMake.md
+++ b/doc/md/Development/Makefile-vs-CMake.md
@@ -13,7 +13,8 @@ At the moment both are maintained because they don't perfectly overlap yet.
 
 | Feature | Makefile | CMake | Remarks |
 |-----|---|---|---|
-| verbose | V=1 | VERBOSE=1 |   |
+| verbose | `V=1` | `VERBOSE=1` |   |
+| debug build | `DEBUG=1` | `-DCMAKE_BUILD_TYPE=Debug` | client only |
 | warnings management | yes (1) | **no** | (1) cf Makefile.defs |
 | extra GCC warnings | GCCEXTRA=1 | **no** |   |
 | extra Clang warnings | CLANGEXTRA=1 | **no** | only on host |
@@ -32,7 +33,7 @@ At the moment both are maintained because they don't perfectly overlap yet.
 | bzip2 detection | **none** | find_package, Cross:gitclone | |
 | dep cliparser | in_deps | in_deps |   |
 | dep hardnested | in_deps | in_deps |   |
-| hardn arch autodetect | `uname -m` =? 86 or amd64; `$(CC) -E -mavx512f`? +AVX512` |  `CMAKE_SYSTEM_PROCESSOR` =? x86 or x86_64 or i686 or AMD64 (1) | (1) currently it always includes AVX512 on Intel arch |
+| hardn arch autodetect | `uname -m` =? 86 or amd64; `$(CC) -E -mavx512f`? +`AVX512` |  `CMAKE_SYSTEM_PROCESSOR` =? x86 or x86_64 or i686 or AMD64 (1) | (1) currently it always includes AVX512 on Intel arch |
 | `cpu_arch` | yes | **no/auto?** | e.g. `cpu_arch=generic` for cross-compilation
 | dep jansson | sys / in_deps | sys / in_deps |   |
 | jansson detection | pc | pc/find* |   |

From 29f1147aadc64bf9bbcaf9bafcb856da4ece1e68 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 01:00:23 +0200
Subject: [PATCH 08/35] make style

---
 armsrc/appmain.c                  |  20 ++--
 armsrc/em4x50.c                   |  22 ++--
 armsrc/iclass.c                   |  30 +++---
 armsrc/iso14443a.c                |   2 +-
 armsrc/iso15693.c                 |  12 +--
 armsrc/mifarecmd.c                |  18 ++--
 client/deps/cliparser/cliparser.c |  16 +--
 client/src/cmdhf14a.c             |  22 ++--
 client/src/cmdhf14b.c             |   2 +-
 client/src/cmdhf15.c              |  22 ++--
 client/src/cmdhficlass.c          |  70 ++++++-------
 client/src/cmdhfmfp.c             |   4 +-
 client/src/cmdhfmfu.c             |  80 +++++++-------
 client/src/cmdhfst.c              |   6 +-
 client/src/cmdlf.c                |   2 +-
 client/src/cmdlfdestron.c         |   8 +-
 client/src/cmdlfem4x05.c          | 168 +++++++++++++++---------------
 client/src/cmdlfem4x50.c          |   2 +-
 client/src/cmdlffdxb.c            |   6 +-
 client/src/cmdlfindala.c          |   4 +-
 client/src/cmdlfmotorola.c        |   8 +-
 client/src/scripting.c            |  18 ++--
 doc/commands.md                   |  25 ++++-
 include/pm3_cmd.h                 |   2 +-
 24 files changed, 292 insertions(+), 277 deletions(-)

diff --git a/armsrc/appmain.c b/armsrc/appmain.c
index 02d6f1d23..6b127c831 100644
--- a/armsrc/appmain.c
+++ b/armsrc/appmain.c
@@ -1481,12 +1481,12 @@ static void PacketReceived(PacketCommandNG *packet) {
             MifareU_Otp_Tearoff(packet->oldarg[0], packet->oldarg[1], packet->data.asBytes);
             break;
         }
-        case CMD_HF_MFU_COUNTER_TEAROFF: {            
+        case CMD_HF_MFU_COUNTER_TEAROFF: {
             struct p {
                 uint8_t counter;
                 uint32_t tearoff_time;
             } PACKED;
-            struct p *payload = (struct p *) packet->data.asBytes;             
+            struct p *payload = (struct p *) packet->data.asBytes;
             MifareU_Counter_Tearoff(payload->counter, payload->tearoff_time);
             break;
         }
@@ -1520,13 +1520,13 @@ static void PacketReceived(PacketCommandNG *packet) {
             break;
         }
         case CMD_HF_ICLASS_SIMULATE: {
-/*
-            struct p {
-                uint8_t reader[4];
-                uint8_t mac[4];
-            } PACKED;
-            struct p *payload = (struct p *) packet->data.asBytes;
-*/
+            /*
+                        struct p {
+                            uint8_t reader[4];
+                            uint8_t mac[4];
+                        } PACKED;
+                        struct p *payload = (struct p *) packet->data.asBytes;
+            */
 
             SimulateIClass(packet->oldarg[0], packet->oldarg[1], packet->oldarg[2], packet->data.asBytes);
             break;
@@ -1562,7 +1562,7 @@ static void PacketReceived(PacketCommandNG *packet) {
             break;
         }
         case CMD_HF_ICLASS_RESTORE: {
-            iClass_Restore( (iclass_restore_req_t *)packet->data.asBytes);
+            iClass_Restore((iclass_restore_req_t *)packet->data.asBytes);
             break;
         }
 #endif
diff --git a/armsrc/em4x50.c b/armsrc/em4x50.c
index bce422908..9ab8dcf35 100644
--- a/armsrc/em4x50.c
+++ b/armsrc/em4x50.c
@@ -889,18 +889,18 @@ static int write(uint8_t word[4], uint8_t address) {
             return PM3_ETEAROFF;
         } else {
 
-                // wait for T0 * EM4X50_T_TAG_TWA (write access time)
-                wait_timer(FPGA_TIMER_0, T0 * EM4X50_T_TAG_TWA);
+            // wait for T0 * EM4X50_T_TAG_TWA (write access time)
+            wait_timer(FPGA_TIMER_0, T0 * EM4X50_T_TAG_TWA);
 
-                // look for ACK sequence
-                if (check_ack(false)) {
+            // look for ACK sequence
+            if (check_ack(false)) {
 
-                    // now EM4x50 needs T0 * EM4X50_T_TAG_TWEE (EEPROM write time)
-                    // for saving data and should return with ACK
-                    if (check_ack(false))
-                        return PM3_SUCCESS;
+                // now EM4x50 needs T0 * EM4X50_T_TAG_TWEE (EEPROM write time)
+                // for saving data and should return with ACK
+                if (check_ack(false))
+                    return PM3_SUCCESS;
 
-                }
+            }
         }
 
     } else {
@@ -985,7 +985,7 @@ void em4x50_write(em4x50_data_t *etd) {
             lf_finalize();
             return;
         }
-        
+
         if (res == PM3_SUCCESS) {
             // to verify result reset EM4x50
             if (reset()) {
@@ -1033,7 +1033,7 @@ void em4x50_write_password(em4x50_data_t *etd) {
 
         // login and change password
         if (login(etd->password)) {
-            
+
             int res = write_password(etd->password, etd->new_password);
             if (res == PM3_ETEAROFF) {
                 lf_finalize();
diff --git a/armsrc/iclass.c b/armsrc/iclass.c
index 204cd9ea1..03f7dcbba 100644
--- a/armsrc/iclass.c
+++ b/armsrc/iclass.c
@@ -1367,7 +1367,7 @@ static bool select_iclass_tag_ex(picopass_hdr *hdr, bool use_credit_key, uint32_
         *status |= FLAG_ICLASS_CC;
 
     }  else {
-        
+
         // on NON_SECURE_PAGEMODE cards, AIA is on block2..
 
         // read App Issuer Area block 2
@@ -1443,7 +1443,7 @@ void ReaderIClass(uint8_t flags) {
     // with 0xFF:s in block 3 and 4.
 
     LED_B_ON();
-    reply_mix(CMD_ACK, result_status, 0, 0, (uint8_t*)&hdr, sizeof(hdr));
+    reply_mix(CMD_ACK, result_status, 0, 0, (uint8_t *)&hdr, sizeof(hdr));
 
     //Send back to client, but don't bother if we already sent this -
     //  only useful if looping in arm (not try_once && not abort_after_read)
@@ -1489,9 +1489,9 @@ bool authenticate_iclass_tag(iclass_auth_req_t *payload, picopass_hdr *hdr, uint
 
     memcpy(ccnr, hdr->epurse, sizeof(hdr->epurse));
 
-    if ( payload->use_replay) {
+    if (payload->use_replay) {
 
-        memcpy(pmac, payload->key + 4, 4);        
+        memcpy(pmac, payload->key + 4, 4);
         memcpy(cmd_check + 1, payload->key, 8);
 
     } else {
@@ -1780,7 +1780,7 @@ static bool iclass_writeblock_ext(uint8_t blockno, uint8_t *data, uint8_t *mac)
 
     // write command: cmd, 1 blockno, 8 data, 4 mac
     uint8_t write[16] = { 0x80 | ICLASS_CMD_UPDATE, blockno };
-    memcpy(write + 2, data, 8); 
+    memcpy(write + 2, data, 8);
     memcpy(write + 10, mac, 4);
     AddCrc(write + 1, 13);
 
@@ -1872,11 +1872,11 @@ void iClass_WriteBlock(uint8_t *msg) {
         iclass_send_as_reader(write, sizeof(write), &start_time, &eof_time);
 
         if (tearoff_hook() == PM3_ETEAROFF) { // tearoff occured
-                res = false;
-                switch_off();
-                if (payload->req.send_reply)
-                    reply_ng(CMD_HF_ICLASS_WRITEBL, PM3_ETEAROFF, (uint8_t *)&res, sizeof(uint8_t));
-                return;
+            res = false;
+            switch_off();
+            if (payload->req.send_reply)
+                reply_ng(CMD_HF_ICLASS_WRITEBL, PM3_ETEAROFF, (uint8_t *)&res, sizeof(uint8_t));
+            return;
         } else {
 
             if (GetIso15693AnswerFromTag(resp, sizeof(resp), ICLASS_READER_TIMEOUT_UPDATE, &eof_time) == 10) {
@@ -1885,7 +1885,7 @@ void iClass_WriteBlock(uint8_t *msg) {
             }
         }
     }
-    
+
     if (tries == 0) {
         res = false;
         goto out;
@@ -1932,7 +1932,7 @@ void iClass_Restore(iclass_restore_req_t *msg) {
         if (msg->req.send_reply) {
             reply_ng(CMD_HF_ICLASS_RESTORE, PM3_ESOFT, NULL, 0);
         }
-        return;        
+        return;
     }
 
     LED_A_ON();
@@ -1942,7 +1942,7 @@ void iClass_Restore(iclass_restore_req_t *msg) {
     uint32_t eof_time = 0;
     picopass_hdr hdr = {0};
 
-    // select 
+    // select
     bool res = select_iclass_tag(&hdr, msg->req.use_credit_key, &eof_time);
     if (res == false) {
         goto out;
@@ -1974,7 +1974,7 @@ void iClass_Restore(iclass_restore_req_t *msg) {
             doMAC_N(wb, sizeof(wb), hdr.key_c, mac);
         else
             doMAC_N(wb, sizeof(wb), hdr.key_d, mac);
-        
+
         // data + mac
         if (iclass_writeblock_ext(item.blockno, item.data, mac)) {
             Dbprintf("Write block [%02x] " _GREEN_("successful"), item.blockno);
@@ -1983,7 +1983,7 @@ void iClass_Restore(iclass_restore_req_t *msg) {
             Dbprintf("Write block [%02x] " _RED_("failed"), item.blockno);
         }
     }
-    
+
 out:
 
     switch_off();
diff --git a/armsrc/iso14443a.c b/armsrc/iso14443a.c
index d40080ae1..6e1e22738 100644
--- a/armsrc/iso14443a.c
+++ b/armsrc/iso14443a.c
@@ -2629,7 +2629,7 @@ int iso14443a_select_card(uint8_t *uid_ptr, iso14a_card_select_t *p_card, uint32
         AddCrc14A(rats, 2);
         ReaderTransmit(rats, sizeof(rats), NULL);
         int len = ReaderReceive(resp, resp_par);
-        if (len == 0) 
+        if (len == 0)
             return 0;
 
         if (p_card) {
diff --git a/armsrc/iso15693.c b/armsrc/iso15693.c
index 00af14c4f..bacceb165 100644
--- a/armsrc/iso15693.c
+++ b/armsrc/iso15693.c
@@ -1474,13 +1474,13 @@ int SendDataTag(uint8_t *send, int sendlen, bool init, bool speed_fast, uint8_t
     int res = 0;
     tosend_t *ts = get_tosend();
     TransmitTo15693Tag(ts->buf, ts->max, &start_time);
-    
+
     if (tearoff_hook() == PM3_ETEAROFF) { // tearoff occured
 
         res = PM3_ETEAROFF;
 
     } else {
-    
+
         *eof_time = start_time + 32 * ((8 * ts->max) - 4); // substract the 4 padding bits after EOF
         LogTrace_ISO15693(send, sendlen, (start_time * 4), (*eof_time * 4), NULL, true);
         if (recv != NULL) {
@@ -1595,11 +1595,11 @@ void ReaderIso15693(uint32_t parameter) {
     uint32_t start_time = 0;
     uint32_t eof_time;
     int recvlen = SendDataTag(cmd, sizeof(cmd), true, true, answer, ISO15693_MAX_RESPONSE_LENGTH, start_time, ISO15693_READER_TIMEOUT, &eof_time);
-    
+
     if (recvlen == PM3_ETEAROFF) { // tearoff occured
         reply_mix(CMD_ACK, recvlen, 0, 0, NULL, 0);
     } else {
-        
+
         start_time = eof_time + DELAY_ISO15693_VICC_TO_VCD_READER;
 
         // we should do a better check than this
@@ -1634,7 +1634,7 @@ void ReaderIso15693(uint32_t parameter) {
             }
         } else {
             DbpString("Failed to select card");
-            reply_mix(CMD_ACK, 0, 0, 0, NULL, 0);            
+            reply_mix(CMD_ACK, 0, 0, 0, NULL, 0);
         }
     }
     switch_off();
@@ -1869,7 +1869,7 @@ void DirectTag15693Command(uint32_t datalen, uint32_t speed, uint32_t recv, uint
         }
 
         if (recv) {
-            recvlen = MIN(recvlen,ISO15693_MAX_RESPONSE_LENGTH);
+            recvlen = MIN(recvlen, ISO15693_MAX_RESPONSE_LENGTH);
             reply_mix(CMD_ACK, recvlen, 0, 0, recvbuf, recvlen);
         } else {
             reply_mix(CMD_ACK, 1, 0, 0, NULL, 0);
diff --git a/armsrc/mifarecmd.c b/armsrc/mifarecmd.c
index f442166f4..11c89a98b 100644
--- a/armsrc/mifarecmd.c
+++ b/armsrc/mifarecmd.c
@@ -2752,15 +2752,15 @@ void MifareU_Counter_Tearoff(uint8_t counter, uint32_t tearoff_time) {
 
     // Send MFU counter increase cmd
     uint8_t cmd[] = {
-            MIFARE_ULEV1_INCR_CNT,
-            counter,
-            0,  // lsb
-            0,  
-            0,  // msb
-            0,  // rfu
-            0,
-            0,
-        };
+        MIFARE_ULEV1_INCR_CNT,
+        counter,
+        0,  // lsb
+        0,
+        0,  // msb
+        0,  // rfu
+        0,
+        0,
+    };
     AddCrc14A(cmd, sizeof(cmd) - 2);
 
     // anticollision / select card
diff --git a/client/deps/cliparser/cliparser.c b/client/deps/cliparser/cliparser.c
index a601e6490..258346c00 100644
--- a/client/deps/cliparser/cliparser.c
+++ b/client/deps/cliparser/cliparser.c
@@ -205,9 +205,9 @@ int CLIParamHexToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int
 
     int tmplen = 0;
     uint8_t tmpstr[(256 * 2) + 1] = {0};
-    
+
     // concat all strings in argstr into tmpstr[]
-    // 
+    //
     int res = CLIParamStrToBuf(argstr, tmpstr, sizeof(tmpstr), &tmplen);
     if (res) {
         return res;
@@ -216,7 +216,7 @@ int CLIParamHexToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int
         return res;
     }
 
-    res = param_gethex_to_eol((char*)tmpstr, 0, data, maxdatalen, datalen);
+    res = param_gethex_to_eol((char *)tmpstr, 0, data, maxdatalen, datalen);
     switch (res) {
         case 1:
             printf("Parameter error: Invalid HEX value\n");
@@ -241,20 +241,20 @@ int CLIParamStrToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int
     int ibuf = 0;
 
     for (int i = 0; i < argstr->count; i++) {
-        
+
         int len = strlen(argstr->sval[i]);
-            
-        if (len > ( (sizeof(tmpstr) / 2 ) - ibuf)) {
+
+        if (len > ((sizeof(tmpstr) / 2) - ibuf)) {
             printf("Parameter error: string too long (%i chars), expect MAX %zu chars\n", len + ibuf, (sizeof(tmpstr) / 2));
             fflush(stdout);
             return 2;
         }
-                
+
         memcpy(&tmpstr[ibuf], argstr->sval[i], len);
 
         ibuf += len;
     }
-    
+
     ibuf = MIN(ibuf, (sizeof(tmpstr) / 2));
     tmpstr[ibuf] = 0;
 
diff --git a/client/src/cmdhf14a.c b/client/src/cmdhf14a.c
index 837311062..dac2193c6 100644
--- a/client/src/cmdhf14a.c
+++ b/client/src/cmdhf14a.c
@@ -1843,30 +1843,30 @@ int infoHF14A(bool verbose, bool do_nack_test, bool do_aid_search) {
                     if (memcmp(card.ats + pos, "\xC1\x05\x2F\x2F\x01\xBC\xD6", 7) == 0) {
                         tip = "-> MIFARE Plus X 2K/4K (SL3)";
                     } else if (memcmp(card.ats + pos, "\xC1\x05\x2F\x2F\x00\x35\xC7", 7) == 0) {
-                        
+
                         if ((card.atqa[0] & 0x02) == 0x02)
                             tip = "-> MIFARE Plus S 2K (SL3)";
                         else if ((card.atqa[0] & 0x04) == 0x04)
                             tip = "-> MIFARE Plus S 4K (SL3)";
-                        
+
                     } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x00\xF6\xD1", 7) == 0) {
                         tip = "-> MIFARE Plus SE 1K (17pF)";
-                    } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x10\xF6\xD1", 7) == 0) {    
+                    } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x10\xF6\xD1", 7) == 0) {
                         tip = "-> MIFARE Plus SE 1K (70pF)";
                     }
-                
-                } else {  //SAK B4,5,6 
-                
-                    if ((card.sak & 0x20) == 0x20) {  // and no GetVersion()..    
-                    
-                        
+
+                } else {  //SAK B4,5,6
+
+                    if ((card.sak & 0x20) == 0x20) {  // and no GetVersion()..
+
+
                         if (memcmp(card.ats + pos, "\xC1\x05\x2F\x2F\x01\xBC\xD6", 7) == 0) {
                             tip = "-> MIFARE Plus X 2K (SL1)";
                         } else if (memcmp(card.ats + pos, "\xC1\x05\x2F\x2F\x00\x35\xC7", 7) == 0) {
                             tip = "-> MIFARE Plus S 2K (SL1)";
                         } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x00\xF6\xD1", 7) == 0) {
                             tip = "-> MIFARE Plus SE 1K (17pF)";
-                        } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x10\xF6\xD1", 7) == 0) {    
+                        } else if (memcmp(card.ats + pos, "\xC1\x05\x21\x30\x10\xF6\xD1", 7) == 0) {
                             tip = "-> MIFARE Plus SE 1K (70pF)";
                         }
                     } else {
@@ -1874,7 +1874,7 @@ int infoHF14A(bool verbose, bool do_nack_test, bool do_aid_search) {
                             tip = "-> MIFARE Plus X 4K (SL1)";
                         } else if (memcmp(card.ats + pos, "\xC1\x05\x2F\x2F\x00\x35\xC7", 7) == 0) {
                             tip = "-> MIFARE Plus S 4K (SL1)";
-                        }                            
+                        }
                     }
                 }
 
diff --git a/client/src/cmdhf14b.c b/client/src/cmdhf14b.c
index 85898fe04..73f8c2a8f 100644
--- a/client/src/cmdhf14b.c
+++ b/client/src/cmdhf14b.c
@@ -149,7 +149,7 @@ static int CmdHF14BSim(const char *Cmd) {
         PrintAndLogEx(FAILED, "failed to read pupi");
         return PM3_EINVARG;
     }
-    
+
     PrintAndLogEx(INFO, "Simulate with PUPI : " _GREEN_("%s"), sprint_hex_inrow(pupi, sizeof(pupi)));
     PrintAndLogEx(INFO, "Press pm3-button to abort simulation");
     clearCommandBuffer();
diff --git a/client/src/cmdhf15.c b/client/src/cmdhf15.c
index b4cde234f..6d276617c 100644
--- a/client/src/cmdhf15.c
+++ b/client/src/cmdhf15.c
@@ -656,13 +656,13 @@ static int CmdHF15Demod(const char *Cmd) {
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     CLIParserFree(ctx);
-    
+
     // The sampling rate is 106.353 ksps/s, for T = 18.8 us
     int i, j;
     int max = 0, maxPos = 0;
     int skip = 4;
 
-    if (GraphTraceLen < 1000) {        
+    if (GraphTraceLen < 1000) {
         PrintAndLogEx(FAILED, "Too few samples in GraphBuffer. Need more than 1000");
         PrintAndLogEx(HINT, "Run " _YELLOW_("`hf 15 samples`") " to collect and download data");
         return PM3_ESOFT;
@@ -733,8 +733,8 @@ static int CmdHF15Demod(const char *Cmd) {
         PrintAndLogEx(WARNING, "Warning, uneven octet! (discard extra bits!)");
         PrintAndLogEx(INFO, "   mask = %02x", mask);
     }
-    
-    if ( k == 0 ) {
+
+    if (k == 0) {
         return PM3_SUCCESS;
     }
 
@@ -744,7 +744,7 @@ static int CmdHF15Demod(const char *Cmd) {
     PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(SUCCESS, " idx | data");
     PrintAndLogEx(SUCCESS, "-----+-------------------------------------------------");
-    if ( k / 16 > 0) {
+    if (k / 16 > 0) {
         for (; i < k; i += 16) {
             PrintAndLogEx(SUCCESS, " %3i | %s", i, sprint_hex(outBuf + i, 16));
         }
@@ -824,7 +824,7 @@ static int NxpSysInfo(uint8_t *uid) {
     if (status == PM3_ETEAROFF) {
         return status;
     }
-    
+
     if (status < 2) {
         PrintAndLogEx(WARNING, "iso15693 card doesn't answer to NXP systeminfo command");
         return PM3_EWRONGANSWER;
@@ -1058,7 +1058,7 @@ static int CmdHF15Sniff(const char *Cmd) {
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     CLIParserFree(ctx);
-    
+
     PacketResponseNG resp;
     clearCommandBuffer();
     SendCommandNG(CMD_HF_ISO15693_SNIFF, NULL, 0);
@@ -1111,7 +1111,7 @@ static int CmdHF15Sim(const char *Cmd) {
     struct {
         uint8_t uid[8];
     } PACKED payload;
-    
+
     int uidlen = 0;
     CLIGetHexWithReturn(ctx, 1, payload.uid, &uidlen);
     CLIParserFree(ctx);
@@ -1904,11 +1904,11 @@ static int CmdHF15CSetUID(const char *Cmd) {
     struct {
         uint8_t uid[8];
     } PACKED payload;
-    
+
     int uidlen = 0;
     CLIGetHexWithReturn(ctx, 1, payload.uid, &uidlen);
     CLIParserFree(ctx);
-    
+
     if (uidlen != 8) {
         PrintAndLogEx(WARNING, "UID must include 16 HEX symbols got ");
         return PM3_EINVARG;
@@ -1936,7 +1936,7 @@ static int CmdHF15CSetUID(const char *Cmd) {
     if (WaitForResponseTimeout(CMD_HF_ISO15693_CSETUID, &resp, 2000) == false) {
         PrintAndLogEx(WARNING, "timeout while waiting for reply");
         DropField();
-        return PM3_ESOFT;        
+        return PM3_ESOFT;
     }
 
     PrintAndLogEx(INFO, "getting updated card details...");
diff --git a/client/src/cmdhficlass.c b/client/src/cmdhficlass.c
index e9aaa1880..782e782eb 100644
--- a/client/src/cmdhficlass.c
+++ b/client/src/cmdhficlass.c
@@ -427,7 +427,7 @@ static void fuse_config(const picopass_hdr *hdr) {
 
     uint16_t otp = (hdr->conf.otp[1] << 8 | hdr->conf.otp[0]);
 
-    PrintAndLogEx(INFO, "    Raw: " _YELLOW_("%s"), sprint_hex((uint8_t*)&hdr->conf, 8));
+    PrintAndLogEx(INFO, "    Raw: " _YELLOW_("%s"), sprint_hex((uint8_t *)&hdr->conf, 8));
     PrintAndLogEx(INFO, "         " _YELLOW_("%02X") ".....................  app limit", hdr->conf.app_limit);
     PrintAndLogEx(INFO, "            " _YELLOW_("%04X") " ( %5u )......  OTP", otp, otp);
     PrintAndLogEx(INFO, "                  " _YELLOW_("%02X") "............  block write lock", hdr->conf.block_writelock);
@@ -1540,7 +1540,7 @@ static int CmdHFiClassDump(const char *Cmd) {
                 PrintAndLogEx(SUCCESS, "Using " _YELLOW_("replay NR/MAC mode"));
                 use_replay = true;
                 cmdp++;
-                break; 
+                break;
             default:
                 PrintAndLogEx(WARNING, "Unknown parameter '%c'\n", param_getchar(Cmd, cmdp));
                 errors = true;
@@ -1552,7 +1552,7 @@ static int CmdHFiClassDump(const char *Cmd) {
         PrintAndLogEx(FAILED, "Can not use a combo of 'e', 'r', 'n'");
         errors = true;
     }
-    
+
     if (errors) return usage_hf_iclass_dump();
 
     uint32_t flags = (FLAG_ICLASS_READER_INIT | FLAG_ICLASS_READER_CLEARTRACE);
@@ -1788,7 +1788,7 @@ write_dump:
 }
 
 static int iclass_write_block(uint8_t blockno, uint8_t *bldata, uint8_t *KEY, bool use_credit_key, bool elite, bool rawkey, bool replay, bool verbose) {
- 
+
     iclass_writeblock_req_t payload = {
         .req.use_raw = rawkey,
         .req.use_elite = elite,
@@ -1882,13 +1882,13 @@ static int CmdHFiClass_WriteBlock(const char *Cmd) {
                 rawkey = true;
                 cmdp++;
                 break;
-/*
-            case 'n':
-                PrintAndLogEx(SUCCESS, "Using " _YELLOW_("replay NR/MAC mode"));
-                use_replay = true;
-                cmdp++;
-                break;  
-*/                
+            /*
+                        case 'n':
+                            PrintAndLogEx(SUCCESS, "Using " _YELLOW_("replay NR/MAC mode"));
+                            use_replay = true;
+                            cmdp++;
+                            break;
+            */
             case 'v':
                 verbose = true;
                 cmdp++;
@@ -1910,7 +1910,7 @@ static int CmdHFiClass_WriteBlock(const char *Cmd) {
     if (errors || cmdp < 6) return usage_hf_iclass_writeblock();
 
     int isok = iclass_write_block(blockno, bldata, KEY, use_credit_key, elite, rawkey, use_replay, verbose);
-    switch(isok) {
+    switch (isok) {
         case PM3_SUCCESS:
             PrintAndLogEx(SUCCESS, "Wrote block %02X successful", blockno);
             break;
@@ -2043,24 +2043,24 @@ static int CmdHFiClassRestore(const char *Cmd) {
         return PM3_EFILE;
     }
 
-    if (bytes_read < ((endblock - startblock + 1) * 8 )) {
+    if (bytes_read < ((endblock - startblock + 1) * 8)) {
         PrintAndLogEx(ERR, "file is smaller than your suggested block range ( " _RED_("0x%02x..0x%02x")" )",
-                startblock, endblock
-                );
+                      startblock, endblock
+                     );
         free(dump);
         return PM3_EFILE;
     }
 
     iclass_restore_req_t *payload = calloc(1, payload_size);
     payload->req.use_raw = rawkey,
-    payload->req.use_elite = elite,
-    payload->req.use_credit_key = use_credit_key,
-    payload->req.use_replay = false,
-    payload->req.blockno = startblock,
-    payload->req.send_reply = true,
-    payload->req.do_auth = true,
-    memcpy(payload->req.key, KEY, 8);
-    
+             payload->req.use_elite = elite,
+                      payload->req.use_credit_key = use_credit_key,
+                               payload->req.use_replay = false,
+                                        payload->req.blockno = startblock,
+                                                 payload->req.send_reply = true,
+                                                          payload->req.do_auth = true,
+                                                                   memcpy(payload->req.key, KEY, 8);
+
     payload->item_cnt = (endblock - startblock + 1);
 
     // read data from file from block 6 --- 19
@@ -2068,21 +2068,21 @@ static int CmdHFiClassRestore(const char *Cmd) {
     // then copy to usbcommand->asbytes;
     // max is 32 - 6 = 28 block.  28 x 12 bytes gives 336 bytes
 
-    for (uint8_t i = 0; i < payload->item_cnt; i++) {        
+    for (uint8_t i = 0; i < payload->item_cnt; i++) {
         payload->blocks[i].blockno = startblock + i;
-        memcpy(payload->blocks[i].data, dump + (startblock * 8) + (i * 8) , sizeof(payload->blocks[i].data));
+        memcpy(payload->blocks[i].data, dump + (startblock * 8) + (i * 8), sizeof(payload->blocks[i].data));
     }
 
     free(dump);
 
     if (verbose) {
         PrintAndLogEx(INFO, "Preparing to restore block range 0x%02x..0x%02x", startblock, endblock);
-        
+
         PrintAndLogEx(INFO, "------+----------------------");
         PrintAndLogEx(INFO, "block | data");
         PrintAndLogEx(INFO, "------+----------------------");
 
-        for (uint8_t i = 0; i < payload->item_cnt; i++) {           
+        for (uint8_t i = 0; i < payload->item_cnt; i++) {
             iclass_restore_item_t item = payload->blocks[i];
             PrintAndLogEx(INFO, "  %02X  | %s", item.blockno, sprint_hex_inrow(item.data, sizeof(item.data)));
         }
@@ -2233,7 +2233,7 @@ static int CmdHFiClass_ReadBlock(const char *Cmd) {
     }
     if (got_blockno == false)
         errors = true;
-    
+
     if ((use_replay + rawkey + elite) > 1) {
         PrintAndLogEx(FAILED, "Can not use a combo of 'e', 'r', 'n'");
         errors = true;
@@ -2405,7 +2405,7 @@ void printIclassDumpContents(uint8_t *iclass_dump, uint8_t startblock, uint8_t e
     PrintAndLogEx(INFO, " blk| data                    | ascii    |lck| info");
     PrintAndLogEx(INFO, "----+-------------------------+----------+---+--------------");
     PrintAndLogEx(INFO, "0x00| " _GREEN_("%s") " |   | CSN ", sprint_hex_ascii(iclass_dump, 8));
-    
+
     if (i != 1)
         PrintAndLogEx(INFO, "....");
 
@@ -2455,8 +2455,8 @@ void printIclassDumpContents(uint8_t *iclass_dump, uint8_t startblock, uint8_t e
             const char *s = info_nonks[3];
             if (i < 3) {
                 s = info_nonks[i];
-            }            
-           
+            }
+
             PrintAndLogEx(INFO, "0x%02X| %s | %s | %s ", i, sprint_hex_ascii(blk, 8), lockstr, s);
         } else {
             const char *info_ks[] = {"CSN", "Config", "E-purse", "Debit", "Credit", "AIA", "User"};
@@ -2978,8 +2978,8 @@ static int CmdHFiClassCheckKeys(const char *Cmd) {
         free(keyBlock);
         return res;
     }
-    
-        // Get CSN / UID and CCNR
+
+    // Get CSN / UID and CCNR
     PrintAndLogEx(SUCCESS, "Reading tag CSN / CCNR...");
     for (uint8_t i = 0; i < ICLASS_AUTH_RETRY && !got_csn; i++) {
         got_csn = select_only(CSN, CCNR, false);
@@ -2993,7 +2993,7 @@ static int CmdHFiClassCheckKeys(const char *Cmd) {
         DropField();
         return PM3_ESOFT;
     }
-    
+
     iclass_premac_t *pre = calloc(keycount, sizeof(iclass_premac_t));
     if (pre == NULL) {
         return PM3_EMALLOC;
@@ -3449,7 +3449,7 @@ static int CmdHFiClassAutopwn(const char *Cmd) {
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     CLIParserFree(ctx);
-    
+
     // Check keys.
 
     // dump
diff --git a/client/src/cmdhfmfp.c b/client/src/cmdhfmfp.c
index 7d9c077fb..fd0f6c93a 100644
--- a/client/src/cmdhfmfp.c
+++ b/client/src/cmdhfmfp.c
@@ -294,9 +294,9 @@ static int CmdHFMFPInfo(const char *Cmd) {
     } else {
         // info about 14a part
         infoHF14A(false, false, false);
-        
+
         // Historical bytes.
-        
+
     }
 
 
diff --git a/client/src/cmdhfmfu.c b/client/src/cmdhfmfu.c
index c472b8d59..55e03a848 100644
--- a/client/src/cmdhfmfu.c
+++ b/client/src/cmdhfmfu.c
@@ -242,7 +242,7 @@ static int usage_hf_mfu_otp_tearoff(void) {
     PrintAndLogEx(NORMAL, "  s <time>  : (optional) start time to run the test - default 0 us");
     PrintAndLogEx(NORMAL, "  d <data>  : (optional) data to full-write before trying the OTP test - default 0x00");
     PrintAndLogEx(NORMAL, "  t <data>  : (optional) data to write while running the OTP test - default 0x00");
-    PrintAndLogEx(NORMAL, "  m <data>  : (optional) exit criteria, if block matches this value");    
+    PrintAndLogEx(NORMAL, "  m <data>  : (optional) exit criteria, if block matches this value");
     PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(NORMAL, "Examples:");
     PrintAndLogEx(NORMAL, "        hf mfu otptear b 3");
@@ -362,7 +362,7 @@ static bool ul_select(iso14a_card_select_t *card) {
             return false;
         }
 
-        if (card) 
+        if (card)
             memcpy(card, resp.data.asBytes, sizeof(iso14a_card_select_t));
     }
     return true;
@@ -2897,7 +2897,7 @@ static int CmdHF14AMfuOtpTearoff(const char *Cmd) {
                 }
                 use_match = true;
                 cmdp += 2;
-                break;            
+                break;
             default:
                 PrintAndLogEx(WARNING, "Unknown parameter '%c'", param_getchar(Cmd, cmdp));
                 errors = true;
@@ -2947,9 +2947,9 @@ static int CmdHF14AMfuOtpTearoff(const char *Cmd) {
 
         clearCommandBuffer();
         SendCommandMIX(CMD_HF_MFU_OTP_TEAROFF, blockNoUint, actualTime, 0, teardata, 8);
-        
+
         // we be getting ACK that we are silently ignoring here..
-        
+
         if (!WaitForResponseTimeout(CMD_HF_MFU_OTP_TEAROFF, &resp, 2000)) {
             PrintAndLogEx(WARNING, "Failed");
             return PM3_ESOFT;
@@ -3061,7 +3061,7 @@ static int CmdHF14AMfuOtpTearoff(const char *Cmd) {
 
 /*
 static int counter_reset_tear(iso14a_card_select_t *card, uint8_t cnt_no) {
-                    
+
     PrintAndLogEx(INFO, "Reset tear check");
 
     uint8_t cw[6] = { MIFARE_ULEV1_INCR_CNT, cnt_no, 0x00, 0x00, 0x00, 0x00};
@@ -3081,7 +3081,7 @@ static int counter_reset_tear(iso14a_card_select_t *card, uint8_t cnt_no) {
         return PM3_ESOFT;
     }
     DropField();
-    
+
     if (ct[0] != 0xBD) {
         PrintAndLogEx(INFO, "Resetting seem to have failed, WHY!?");
         return PM3_ESOFT;
@@ -3106,13 +3106,13 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
         arg_int0("c", "cnt", "<0,1,2>", "Target this EV1 counter (0,1,2)"),
         arg_int0("i", "inc", "<dec>", "time interval to increase in each iteration - default 10 us"),
         arg_int0("l", "limit", "<dec>", "test upper limit time - default 3000 us"),
-        arg_int0("s", "start", "<dec>", "test start time - default 0 us"), 
-        arg_int0(NULL, "fix", "<dec>", "test fixed loop delay"),         
+        arg_int0("s", "start", "<dec>", "test start time - default 0 us"),
+        arg_int0(NULL, "fix", "<dec>", "test fixed loop delay"),
         arg_str0("x", "hex",  NULL, "3 byte hex to increase counter with"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, false);
-    
+
     int interval = 0;
     int time_limit, start_time = 0;
     int counter = arg_get_int_def(ctx, 1, 0);
@@ -3124,15 +3124,15 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
         start_time = arg_get_int_def(ctx, 4, 0);
     } else {
         start_time = fixed;
-        interval = 0;        
+        interval = 0;
         time_limit = fixed;
     }
-    
+
     uint8_t newvalue[5] = {0};
     int newvaluelen = 0;
     CLIGetHexWithReturn(ctx, 6, newvalue, &newvaluelen);
     CLIParserFree(ctx);
-    
+
     // Validations
     if (start_time > (time_limit - interval)) {
         PrintAndLogEx(WARNING, "Wrong start time number");
@@ -3163,14 +3163,14 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
         PrintAndLogEx(INFO, "failed to select card,  exiting...");
         return PM3_ESOFT;
     }
-   
+
     uint8_t inital_cnt[3] = {0, 0, 0};
     int len = ulev1_readCounter(cnt_no, inital_cnt, sizeof(inital_cnt));
     if ( len != sizeof(inital_cnt) ) {
         PrintAndLogEx(WARNING, "failed to read counter");
         return PM3_ESOFT;
     }
-            
+
     uint8_t inital_tear[1] = {0};
     len = ulev1_readTearing(cnt_no, inital_tear, sizeof(inital_tear));
     DropField();
@@ -3184,7 +3184,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
 
     PrintAndLogEx(INFO, "----------------- " _CYAN_("MFU Ev1 Counter Tear off") " ---------------------");
     PrintAndLogEx(INFO, "Target counter no     [ " _GREEN_("%u") " ]", counter);
-    PrintAndLogEx(INFO, "       counter value  [ " _GREEN_("%s") " ]", sprint_hex_inrow(inital_cnt, sizeof(inital_cnt)));    
+    PrintAndLogEx(INFO, "       counter value  [ " _GREEN_("%s") " ]", sprint_hex_inrow(inital_cnt, sizeof(inital_cnt)));
     PrintAndLogEx(INFO, "     anti-tear value  [ " _GREEN_("%02X") " ]", inital_tear[0]);
     PrintAndLogEx(INFO, "       increase value [ " _GREEN_("%s") " ]", sprint_hex_inrow(newvalue, newvaluelen));
     PrintAndLogEx(INFO, "----------------------------------------------------");
@@ -3197,7 +3197,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
     uint32_t loop = 0;
 
     uint16_t late = 0;
-    
+
     while (actual_time <= (time_limit - interval)) {
 
 
@@ -3217,7 +3217,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
             continue;
         }
 
-        uint8_t cntresp[3] = {0, 0, 0};    
+        uint8_t cntresp[3] = {0, 0, 0};
         int rlen = ulev1_readCounter(cnt_no, cntresp, sizeof(cntresp));
         if ( rlen == sizeof(cntresp) ) {
             memcpy(pre, cntresp, sizeof(pre));
@@ -3226,19 +3226,19 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
             PrintAndLogEx(FAILED, "BEFORE, failed to read COUNTER,  exiting...");
             break;
         }
-        
+
         uint8_t tear[1] = {0};
         int tlen = ulev1_readTearing(cnt_no, tear, sizeof(tear));
         if ( tlen == sizeof(tear) ) {
             pre_tear = tear[0];
         } else {
-            PrintAndLogEx(NORMAL, "");            
+            PrintAndLogEx(NORMAL, "");
             PrintAndLogEx(FAILED, "BEFORE, failed to read ANTITEAR,  exiting...  %d", tlen);
             break;
         }
 
         DropField();
-        
+
         struct p {
             uint8_t counter;
             uint32_t tearoff_time;
@@ -3269,7 +3269,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
             PrintAndLogEx(FAILED, "AFTER, failed to read COUNTER,  exiting...");
             break;
         }
-        
+
         tear[0] = 0;
         tlen = ulev1_readTearing(cnt_no, tear, sizeof(tear));
         if ( tlen == sizeof(tear) ) {
@@ -3279,7 +3279,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
             PrintAndLogEx(FAILED, "AFTER, failed to read ANTITEAR,  exiting...");
             break;
         }
-        
+
         DropField();
 
         char prestr[20] = {0};
@@ -3290,15 +3290,15 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
         bool post_tear_check = (post_tear == 0xBD);
         a = (pre[0] | pre[1] << 8 | pre[2]  << 16);
         b = (post[0] | post[1] << 8 | post[2]  << 16);
-        
+
         // A != B
         if (memcmp(pre, post, sizeof(pre)) != 0) {
 
 
             PrintAndLogEx(NORMAL, "");
-            
+
             if (inital_value != a ) {
-                
+
                 if ( inital_value != b )
                     PrintAndLogEx(INFO, "pre %08x, post %08x != inital %08x  |  tear:  0x%02X  == 0x%02X", a, b, inital_value, pre_tear, post_tear);
                 else
@@ -3319,7 +3319,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
                 );
                 break;
             }
-                
+
             if ( a > b ) {
                 PrintAndLogEx(INFO, _CYAN_("Tear off occured  " _RED_("( LESS )") " ->  ") "%s vs " _GREEN_("%s") "  Tear status:  0x%02X == 0x%02X   ( %s )"
                     , prestr
@@ -3347,14 +3347,14 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
                 newvalue[2] = 0;
 
                 PrintAndLogEx(INFO, "     0x1000000 - 0x%x == 0x%x", b, bar);
-                PrintAndLogEx(INFO, "      new increase value 0x%x" , wr_value);    
+                PrintAndLogEx(INFO, "      new increase value 0x%x" , wr_value);
                 PrintAndLogEx(INFO, "    because BAR + post == 0x%x" , bar + b);
 
                 PrintAndLogEx(INFO, "New increase value " _YELLOW_("%s"), sprint_hex_inrow(newvalue, newvaluelen));
                 continue;
             } else  {
 
-                PrintAndLogEx(NORMAL, "");                
+                PrintAndLogEx(NORMAL, "");
                 PrintAndLogEx(INFO, _CYAN_("Tear off occured  (+1)  (too late) ->  ") "%s vs %s   Tear:  0x%02X == 0x%02X   ( %s )"
                     , prestr
                     , poststr
@@ -3368,23 +3368,23 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
                     break;
                 }
                 if ( wr_value != 0 ) {
-                    
+
                     //uint32_t bar =  (0x1000000 - b) + 2;
                     wr_value = 0;
                     newvalue[0] = 0;
                     newvalue[1] = 0;
                     newvalue[2] = 0;
-                        
+
                     if ( b >= (inital_value + (2 * wr_value))) {
                         PrintAndLogEx(INFO, "Large " _YELLOW_("( JUMP )") " detected");
-                        
-                        
+
+
                         // wr_value = bar;
                         // newvalue[0] = (bar) & 0xFF;
                         // newvalue[1] = ((bar >> 8) & 0xFF);
                         // newvalue[2] = ((bar >> 16) & 0xFF);
                     } else {
-                        
+
                         // wr_value = bar;
                         // newvalue[0] = (bar) & 0xFF;
                         // newvalue[1] = ((bar >> 8) & 0xFF);
@@ -3397,7 +3397,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
 
                 }
                 PrintAndLogEx(INFO, "New increase value " _YELLOW_("%s"), sprint_hex_inrow(newvalue, newvaluelen));
-                
+
                 //actual_time--;
                 late++;
             }
@@ -3410,19 +3410,19 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
                 , post_tear
                 , post_tear_check ? _GREEN_("OK") : _RED_("DETECTED")
             );
-            
+
             if ( post_tear_check ) {
                 if ( a == b ) {
                     //actual_time--;
                     continue;
                 }
-            
+
                 if ( b == inital_value ) {
                     PrintAndLogEx(INFO, "Reverted to previous value");
                     break;
                 }
             } else {
-                
+
                 if (counter_reset_tear(&card, cnt_no) != PM3_SUCCESS){
                     PrintAndLogEx(FAILED, "failed to reset tear,  exiting...");
                     break;
@@ -3436,7 +3436,7 @@ static int CmdHF14AMfuEv1CounterTearoff(const char *Cmd) {
 
     DropField();
 
-    PrintAndLogEx(INFO, " Sent %u tear offs ", loop);    
+    PrintAndLogEx(INFO, " Sent %u tear offs ", loop);
 
     counter_reset_tear(&card, cnt_no);
 
@@ -3584,7 +3584,7 @@ static command_t CommandTable[] = {
     {"gen",     CmdHF14AMfUGenDiverseKeys, AlwaysAvailable, "Generate 3des mifare diversified keys"},
     {"pwdgen",  CmdHF14AMfUPwdGen,         AlwaysAvailable, "Generate pwd from known algos"},
     {"otptear", CmdHF14AMfuOtpTearoff,     IfPm3Iso14443a,  "Tear-off test on OTP bits"},
-//    {"countertear", CmdHF14AMfuEv1CounterTearoff,     IfPm3Iso14443a,  "Tear-off test on Ev1 Counter bits"},        
+//    {"countertear", CmdHF14AMfuEv1CounterTearoff,     IfPm3Iso14443a,  "Tear-off test on Ev1 Counter bits"},
     {"ndef",    CmdHF14MfuNDEF,            IfPm3Iso14443a,  "Prints NDEF records from card"},
     {NULL, NULL, NULL, NULL}
 };
diff --git a/client/src/cmdhfst.c b/client/src/cmdhfst.c
index f48db7e73..89633de8a 100644
--- a/client/src/cmdhfst.c
+++ b/client/src/cmdhfst.c
@@ -523,14 +523,14 @@ static int cmd_hf_st_protect(const char *Cmd) {
     if (enable_protection && disable_protection) {
         PrintAndLogEx(ERR, "Must specify either enable or disable protection, not both");
         return PM3_EINVARG;
-    } 
+    }
     if (enable_protection) {
         state[0] = 0x28;
     }
     if (disable_protection) {
         state[0] = 0x26;
     }
-    
+
     if (read_protection && write_protection) {
         PrintAndLogEx(ERR, "Must specify either read or write protection, not both");
         return PM3_EINVARG;
@@ -681,7 +681,7 @@ static int cmd_hf_st_pwd(const char *Cmd) {
     if (change_write_password) {
         changePwd[2] = 0x02;
     }
-    
+
     if (pwdlen != 16) {
         PrintAndLogEx(ERR, "Original write password must be 16 hex bytes");
         return PM3_EINVARG;
diff --git a/client/src/cmdlf.c b/client/src/cmdlf.c
index f5effbd17..95e38b6c0 100644
--- a/client/src/cmdlf.c
+++ b/client/src/cmdlf.c
@@ -31,7 +31,7 @@
 #include "cmdlfawid.h"      // for awid menu
 #include "cmdlfem4x.h"      // for em4x menu
 #include "cmdlfem4x05.h"    // for em4x05 / 4x69
-#include "cmdlfem4x50.h"    // for em4x50 
+#include "cmdlfem4x50.h"    // for em4x50
 #include "cmdlfhid.h"       // for hid menu
 #include "cmdlfhitag.h"     // for hitag menu
 #include "cmdlfidteck.h"    // for idteck menu
diff --git a/client/src/cmdlfdestron.c b/client/src/cmdlfdestron.c
index 52ae5fc6d..59d0c3813 100644
--- a/client/src/cmdlfdestron.c
+++ b/client/src/cmdlfdestron.c
@@ -66,7 +66,7 @@ int demodDestron(bool verbose) {
 
     uint8_t data[5] = {0};
     uint8_t parity_err = 0;
-    for (int i=0; i < sizeof(data); i++) {
+    for (int i = 0; i < sizeof(data); i++) {
         data[i] = bytebits_to_byte(bits + i * 8, 8);
         parity_err += oddparity8(data[i]);
         data[i] &= 0x7F;
@@ -113,11 +113,11 @@ static int CmdDestronClone(const char *Cmd) {
     CLIParserFree(ctx);
 
     uint8_t data_ex[12 + 24] = {0}; // ManchesterEncode need extra room
-    for (int i=0; i < datalen; i++) {
+    for (int i = 0; i < datalen; i++) {
         data_ex[i + 1] = ~data [i] | (evenparity8(data[i]) << 7);
     }
-    for (int i=0; i < 3; i++) {
-        blocks[i+1] = manchesterEncode2Bytes((data_ex[i*2]<<8)+data_ex[i*2+1]);
+    for (int i = 0; i < 3; i++) {
+        blocks[i + 1] = manchesterEncode2Bytes((data_ex[i * 2] << 8) + data_ex[i * 2 + 1]);
     }
     // inject preamble
     blocks[1] = (blocks[1] & 0xFFFF) | 0xAAE20000;
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 4992ab1c8..cf27030a4 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -107,7 +107,7 @@ typedef enum {
 // 2 = EM4x05
 static em_tech_type_t em_get_card_type(uint32_t config) {
     uint8_t t = (config >> 1) & 0xF;
-    switch(t) {
+    switch (t) {
         case 4:
             return EM_4X69;
         case 8:
@@ -118,7 +118,7 @@ static em_tech_type_t em_get_card_type(uint32_t config) {
     return EM_UNKNOWN;
 }
 
-static const char* em_get_card_str(uint32_t config) {    
+static const char *em_get_card_str(uint32_t config) {
     switch (em_get_card_type(config)) {
         case EM_4305:
             return "EM4305";
@@ -429,9 +429,9 @@ int CmdEM4x05Dump(const char *Cmd) {
 
     void *argtable[] = {
         arg_param_begin,
-        arg_u64_0("p", "pwd", "<hex>", "password (0x00000000)"),        
+        arg_u64_0("p", "pwd", "<hex>", "password (0x00000000)"),
         arg_str0("f", "file", "<filename>", "overide filename prefix (optional).  Default is based on UID"),
-        arg_param_end        
+        arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
 
@@ -440,17 +440,17 @@ int CmdEM4x05Dump(const char *Cmd) {
     char filename[FILE_PATH_SIZE] = {0};
     CLIParamStrToBuf(arg_get_str(ctx, 2), (uint8_t *)filename, FILE_PATH_SIZE, &fnlen);
     CLIParserFree(ctx);
-    
+
     uint8_t addr = 0;
     uint32_t pwd = 0;
-    bool usePwd = false;    
+    bool usePwd = false;
     if (inputpwd != 0xFFFFFFFFFFFFFFFF) {
-        
+
         if (inputpwd & 0xFFFFFFFF00000000) {
             PrintAndLogEx(FAILED, "Pwd too large");
             return PM3_EINVARG;
         }
-        
+
         usePwd = true;
         pwd = (inputpwd & 0xFFFFFFFF);
     }
@@ -470,13 +470,13 @@ int CmdEM4x05Dump(const char *Cmd) {
     bool gotLockBits = false;
     bool lockInPW2 = false;
     uint32_t word = 0;
-    
+
     const char *info[] = {"Info/User", "UID", "Password", "User", "Config", "User", "User", "User", "User", "User", "User", "User", "User", "User", "Lock", "Lock"};
     const char *info4x69 [] = {"Info", "UID", "Password", "Config", "User", "User", "User", "User", "User", "User", "User", "User", "User", "User", "User", "User"};
 
-    // EM4305 vs EM4469 
+    // EM4305 vs EM4469
     em_tech_type_t card_type = em_get_card_type(block0);
-    
+
     PrintAndLogEx(INFO, "Found a " _GREEN_("%s") " tag", em_get_card_str(block0));
 
     if (usePwd) {
@@ -497,7 +497,7 @@ int CmdEM4x05Dump(const char *Cmd) {
     PrintAndLogEx(INFO, "Addr | data     | ascii |lck| info");
     PrintAndLogEx(INFO, "-----+----------+-------+---+-----");
 
-    if ( card_type == EM_4205 || card_type == EM_4305 || card_type == EM_UNKNOWN) {
+    if (card_type == EM_4205 || card_type == EM_4305 || card_type == EM_UNKNOWN) {
 
 
         // To flag any blocks locked we need to read blocks 14 and 15 first
@@ -570,7 +570,7 @@ int CmdEM4x05Dump(const char *Cmd) {
         data[15] = BSWAP_32(data[15]);
 
     } else if (card_type == EM_4X69) {
-        
+
         // To flag any blocks locked we need to read blocks 14 and 15 first
         // dont swap endin until we get block lock flags.
         status14 = EM4x05ReadWord_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word);
@@ -583,7 +583,7 @@ int CmdEM4x05Dump(const char *Cmd) {
         } else {
             success = PM3_ESOFT; // If any error ensure fail is set so not to save invalid data
         }
-        
+
         uint32_t lockbit;
 
         for (; addr < 15; addr++) {
@@ -613,7 +613,7 @@ int CmdEM4x05Dump(const char *Cmd) {
                 }
             }
         }
-        
+
     } else {
     }
 
@@ -621,8 +621,8 @@ int CmdEM4x05Dump(const char *Cmd) {
         // saveFileEML will add .eml extension to filename
         // saveFile (binary) passes in the .bin extension.
         if (strcmp(filename, "") == 0) {
-            
-            if ( card_type == EM_4X69) {
+
+            if (card_type == EM_4X69) {
                 sprintf(filename, "lf-4x69-%08X-dump", BSWAP_32(data[1]));
             } else {
                 sprintf(filename, "lf-4x05-%08X-dump", BSWAP_32(data[1]));
@@ -631,7 +631,7 @@ int CmdEM4x05Dump(const char *Cmd) {
         }
         PrintAndLogEx(NORMAL, "");
         saveFileJSON(filename, (card_type == EM_4X69) ? jsfEM4x69 : jsfEM4x05, (uint8_t *)data, 16 * sizeof(uint32_t), NULL);
-        
+
         saveFileEML(filename, (uint8_t *)data, 16 * sizeof(uint32_t), sizeof(uint32_t));
         saveFile(filename, ".bin", data, sizeof(data));
     }
@@ -941,7 +941,7 @@ static void printEM4x05info(uint32_t block0, uint32_t serial) {
 
     uint8_t chipType = (block0 >> 1) & 0xF;
     uint8_t cap = (block0 >> 5) & 3;
-    uint16_t custCode = (block0 >> 9) & 0x2FF;    
+    uint16_t custCode = (block0 >> 9) & 0x2FF;
 
     /* bits
     //  0,   rfu
@@ -950,7 +950,7 @@ static void printEM4x05info(uint32_t block0, uint32_t serial) {
     //  7,8, rfu
     //  9 - 18 customer code
     //  19,  rfu
-              
+
        98765432109876543210
        001000000000
     // 00100000000001111000
@@ -959,7 +959,7 @@ static void printEM4x05info(uint32_t block0, uint32_t serial) {
     //             011
     // 00100000000
     */
-    
+
     PrintAndLogEx(INFO, "--- " _CYAN_("Tag Information") " ---------------------------");
 
     PrintAndLogEx(SUCCESS, "    Block0: " _GREEN_("%08x") " (Word 0)", block0);
@@ -1037,7 +1037,7 @@ int CmdEM4x05Info(const char *Cmd) {
         return PM3_ESOFT;
 
     printEM4x05config(word);
-    
+
     // if 4469 read EM4469_PROT_BLOCK
     // if 4305 read 14,15
     if (card_type == EM_4205 || card_type == EM_4305) {
@@ -1059,7 +1059,7 @@ int CmdEM4x05Info(const char *Cmd) {
             }
         }
     } else if (card_type == EM_4X69) {
-          // read word 3 to see which is being used for the protection bits
+        // read word 3 to see which is being used for the protection bits
         if (EM4x05ReadWord_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS) {
             return PM3_ESOFT;
         }
@@ -1104,12 +1104,12 @@ int CmdEM4x05Chk(const char *Cmd) {
         snprintf(filename, sizeof(filename), "t55xx_default_pwds");
     }
     PrintAndLogEx(NORMAL, "");
-    
+
     bool found = false;
     uint64_t t1 = msclock();
-    
+
     // White cloner password based on EM4100 ID
-    if ( card_id > 0 ) {
+    if (card_id > 0) {
 
         uint32_t pwd = lf_t55xx_white_pwdgen(card_id & 0xFFFFFFFF);
         PrintAndLogEx(INFO, "testing %08"PRIX32" generated ", pwd);
@@ -1180,7 +1180,7 @@ int CmdEM4x05Chk(const char *Cmd) {
 
 typedef struct {
     uint16_t cnt;
-    uint32_t value;    
+    uint32_t value;
 } em4x05_unlock_item_t;
 
 static int unlock_write_protect(bool use_pwd, uint32_t pwd, uint32_t data, bool verbose) {
@@ -1214,7 +1214,7 @@ static int unlock_write_protect(bool use_pwd, uint32_t pwd, uint32_t data, bool
         PrintAndLogEx(ERR, "Tag denied PROTECT operation");
     else
         PrintAndLogEx(DEBUG, "No answer from tag");
-    
+
     return status;
 }
 static int unlock_reset(bool use_pwd, uint32_t pwd, uint32_t data, bool verbose) {
@@ -1224,14 +1224,14 @@ static int unlock_reset(bool use_pwd, uint32_t pwd, uint32_t data, bool verbose)
     return unlock_write_protect(use_pwd, pwd, data, false);
 }
 static void unlock_add_item(em4x05_unlock_item_t *array, uint8_t len, uint32_t value) {
-    
+
     uint8_t i = 0;
     for (; i < len; i++) {
-        if ( array[i].value == value ) {
+        if (array[i].value == value) {
             array[i].cnt++;
             break;
         }
-        if ( array[i].cnt == 0 ) {
+        if (array[i].cnt == 0) {
             array[i].cnt++;
             array[i].value = value;
             break;
@@ -1254,9 +1254,9 @@ int CmdEM4x05Unlock(const char *Cmd) {
         arg_int0("n", NULL, NULL, "steps to skip"),
         arg_int0("s", "start", "<us>", "start scan from delay (us)"),
         arg_int0("e", "end", "<us>", "end scan at delay (us)"),
-        arg_u64_0("p", "pwd", "", "password (0x00000000)"),        
+        arg_u64_0("p", "pwd", "", "password (0x00000000)"),
         arg_lit0("v", "verbose", "verbose output"),
-        arg_param_end        
+        arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     double n = (double)arg_get_int_def(ctx, 1, 0);
@@ -1266,7 +1266,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
     bool verbose = arg_get_lit(ctx, 5);
     CLIParserFree(ctx);
 
-    if ( start > end ) {
+    if (start > end) {
         PrintAndLogEx(FAILED, "start delay can\'t be larger than end delay %.0lf vs %.0lf", start, end);
         return PM3_EINVARG;
     }
@@ -1285,24 +1285,24 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
     uint32_t search_value = 0;
     uint32_t write_value = 0;
-    //    
-    // inital phase 
+    //
+    // inital phase
     //
     // read word 14
     uint32_t init_14 = 0;
     int res = EM4x05ReadWord_ext(14, pwd, use_pwd, &init_14);
     if (res != PM3_SUCCESS) {
         PrintAndLogEx(FAILED, "failed to read word 14\n");
-        return PM3_ENODATA;        
+        return PM3_ENODATA;
     }
 
-        
-    // read 15 
+
+    // read 15
     uint32_t init_15 = 0;
     res = EM4x05ReadWord_ext(15, pwd, use_pwd, &init_15);
     if (res != PM3_SUCCESS) {
         PrintAndLogEx(FAILED, "failed to read word 15\n");
-        return PM3_ENODATA;        
+        return PM3_ENODATA;
     }
 
 #define ACTIVE_MASK 0x00008000
@@ -1322,13 +1322,13 @@ int CmdEM4x05Unlock(const char *Cmd) {
         my_auto = true;
         n = (end - start) / 2;
     }
-    
+
     // fix at one specific delay
     if (start == end) {
         n = 0;
     }
-    
-    PrintAndLogEx(INFO, "--------------- " _CYAN_("EM4x05 tear-off : target PROTECT") " -----------------------\n");    
+
+    PrintAndLogEx(INFO, "--------------- " _CYAN_("EM4x05 tear-off : target PROTECT") " -----------------------\n");
 
     PrintAndLogEx(INFO, "initial prot 14&15 [ " _GREEN_("%08X") ", " _GREEN_("%08X")  " ]", init_14, init_15);
 
@@ -1341,15 +1341,15 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
     PrintAndLogEx(INFO, "   target stepping [ " _GREEN_("%.0lf") " ]", n);
     PrintAndLogEx(INFO, "target delay range [ " _GREEN_("%.0lf") " ... " _GREEN_("%.0lf") " ]", start, end);
-    PrintAndLogEx(INFO, "      search value [ " _GREEN_("%08X") " ]", search_value);        
-    PrintAndLogEx(INFO, "       write value [ " _GREEN_("%08X") " ]", write_value);        
+    PrintAndLogEx(INFO, "      search value [ " _GREEN_("%08X") " ]", search_value);
+    PrintAndLogEx(INFO, "       write value [ " _GREEN_("%08X") " ]", write_value);
 
     PrintAndLogEx(INFO, "----------------------------------------------------------------------------\n");
     PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(INFO, "press " _YELLOW_("'enter'") " to cancel the command");
-    PrintAndLogEx(NORMAL, "");    
+    PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(INFO, "--------------- " _CYAN_("start") " -----------------------\n");
-    
+
     int exit_code = PM3_SUCCESS;
     uint32_t word14 = 0, word15 = 0;
     uint32_t word14b = 0, word15b = 0;
@@ -1357,7 +1357,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
     uint32_t soon = 0;
     uint32_t late = 0;
 
-    em4x05_unlock_item_t flipped[64] ={{0,0}};
+    em4x05_unlock_item_t flipped[64] = {{0, 0}};
 
     //
     // main loop
@@ -1378,7 +1378,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
         }
 
         if (tries >= 5 && n == 0 && soon != late) {
-            
+
             if (soon > late) {
                 PrintAndLogEx(INFO, "Tried %d times, soon:%i late:%i        => " _CYAN_("adjust +1 us >> %.0lf us"), tries, soon, late, start);
                 start++;
@@ -1397,23 +1397,23 @@ int CmdEM4x05Unlock(const char *Cmd) {
             exit_code = PM3_EOPABORTED;
             break;
         }
-           
+
         // set tear off trigger
-        clearCommandBuffer();    
+        clearCommandBuffer();
         tearoff_params_t params = {
             .delay_us = start,
             .on = true,
             .off = false
         };
-        res = handle_tearoff(&params, verbose); 
-        if ( res != PM3_SUCCESS ) {
+        res = handle_tearoff(&params, verbose);
+        if (res != PM3_SUCCESS) {
             PrintAndLogEx(WARNING, "failed to configure tear off");
             return PM3_ESOFT;
         }
 
         // write
         res = unlock_write_protect(use_pwd, pwd, write_value, verbose);
-        
+
         // read after trigger
         res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14);
         if (res != PM3_SUCCESS) {
@@ -1430,10 +1430,10 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
         if (verbose)
             PrintAndLogEx(INFO, "ref:%08X   14:%08X   15:%08X ", search_value, word14, word15);
-        
-        if ( word14 == search_value && word15 == 0) {
+
+        if (word14 == search_value && word15 == 0) {
             PrintAndLogEx(INFO, "Status: Nothing happened            => " _GREEN_("tearing too soon"));
-            
+
             if (my_auto) {
                 start += n;
                 PrintAndLogEx(INFO, "                                    => " _CYAN_("adjust +%.0lf us >> %.0lf us"), n, start);
@@ -1442,17 +1442,17 @@ int CmdEM4x05Unlock(const char *Cmd) {
                 soon++;
             }
         } else {
-            
+
             if (word15 == search_value) {
-                
+
                 if (word14 == 0) {
                     PrintAndLogEx(INFO, "Status: Protect succeeded           => " _GREEN_("tearing too late"));
                 } else {
-                    if ( word14 == search_value) {
+                    if (word14 == search_value) {
                         PrintAndLogEx(INFO, "Status: 15 ok, 14 not yet erased    => " _GREEN_("tearing too late"));
                     } else {
                         PrintAndLogEx(INFO, "Status: 15 ok, 14 partially erased  => " _GREEN_("tearing too late"));
-                    }                    
+                    }
                 }
 
                 unlock_reset(use_pwd, pwd, write_value, verbose);
@@ -1466,7 +1466,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
                 if (word14b == 0) {
 
-                    unlock_reset(use_pwd, pwd, write_value, verbose);                    
+                    unlock_reset(use_pwd, pwd, write_value, verbose);
 
                     res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14b);
                     if (res != PM3_SUCCESS) {
@@ -1474,7 +1474,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
                         return PM3_ESOFT;
                     }
                 }
-                
+
                 if (word14b != search_value) {
 
                     res = EM4x05ReadWord_ext(15, pwd, use_pwd, &word15b);
@@ -1484,7 +1484,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
                         break;
                     } else {
                         PrintAndLogEx(WARNING, "failed to read 15");
-                        return PM3_ESOFT;                        
+                        return PM3_ESOFT;
                     }
                 }
                 if (my_auto) {
@@ -1497,32 +1497,32 @@ int CmdEM4x05Unlock(const char *Cmd) {
                 }
 
             } else {
-                
-                if (( word15 & ACTIVE_MASK) == ACTIVE_MASK) {
-                    
+
+                if ((word15 & ACTIVE_MASK) == ACTIVE_MASK) {
+
                     PrintAndLogEx(INFO, "Status: 15 bitflipped and active    => " _RED_("SUCCESS?:  ") "14: %08X  15: " _CYAN_("%08X"), word14, word15);
                     PrintAndLogEx(INFO, "Committing results...");
 
-                    unlock_reset(use_pwd, pwd, write_value, verbose);    
-                    
+                    unlock_reset(use_pwd, pwd, write_value, verbose);
+
                     // read after reset
                     res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14b);
-                    if ( res != PM3_SUCCESS ) {
+                    if (res != PM3_SUCCESS) {
                         PrintAndLogEx(WARNING, "failed to read 14");
                         return PM3_ESOFT;
                     }
 
                     res = EM4x05ReadWord_ext(15, pwd, use_pwd, &word15b);
-                    if ( res != PM3_SUCCESS ) {
+                    if (res != PM3_SUCCESS) {
                         PrintAndLogEx(WARNING, "failed to read 15");
                         return PM3_ESOFT;
                     }
-                    
+
                     if (verbose)
                         PrintAndLogEx(INFO, "ref:%08x   14:%08X   15:%08X", search_value, word14b, word15b);
-                    
+
                     if ((word14b & ACTIVE_MASK) == ACTIVE_MASK) {
-                        
+
                         if (word14b == word15) {
                             PrintAndLogEx(INFO, "Status: confirmed                   => " _RED_("SUCCESS:   ") "14: " _CYAN_("%08X") "  15: %08X", word14b, word15b);
 
@@ -1530,15 +1530,15 @@ int CmdEM4x05Unlock(const char *Cmd) {
                             success = true;
                             break;
                         }
-                        
+
                         if (word14b != search_value) {
                             PrintAndLogEx(INFO, "Status: new definitive value!       => " _RED_("SUCCESS:   ") "14: " _CYAN_("%08X") "  15: %08X", word14b, word15b);
-                            
+
                             unlock_add_item(flipped, 64, word14b);
                             success = true;
                             break;
                         }
-                        
+
                         PrintAndLogEx(INFO, "Status: failed to commit bitflip        => " _RED_("FAIL:      ") "14: %08X  15: %08X", word14b, word15b);
                     }
                     if (my_auto) {
@@ -1551,14 +1551,14 @@ int CmdEM4x05Unlock(const char *Cmd) {
                     }
                 } else {
                     PrintAndLogEx(INFO, "Status: 15 bitflipped but inactive      => " _YELLOW_("PROMISING: ") "14: %08X  15: " _CYAN_("%08X"), word14, word15);
-                    
+
                     unlock_add_item(flipped, 64, word15);
-                    
+
                     soon ++;
                 }
             }
         }
-        
+
         if (my_auto == false) {
             tries++;
         }
@@ -1571,15 +1571,15 @@ int CmdEM4x05Unlock(const char *Cmd) {
         uint32_t bitflips = search_value ^ word14b;
         PrintAndLogEx(INFO, "Old protection word => " _YELLOW_("%08X"), search_value);
         char bitstring[9] = {0};
-        for (int i=0; i < 8; i++) {
-            bitstring[i] = bitflips & (0xF << ((7-i) * 4)) ? 'x' : '.';
+        for (int i = 0; i < 8; i++) {
+            bitstring[i] = bitflips & (0xF << ((7 - i) * 4)) ? 'x' : '.';
         }
         // compute number of bits flipped
 
         PrintAndLogEx(INFO, "Bitflips: %2u events => %s", bitcount32(bitflips), bitstring);
         PrintAndLogEx(INFO, "New protection word => " _CYAN_("%08X") "\n", word14b);
 
-   
+
         PrintAndLogEx(INFO, "Try " _YELLOW_("`lf em 4x05_dump`"));
     }
 
@@ -1590,7 +1590,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
         for (uint8_t i = 0; i < 64; i++) {
             if (flipped[i].cnt == 0)
                 break;
-            
+
             PrintAndLogEx(INFO, " %3u | %08X | %3u | %u", i, flipped[i].value, flipped[i].cnt, bitcount32(search_value ^ flipped[i].value));
         }
     }
diff --git a/client/src/cmdlfem4x50.c b/client/src/cmdlfem4x50.c
index 7296ccbb1..89da1efc1 100644
--- a/client/src/cmdlfem4x50.c
+++ b/client/src/cmdlfem4x50.c
@@ -493,7 +493,7 @@ int CmdEM4x50WritePassword(const char *Cmd) {
 
     if (resp.status == PM3_ETEAROFF)
         return PM3_SUCCESS;
-    
+
     success = (bool)resp.status;
 
     // get, prepare and print response
diff --git a/client/src/cmdlffdxb.c b/client/src/cmdlffdxb.c
index 1547c743b..efd567128 100644
--- a/client/src/cmdlffdxb.c
+++ b/client/src/cmdlffdxb.c
@@ -470,7 +470,7 @@ const fdxbCountryMapping_t fdxbCountryMapping[] = {
     { 0,   "N/A" } // must be the last entry
 };
 
-static const char* mapFDBX(uint16_t countryCode) {
+static const char *mapFDBX(uint16_t countryCode) {
     uint16_t i = 0;
     while (fdxbCountryMapping[i].code > 0) {
         if (countryCode == fdxbCountryMapping[i].code) {
@@ -572,8 +572,8 @@ int demodFDXB(bool verbose) {
     PrintAndLogEx(SUCCESS, "  Animal bit set?  %s", animalBit ? _YELLOW_("True") : "False");
     PrintAndLogEx(SUCCESS, "      Data block?  %s  [value 0x%X]", dataBlockBit ? _YELLOW_("True") : "False", extended);
     PrintAndLogEx(SUCCESS, "        RUDI bit?  %s", rudiBit ? _YELLOW_("True") " (advanced transponder)" : "False");
-    PrintAndLogEx(SUCCESS, "       User Info?  %u %s", userInfo, userInfo == 0 ? "(RFU)":"");
-    PrintAndLogEx(SUCCESS, "  Replacement No?  %u %s", replacementNr, replacementNr == 0 ? "(RFU)":"");
+    PrintAndLogEx(SUCCESS, "       User Info?  %u %s", userInfo, userInfo == 0 ? "(RFU)" : "");
+    PrintAndLogEx(SUCCESS, "  Replacement No?  %u %s", replacementNr, replacementNr == 0 ? "(RFU)" : "");
 
     uint8_t c[] = {0, 0};
     compute_crc(CRC_11784, raw, sizeof(raw), &c[0], &c[1]);
diff --git a/client/src/cmdlfindala.c b/client/src/cmdlfindala.c
index 9ed08d557..a5c81114a 100644
--- a/client/src/cmdlfindala.c
+++ b/client/src/cmdlfindala.c
@@ -601,7 +601,7 @@ static int CmdIndalaClone(const char *Cmd) {
     CLIGetHexWithReturn(ctx, 3, data, &datalen);
 
     bool is_t5555 = arg_get_lit(ctx, 4);
-    
+
     bool got_cn = false, got_26 = false;
     if (is_long_uid == false) {
 
@@ -616,7 +616,7 @@ static int CmdIndalaClone(const char *Cmd) {
     }
 
     CLIParserFree(ctx);
-    
+
     PrintAndLogEx(INFO, "Target chip " _YELLOW_("%s"), (is_t5555) ? "Q5/T5555" : "T55x7");
 
     if (is_long_uid) {
diff --git a/client/src/cmdlfmotorola.c b/client/src/cmdlfmotorola.c
index c7cd16021..28b6bd39b 100644
--- a/client/src/cmdlfmotorola.c
+++ b/client/src/cmdlfmotorola.c
@@ -173,18 +173,18 @@ static int CmdMotorolaClone(const char *Cmd) {
     CLIParserFree(ctx);
 
     //TODO add selection of chip for Q5 or T55x7
-    
+
     PrintAndLogEx(INFO, "Target chip " _YELLOW_("%s"), (is_t5555) ? "Q5/T5555" : "T55x7");
 
     // config for Motorola 64 format (RF/32;PSK1 with RF/2; Maxblock=2)
     PrintAndLogEx(INFO, "Preparing to clone Motorola 64bit tag");
     PrintAndLogEx(INFO, "Using raw " _GREEN_("%s"), sprint_hex_inrow(data, datalen));
 
-    if (is_t5555) 
+    if (is_t5555)
         blocks[0] = T5555_FIXED | T5555_SET_BITRATE(32) | T5555_MODULATION_PSK1 | 2 << T5555_MAXBLOCK_SHIFT;
-    else 
+    else
         blocks[0] =  T55x7_BITRATE_RF_32 | T55x7_MODULATION_PSK1 | (2 << T55x7_MAXBLOCK_SHIFT);
-    
+
 
     blocks[1] = bytes_to_num(data, 4);
     blocks[2] = bytes_to_num(data + 4, 4);
diff --git a/client/src/scripting.c b/client/src/scripting.c
index 8d990fe1b..4c9e3686f 100644
--- a/client/src/scripting.c
+++ b/client/src/scripting.c
@@ -1106,7 +1106,7 @@ static int l_em4x05_read(lua_State *L) {
 
     // get password
     const char *p_pwd = luaL_checkstring(L, 2);
-    if (p_pwd == NULL || strlen(p_pwd) == 0 ) {
+    if (p_pwd == NULL || strlen(p_pwd) == 0) {
         use_pwd = false;
     } else {
         if (strlen(p_pwd) != 8)
@@ -1138,7 +1138,7 @@ static int l_em4x50_read(lua_State *L) {
     const char *p_addr = luaL_checklstring(L, 1, &size);
     uint32_t addr = 0;
     sscanf(p_addr, "%u", &addr);
-    
+
     if (addr > 31)
         return returnToLuaWithError(L, "Address out-of-range (0..31) got %u", addr);
 
@@ -1159,9 +1159,9 @@ static int l_em4x50_read(lua_State *L) {
 
         uint32_t pwd = 0;
         sscanf(p_pwd, "%08x", &pwd);
-        
+
         PrintAndLogEx(DEBUG, " Pwd %08X", pwd);
-        
+
         etd.password[0] = pwd & 0xFF;
         etd.password[1] = (pwd >> 8) & 0xFF;
         etd.password[2] = (pwd >> 16) & 0xFF;
@@ -1181,11 +1181,11 @@ static int l_em4x50_read(lua_State *L) {
     }
 
     uint32_t word = (
-            words[etd.address].byte[0] << 24 |
-            words[etd.address].byte[1] << 16 |
-            words[etd.address].byte[2] << 8 |
-            words[etd.address].byte[3] 
-        );
+                        words[etd.address].byte[0] << 24 |
+                        words[etd.address].byte[1] << 16 |
+                        words[etd.address].byte[2] << 8 |
+                        words[etd.address].byte[3]
+                    );
     lua_pushinteger(L, word);
     return 1;
 }
diff --git a/doc/commands.md b/doc/commands.md
index 333c332ec..e2ca72107 100644
--- a/doc/commands.md
+++ b/doc/commands.md
@@ -177,13 +177,13 @@ Check column "offline" for their availability.
 |`hf 15 info             `|N       |`Tag information`
 |`hf 15 sniff            `|N       |`Sniff ISO15693 traffic`
 |`hf 15 raw              `|N       |`Send raw hex data to tag`
-|`hf 15 read             `|N       |`Read a block`
+|`hf 15 rdbl             `|N       |`Read a block`
 |`hf 15 reader           `|N       |`Act like an ISO15693 reader`
 |`hf 15 readmulti        `|N       |`Reads multiple Blocks`
 |`hf 15 restore          `|N       |`Restore from file to all memory pages of an ISO15693 tag`
 |`hf 15 samples          `|N       |`Acquire Samples as Reader (enables carrier, sends inquiry)`
 |`hf 15 sim              `|N       |`Fake an ISO15693 tag`
-|`hf 15 write            `|N       |`Write a block`
+|`hf 15 wrbl             `|N       |`Write a block`
 |`hf 15 findafi          `|N       |`Brute force AFI of an ISO15693 tag`
 |`hf 15 writeafi         `|N       |`Writes the AFI on an ISO15693 tag`
 |`hf 15 writedsfid       `|N       |`Writes the DSFID on an ISO15693 tag`
@@ -233,7 +233,7 @@ Check column "offline" for their availability.
 |command                  |offline |description
 |-------                  |------- |-----------
 |`hf fido help           `|Y       |`This help.`
-|`hf fido info           `|N       |`List ISO 14443A history`
+|`hf fido list           `|N       |`List ISO 14443A history`
 |`hf fido info           `|N       |`Info about FIDO tag.`
 |`hf fido reg            `|N       |`FIDO U2F Registration Message.`
 |`hf fido auth           `|N       |`FIDO U2F Authentication Message.`
@@ -256,10 +256,10 @@ Check column "offline" for their availability.
 |`hf iclass restore      `|N       |`[options..] Restore a dump file onto a Picopass / iCLASS tag`
 |`hf iclass sniff        `|N       |`            Eavesdrop Picopass / iCLASS communication`
 |`hf iclass wrbl         `|N       |`[options..] Write Picopass / iCLASS block`
-|`hf iclass chk          `|Y       |`[options..] Check keys`
+|`hf iclass autopwn      `|N       |`[options..] Automatic key recovery tool for iCLASS`
+|`hf iclass chk          `|N       |`[options..] Check keys`
 |`hf iclass loclass      `|Y       |`[options..] Use loclass to perform bruteforce reader attack`
 |`hf iclass lookup       `|Y       |`[options..] Uses authentication trace to check for key in dictionary file`
-|`hf iclass replay       `|N       |`<mac>       Read Picopass / iCLASS tag via replay attack`
 |`hf iclass sim          `|N       |`[options..] Simulate iCLASS tag`
 |`hf iclass eload        `|N       |`[f <fn>   ] Load Picopass / iCLASS dump file into emulator memory`
 |`hf iclass esave        `|N       |`[f <fn>   ] Save emulator memory to file`
@@ -556,6 +556,19 @@ Check column "offline" for their availability.
 |`lf cotag read          `|N       |`Attempt to read and extract tag data`
 
 
+### lf destron
+
+ { FDX-A Destron RFIDs...     }
+
+|command                  |offline |description
+|-------                  |------- |-----------
+|`lf destron help        `|Y       |`This help`
+|`lf destron demod       `|Y       |`Demodulate an Destron tag from the GraphBuffer`
+|`lf destron read        `|N       |`Attempt to read and extract tag data from the antenna`
+|`lf destron clone       `|N       |`Clone Destron tag to T55x7`
+|`lf destron sim         `|N       |`Simulate Destron tag`
+
+
 ### lf em
 
  { EM4X CHIPs & RFIDs...      }
@@ -570,12 +583,14 @@ Check column "offline" for their availability.
 |`lf em 410x_watch       `|N       |`watches for EM410x 125/134 kHz tags (option 'h' for 134)`
 |`lf em 410x_spoof       `|N       |`watches for EM410x 125/134 kHz tags, and replays them. (option 'h' for 134)`
 |`lf em 410x_clone       `|N       |`write EM410x UID to T55x7 or Q5/T5555 tag`
+|`lf em 4x05_chk         `|N       |`Check passwords from dictionary`
 |`lf em 4x05_demod       `|Y       |`demodulate a EM4x05/EM4x69 tag from the GraphBuffer`
 |`lf em 4x05_dump        `|N       |`dump EM4x05/EM4x69 tag`
 |`lf em 4x05_wipe        `|N       |`wipe EM4x05/EM4x69 tag`
 |`lf em 4x05_info        `|N       |`tag information EM4x05/EM4x69`
 |`lf em 4x05_read        `|N       |`read word data from EM4x05/EM4x69`
 |`lf em 4x05_write       `|N       |`write word data to EM4x05/EM4x69`
+|`lf em 4x05_unlock      `|N       |`execute tear off against EM4x05/EM4x69`
 |`lf em 4x50_dump        `|N       |`dump EM4x50 tag`
 |`lf em 4x50_info        `|N       |`tag information EM4x50`
 |`lf em 4x50_write       `|N       |`write word data to EM4x50`
diff --git a/include/pm3_cmd.h b/include/pm3_cmd.h
index 7fb978d75..be2227b7c 100644
--- a/include/pm3_cmd.h
+++ b/include/pm3_cmd.h
@@ -342,7 +342,7 @@ typedef struct {
 typedef struct {
     iclass_auth_req_t req;
     uint8_t item_cnt;
-    iclass_restore_item_t blocks[];    
+    iclass_restore_item_t blocks[];
 } PACKED iclass_restore_req_t;
 
 

From 378f5faeb74b4c8de5995013d554bd8674c12aa5 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 01:06:07 +0200
Subject: [PATCH 09/35] fix style

---
 client/src/cmdhficlass.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/client/src/cmdhficlass.c b/client/src/cmdhficlass.c
index 782e782eb..75c77559c 100644
--- a/client/src/cmdhficlass.c
+++ b/client/src/cmdhficlass.c
@@ -2052,14 +2052,14 @@ static int CmdHFiClassRestore(const char *Cmd) {
     }
 
     iclass_restore_req_t *payload = calloc(1, payload_size);
-    payload->req.use_raw = rawkey,
-             payload->req.use_elite = elite,
-                      payload->req.use_credit_key = use_credit_key,
-                               payload->req.use_replay = false,
-                                        payload->req.blockno = startblock,
-                                                 payload->req.send_reply = true,
-                                                          payload->req.do_auth = true,
-                                                                   memcpy(payload->req.key, KEY, 8);
+    payload->req.use_raw = rawkey;
+    payload->req.use_elite = elite;
+    payload->req.use_credit_key = use_credit_key;
+    payload->req.use_replay = false;
+    payload->req.blockno = startblock;
+    payload->req.send_reply = true;
+    payload->req.do_auth = true;
+    memcpy(payload->req.key, KEY, 8);
 
     payload->item_cnt = (endblock - startblock + 1);
 

From 3979363b695bda9d924622e5f6385ca167b81c9d Mon Sep 17 00:00:00 2001
From: mwalker33 <51802811+mwalker33@users.noreply.github.com>
Date: Tue, 20 Oct 2020 17:52:32 +1100
Subject: [PATCH 10/35] em4x05 sniff

V1 for testing
---
 client/src/cmdlfem4x.c   |   1 +
 client/src/cmdlfem4x05.c | 224 +++++++++++++++++++++++++++++++++++++++
 client/src/cmdlfem4x05.h |   1 +
 3 files changed, 226 insertions(+)

diff --git a/client/src/cmdlfem4x.c b/client/src/cmdlfem4x.c
index f20610a2e..1625aa2ec 100644
--- a/client/src/cmdlfem4x.c
+++ b/client/src/cmdlfem4x.c
@@ -646,6 +646,7 @@ static command_t CommandTable[] = {
     {"4x05_read",   CmdEM4x05Read,        IfPm3Lf,         "read word data from EM4x05/EM4x69"},
     {"4x05_write",  CmdEM4x05Write,       IfPm3Lf,         "write word data to EM4x05/EM4x69"},
     {"4x05_unlock", CmdEM4x05Unlock,      IfPm3Lf,         "execute tear off against EM4x05/EM4x69"},
+    {"4x05_sniff",  CmdEM4x05Sniff,       IfPm3Lf,         "Attempt to recover em4x05 commands from sample buffer"},
     {"----------",  CmdHelp,              AlwaysAvailable,         "----------------------- " _CYAN_("EM 4x50") " -----------------------"},
     {"4x50_dump",   CmdEM4x50Dump,        IfPm3EM4x50,     "dump EM4x50 tag"},
     {"4x50_info",   CmdEM4x50Info,        IfPm3EM4x50,     "tag information EM4x50"},
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 4992ab1c8..36341e1a6 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1597,3 +1597,227 @@ int CmdEM4x05Unlock(const char *Cmd) {
     PrintAndLogEx(NORMAL, "");
     return exit_code;
 }
+
+static size_t em4x05_Sniff_GetNextBitStart (size_t idx, size_t sc, int *data, size_t *pulsesamples)
+{
+    while ((idx < sc) && (data[idx] <= 10)) // find a going high
+        idx++;
+
+    while ((idx < sc) && (data[idx] > -10)) // find going low  may need to add something here it SHOULD be a small clk around 0, but white seems to extend a bit.
+        idx++;
+
+    (*pulsesamples) = 0;
+    while ((idx < sc) && ((data[idx+1] - data[idx]) < 10 )) {  // find "sharp rise"
+        (*pulsesamples)++;
+        idx++;
+    }
+
+    return idx;
+}
+
+uint32_t static em4x05_Sniff_GetBlock (char *bits, bool fwd) {
+    uint32_t value = 0;
+    uint8_t idx;
+
+    for (idx = 0; idx < 8; idx++) {
+        value <<= 1;
+        value += (bits[idx] - '0');
+    }
+    for (idx = 9; idx < 17; idx++) {
+        value <<= 1;
+        value += (bits[idx] - '0');
+    }
+    for (idx = 18; idx < 26; idx++) {
+        value <<= 1;
+        value += (bits[idx] - '0');
+    }
+    for (idx = 27; idx < 35; idx++) {
+        value <<= 1;
+        value += (bits[idx] - '0');
+    }
+    
+    if (!fwd) {
+        uint32_t t1 = value;
+        value = 0;
+        for (idx = 0; idx < 32; idx++)
+            value |= (((t1 >> idx) & 1) << (31 - idx));
+    }
+    return value;
+}
+
+int CmdEM4x05Sniff(const char *Cmd) {
+
+    bool sampleData = true;
+    bool haveData = false;
+    size_t idx = 0;
+    char cmdText [100];
+    char dataText [100];
+    char blkAddr[4];
+    char bits[80];
+    int bitidx;
+    int ZeroWidth;    // 32-42 "1" is 32
+    int CycleWidth;
+    size_t pulseSamples;
+    size_t pktOffset;
+    int i;
+    bool eop = false;
+    uint32_t tmpValue;
+    bool pwd = false;
+    bool fwd = false;
+
+    CLIParserContext *ctx;
+    CLIParserInit(&ctx, "lf em 4x05_sniff",
+                  "Sniff EM4x05 commands sent from a programmer",
+                  "lf em 4x05_sniff -> sniff via lf sniff\n"
+                  "lf em 4x05_sniff -1 -> sniff from data loaded into the buffer\n"
+                  "lf em 4x05_sniff -r -> reverse the bit order when showing block data"
+                 );
+
+    void *argtable[] = {
+        arg_param_begin,
+        arg_lit0("1", "buf","Use the data in the buffer"),
+        arg_lit0("r", "rev", "Reverse the bit order for data blocks"),
+        arg_param_end
+    };
+    CLIExecWithReturn(ctx, Cmd, argtable, true);
+
+    sampleData = !arg_get_lit(ctx,1);
+    fwd = arg_get_lit(ctx,2);
+
+    // setup and sample data from Proxmark
+    // if not directed to existing sample/graphbuffer
+    if (sampleData) {
+        CmdLFSniff("");
+    }
+
+    // Headings
+    PrintAndLogEx(NORMAL, "");
+    PrintAndLogEx(INFO, _CYAN_("EM4x05 command detection"));
+    PrintAndLogEx(SUCCESS, "offset | Command     |   Data   | blk | raw");
+    PrintAndLogEx(SUCCESS, "-------+-------------+----------+-----+------------------------------------------------------------");
+
+    idx = 0;
+    // loop though sample buffer
+    while (idx < GraphTraceLen) {
+        eop = false;
+        haveData = false;
+        pwd = false;
+
+        idx = em4x05_Sniff_GetNextBitStart (idx, GraphTraceLen, GraphBuffer, &pulseSamples);
+        pktOffset = idx;
+        if (pulseSamples >= 10)  { // Should be 18 so a bit less to allow for processing
+        
+            // Use first bit to get "0" bit samples as a reference
+            ZeroWidth = idx;
+            idx = em4x05_Sniff_GetNextBitStart (idx, GraphTraceLen, GraphBuffer, &pulseSamples);
+            ZeroWidth = idx - ZeroWidth;
+
+       //     printf ("Zero width after 2 0 bits : %llu 0 Zero width %d\n",idx,ZeroWidth);
+
+            if (ZeroWidth <= 50) {
+                    pktOffset -= ZeroWidth;
+              //  ZeroSamples = 0;
+                memset(bits,0x00,sizeof(bits));
+                bitidx = 0;
+
+                while ((idx < GraphTraceLen) && !eop) {
+                    CycleWidth = idx;
+                    idx = em4x05_Sniff_GetNextBitStart (idx, GraphTraceLen, GraphBuffer, &pulseSamples);
+
+                    CycleWidth = idx - CycleWidth;
+                    if ((CycleWidth > 300) || (CycleWidth < (ZeroWidth-5))) { // to long or too short
+                        eop = true;
+                        bits[bitidx++] = '0';   // Append last zero from the last bit find
+                        cmdText[0] = 0;
+                        // Memo6->Lines->Add("Bit widths... : "+T1);
+                        // EM4305 command lengths
+                        // Login        0011 <pwd>          => 4 +     45 => 49
+                        // Write Word   0101 <adr> <data>   => 4 + 7 + 45 => 56
+                        // Read Word    1001 <adr>          => 4 + 7      => 11
+                        // Protect      1100       <data>   => 4 +     45 => 49
+                        // Disable      1010       <data>   => 4 +     45 => 49
+                        // -> disaable 1010 11111111 0 11111111 0 11111111 0 11111111 0 00000000 0
+
+                        // logon
+                        if ((strncmp (bits,"0011",4) == 0) && (bitidx == 49)) {
+                            haveData = true;
+                            pwd = true;
+                            sprintf (cmdText,"Logon");
+                            sprintf (blkAddr,"   ");
+                            tmpValue = em4x05_Sniff_GetBlock (&bits[4], fwd);
+                            sprintf (dataText,"%08X",tmpValue);
+                        }
+
+                        // write
+                        if ((strncmp (bits,"0101",4) == 0) && (bitidx == 56)) {
+                            haveData = true;
+                            sprintf (cmdText,"Write");
+                            tmpValue = 0;
+                            tmpValue = (bits[4] - '0') + ((bits[5] - '0') << 1) + ((bits[6] - '0') << 2)  + ((bits[7] - '0') << 3);
+                            sprintf (blkAddr,"%d",tmpValue);
+                            if (tmpValue == 2)
+                                pwd = true;
+                            tmpValue = em4x05_Sniff_GetBlock (&bits[11], fwd);
+                            sprintf (dataText,"%08X",tmpValue);
+                        }
+
+                        // write 2 test
+                        if ((strncmp (bits,"00101",5) == 0) && (bitidx == 57)) {
+                            haveData = true;
+                            sprintf (cmdText,"Write");
+                            tmpValue = 0;
+                            tmpValue = (bits[5] - '0') + ((bits[6] - '0') << 1) + ((bits[7] - '0') << 2)  + ((bits[8] - '0') << 3);
+                            sprintf (blkAddr,"%d",tmpValue);
+                            if (tmpValue == 2)
+                                pwd = true;
+                            tmpValue = em4x05_Sniff_GetBlock (&bits[12], fwd);
+                            sprintf (dataText,"%08X",tmpValue);
+                        }
+/*
+                        if ((Bits.SubString(1,4) == "1001") && (Bits.Length() == 11)) {
+                            Addr = Bits.SubString(5,7);
+                            Data = "";
+                            Memo6->Lines->Add("Read  :     "+Addr+" "+Data);
+                        }
+
+                        if ((Bits.SubString(1,4) == "1100") && (Bits.Length() == 49)) {
+                            Addr = "";
+                            Data = Bits.SubString(5,45);
+                            Memo6->Lines->Add("Protect :     "+Addr+" "+Data);
+                        }
+
+                        if ((Bits.SubString(1,4) == "1010") && (Bits.Length() == 49)) {
+                            Addr = "";
+                            Data = Bits.SubString(5,45);
+                            Memo6->Lines->Add("Disable :     "+Addr+" "+Data);
+                        }
+*/
+                        // Memo6->Lines->Add("Raw : "+Bits);
+                        bits[bitidx] = 0;
+                     //   printf ("%s\n",bits);
+                    } else {
+                        i = (CycleWidth - ZeroWidth) / 30;
+                        bits[bitidx++] = '0';
+                        for (int ii = 0; ii < i; ii++)
+                            bits[bitidx++] = '1';
+                    }
+                }
+            }
+        }
+        idx++;
+
+        // Print results
+        if (haveData) { //&& (minWidth > 1) && (maxWidth > minWidth)){
+            if (pwd)
+                PrintAndLogEx(SUCCESS, "%6llu | %-10s  | "_YELLOW_("%8s")" | "_YELLOW_("%3s")" | %s", pktOffset, cmdText, dataText, blkAddr, bits);
+            else
+                PrintAndLogEx(SUCCESS, "%6llu | %-10s  | "_GREEN_("%8s")" | "_GREEN_("%3s")" | %s", pktOffset, cmdText, dataText, blkAddr, bits);
+        }
+    }
+
+    // footer
+    PrintAndLogEx(SUCCESS, "---------------------------------------------------------------------------------------------------");
+    PrintAndLogEx(NORMAL, "");
+
+    return PM3_SUCCESS;
+}
diff --git a/client/src/cmdlfem4x05.h b/client/src/cmdlfem4x05.h
index 0c41f431f..276afebc2 100644
--- a/client/src/cmdlfem4x05.h
+++ b/client/src/cmdlfem4x05.h
@@ -27,5 +27,6 @@ int CmdEM4x05Wipe(const char *Cmd);
 int CmdEM4x05Info(const char *Cmd);
 int CmdEM4x05Chk(const char *Cmd);
 int CmdEM4x05Unlock(const char *Cmd);
+int CmdEM4x05Sniff(const char *Cmd);
 
 #endif

From 874c673604446bc5e27d354826a7deaef2b12654 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 13:16:10 +0200
Subject: [PATCH 11/35] vscode

---
 .vscode/launch.json |  2 +-
 .vscode/tasks.json  | 21 +++++++++------------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index f115c5c7e..d3d86ee80 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -37,7 +37,7 @@
                     "ignoreFailures": true
                 }
             ],
-            "preLaunchTask": "Debug: clean & make client",
+            "preLaunchTask": "client: Debug: clean & make",
             "miDebuggerPath": "/usr/bin/gdb"
         }
     ],
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
index 352f22a42..155aa80cd 100644
--- a/.vscode/tasks.json
+++ b/.vscode/tasks.json
@@ -4,7 +4,7 @@
     "version": "2.0.0",
     "tasks": [
         {
-            "label": "Make all & run",
+            "label": "all: Make & run",
             "type": "shell",
             "command": "make -j && ./pm3",
             "problemMatcher": [
@@ -16,7 +16,7 @@
             }
         },
         {
-            "label": "Make TARGET",
+            "label": "choose: Make",
             "type": "shell",
             "command": "make ${input:componentType} -j",
             "problemMatcher": [
@@ -25,7 +25,7 @@
             "group": "build",
         },
         {
-            "label": "Debug: make client",
+            "label": "client: Debug: make",
             "type": "shell",
             "command": "make client -j DEBUG=1",
             "problemMatcher": [
@@ -34,7 +34,7 @@
             "group": "build",
         },
         {
-            "label": "Debug: clean & make client",
+            "label": "client: Debug: clean & make",
             "type": "shell",
             "command": "make client/clean && make client -j DEBUG=1",
             "problemMatcher": [
@@ -43,25 +43,22 @@
             "group": "build",
         },
         {
-            "label": "Flash fullimage",
+            "label": "fullimage: Make & Flash",
             "type": "shell",
-            "command": "./pm3-flash-fullimage",
+            "command": "make fullimage && ./pm3-flash-fullimage",
             "problemMatcher": []
         },
         {
-            "label": "FLASH BOOTROM",
+            "label": "BOOTROM: Make & Flash",
             "type": "shell",
-            "command": "./pm3-flash-bootrom",
+            "command": "make bootrom && ./pm3-flash-bootrom",
             "problemMatcher": []
         },
         {
             "label": "Run client",
             "type": "shell",
             "command": "./pm3",
-            "problemMatcher": [],
-            "dependsOn": [
-                "Release: build client"
-            ]
+            "problemMatcher": []
         }
     ],
     "inputs": [

From 9003b9631296f599941494495e14f39bfe3e6904 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 13:17:58 +0200
Subject: [PATCH 12/35] EM: typos

---
 client/src/cmdlfem4x05.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index a680d286f..deb47208f 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -423,14 +423,14 @@ int CmdEM4x05Dump(const char *Cmd) {
     CLIParserInit(&ctx, "lf em dump",
                   "Dump EM4x05/EM4x69.  Tag must be on antenna.",
                   "lf em dump\n"
-                  "lf em dump -p 11223344\n"
-                  "lf em dump -f myfile -p 11223344"
+                  "lf em dump -p 0x11223344\n"
+                  "lf em dump -f myfile -p 0x11223344"
                  );
 
     void *argtable[] = {
         arg_param_begin,
         arg_u64_0("p", "pwd", "<hex>", "password (0x00000000)"),
-        arg_str0("f", "file", "<filename>", "overide filename prefix (optional).  Default is based on UID"),
+        arg_str0("f", "file", "<filename>", "override filename prefix (optional).  Default is based on UID"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);

From 3b83e8e703f2d9c3bd39247462f754091ee093bd Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 13:18:43 +0200
Subject: [PATCH 13/35] EM 4x05 login bf

---
 armsrc/appmain.c         |  9 ++++++
 armsrc/lfops.c           | 63 +++++++++++++++++++++++++++++++++++-----
 armsrc/lfops.h           |  1 +
 client/src/cmdlfem4x.c   |  1 +
 client/src/cmdlfem4x05.c | 42 +++++++++++++++++++++++++++
 client/src/cmdlfem4x05.h |  1 +
 include/pm3_cmd.h        |  1 +
 7 files changed, 110 insertions(+), 8 deletions(-)

diff --git a/armsrc/appmain.c b/armsrc/appmain.c
index 6b127c831..aa0f23d8f 100644
--- a/armsrc/appmain.c
+++ b/armsrc/appmain.c
@@ -978,6 +978,15 @@ static void PacketReceived(PacketCommandNG *packet) {
             EM4xLogin(payload->password);
             break;
         }
+        case CMD_LF_EM4X_BF: {
+            struct p {
+                uint32_t start_pwd;
+                uint32_t n;
+            } PACKED;
+            struct p *payload = (struct p *) packet->data.asBytes;
+            EM4xBruteforce(payload->start_pwd, payload->n);
+            break;
+        }
         case CMD_LF_EM4X_READWORD: {
             struct p {
                 uint32_t password;
diff --git a/armsrc/lfops.c b/armsrc/lfops.c
index 4d25bd314..3d7154eb3 100644
--- a/armsrc/lfops.c
+++ b/armsrc/lfops.c
@@ -2467,7 +2467,7 @@ static uint8_t Prepare_Data(uint16_t data_low, uint16_t data_hi) {
 // Requires: forwarLink_data filled with valid bits (1 bit per byte)
 // fwd_bit_count set with number of bits to be sent
 //====================================================================
-static void SendForward(uint8_t fwd_bit_count) {
+static void SendForward(uint8_t fwd_bit_count, bool fast) {
 
 // iceman,   21.3us increments for the USclock verification.
 // 55FC * 8us == 440us / 21.3 === 20.65 steps.  could be too short. Go for 56FC instead
@@ -2480,9 +2480,10 @@ static void SendForward(uint8_t fwd_bit_count) {
     fwd_write_ptr = forwardLink_data;
     fwd_bit_sz = fwd_bit_count;
 
-    // Set up FPGA, 125kHz or 95 divisor
-    LFSetupFPGAForADC(LF_DIVISOR_125, true);
-
+    if (! fast) {
+        // Set up FPGA, 125kHz or 95 divisor
+        LFSetupFPGAForADC(LF_DIVISOR_125, true);
+    }
     // force 1st mod pulse (start gap must be longer for 4305)
     fwd_bit_sz--; //prepare next bit modulation
     fwd_write_ptr++;
@@ -2505,13 +2506,59 @@ static void EM4xLoginEx(uint32_t pwd) {
     forward_ptr = forwardLink_data;
     uint8_t len = Prepare_Cmd(FWD_CMD_LOGIN);
     len += Prepare_Data(pwd & 0xFFFF, pwd >> 16);
-    SendForward(len);
+    SendForward(len, false);
     //WaitUS(20); // no wait for login command.
     // should receive
     // 0000 1010 ok
     // 0000 0001 fail
 }
 
+void EM4xBruteforce(uint32_t start_pwd, uint32_t n) {
+    // With current timing, 18.6 ms per test = 53.8 pwds/s
+    reply_ng(CMD_LF_EM4X_BF, PM3_SUCCESS, NULL, 0);
+    StartTicks();
+    FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
+    WaitMS(20);
+    LED_A_ON();
+    LFSetupFPGAForADC(LF_DIVISOR_125, true);
+    uint32_t candidates_found = 0;
+    for (uint32_t pwd = start_pwd; pwd < 0xFFFFFFFF; pwd++) {
+        if (((pwd - start_pwd) & 0x3F) == 0x00) {
+            WDT_HIT();
+            if (BUTTON_PRESS() || data_available()) {
+                Dbprintf("EM4x05 Bruteforce Interrupted");
+                break;
+            }
+        }
+        // Report progress every 256 attempts
+        if (((pwd - start_pwd) & 0xFF) == 0x00) {
+            Dbprintf("Trying: %06Xxx", pwd >> 8);
+        }
+        clear_trace();
+
+        forward_ptr = forwardLink_data;
+        uint8_t len = Prepare_Cmd(FWD_CMD_LOGIN);
+        len += Prepare_Data(pwd & 0xFFFF, pwd >> 16);
+        SendForward(len, true);
+
+        WaitUS(400);
+        DoPartialAcquisition(0, false, 350, 1000);
+        uint8_t *mem = BigBuf_get_addr();
+        if (mem[334] < 128) {
+            Dbprintf("Password candidate: " _GREEN_("%08X"), pwd);
+            if ((n != 0) && (candidates_found == n)) {
+                Dbprintf("EM4x05 Bruteforce Stopped. %i candidates found", candidates_found);
+                break;
+            }
+        }
+        // Beware: if smaller, tag might not have time to be back in listening state yet
+        WaitMS(1);
+    }
+    StopTicks();
+    FpgaWriteConfWord(FPGA_MAJOR_MODE_OFF);
+    LEDsoff();
+}
+
 void EM4xLogin(uint32_t pwd) {
 
     StartTicks();
@@ -2558,7 +2605,7 @@ void EM4xReadWord(uint8_t addr, uint32_t pwd, uint8_t usepwd) {
     uint8_t len = Prepare_Cmd(FWD_CMD_READ);
     len += Prepare_Addr(addr);
 
-    SendForward(len);
+    SendForward(len, false);
 
     WaitUS(400);
 
@@ -2594,7 +2641,7 @@ void EM4xWriteWord(uint8_t addr, uint32_t data, uint32_t pwd, uint8_t usepwd) {
     len += Prepare_Addr(addr);
     len += Prepare_Data(data & 0xFFFF, data >> 16);
 
-    SendForward(len);
+    SendForward(len, false);
 
     if (tearoff_hook() == PM3_ETEAROFF) { // tearoff occured
         StopTicks();
@@ -2636,7 +2683,7 @@ void EM4xProtectWord(uint32_t data, uint32_t pwd, uint8_t usepwd) {
     uint8_t len = Prepare_Cmd(FWD_CMD_PROTECT);
     len += Prepare_Data(data & 0xFFFF, data >> 16);
 
-    SendForward(len);
+    SendForward(len, false);
 
     if (tearoff_hook() == PM3_ETEAROFF) { // tearoff occured
         StopTicks();
diff --git a/armsrc/lfops.h b/armsrc/lfops.h
index bf251ac85..0ec050158 100644
--- a/armsrc/lfops.h
+++ b/armsrc/lfops.h
@@ -57,6 +57,7 @@ void T55xxDangerousRawTest(uint8_t *data);
 void TurnReadLFOn(uint32_t delay);
 
 void EM4xLogin(uint32_t pwd);
+void EM4xBruteforce(uint32_t start_pwd, uint32_t n);
 void EM4xReadWord(uint8_t addr, uint32_t pwd, uint8_t usepwd);
 void EM4xWriteWord(uint8_t addr, uint32_t data, uint32_t pwd, uint8_t usepwd);
 void EM4xProtectWord(uint32_t data, uint32_t pwd, uint8_t usepwd);
diff --git a/client/src/cmdlfem4x.c b/client/src/cmdlfem4x.c
index 1625aa2ec..459f49a47 100644
--- a/client/src/cmdlfem4x.c
+++ b/client/src/cmdlfem4x.c
@@ -647,6 +647,7 @@ static command_t CommandTable[] = {
     {"4x05_write",  CmdEM4x05Write,       IfPm3Lf,         "write word data to EM4x05/EM4x69"},
     {"4x05_unlock", CmdEM4x05Unlock,      IfPm3Lf,         "execute tear off against EM4x05/EM4x69"},
     {"4x05_sniff",  CmdEM4x05Sniff,       IfPm3Lf,         "Attempt to recover em4x05 commands from sample buffer"},
+    {"4x05_brute",  CmdEM4x05Brute,       IfPm3Lf,         "Bruteforce password"},
     {"----------",  CmdHelp,              AlwaysAvailable,         "----------------------- " _CYAN_("EM 4x50") " -----------------------"},
     {"4x50_dump",   CmdEM4x50Dump,        IfPm3EM4x50,     "dump EM4x50 tag"},
     {"4x50_info",   CmdEM4x50Info,        IfPm3EM4x50,     "tag information EM4x50"},
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index deb47208f..3ad9be5a1 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1178,6 +1178,48 @@ int CmdEM4x05Chk(const char *Cmd) {
     return PM3_SUCCESS;
 }
 
+int CmdEM4x05Brute(const char *Cmd) {
+    CLIParserContext *ctx;
+    CLIParserInit(&ctx, "lf em 4x05_brute",
+                  "This command tries to bruteforce the password of a EM4205/4305/4469/4569\n",
+                  "Note: if you get many false positives, change position on the antenna"
+                  "lf em 4x05_brute\n"
+                  "lf em 4x05_brute -n 1                   -> stop after first candidate found\n"
+                  "lf em 4x05_brute -s 0x00000022B8        -> remember to use 0x for hex"
+                 );
+
+    void *argtable[] = {
+        arg_param_begin,
+        arg_u64_0("s", "start", "<pwd>", "Start bruteforce enumeration from this password value"),
+        arg_int0("n", "", "<digits>", "Stop after having found n candidates. Default: 0 => infinite"),
+        arg_param_end
+    };
+    CLIExecWithReturn(ctx, Cmd, argtable, true);
+    uint32_t start_pwd = arg_get_u64_def(ctx, 1, 0);
+    uint32_t n = arg_get_int_def(ctx, 1, 0);
+    CLIParserFree(ctx);
+
+    PrintAndLogEx(NORMAL, "");
+
+    struct {
+        uint32_t start_pwd;
+        uint32_t n;
+    } PACKED payload;
+
+    payload.start_pwd = start_pwd;
+    payload.n = n;
+
+    clearCommandBuffer();
+    SendCommandNG(CMD_LF_EM4X_BF, (uint8_t *)&payload, sizeof(payload));
+    PacketResponseNG resp;
+    if (!WaitForResponseTimeout(CMD_LF_EM4X_BF, &resp, 1000)) {
+        PrintAndLogEx(WARNING, "(EM4x05 Bruteforce) timeout while waiting for reply.");
+        return PM3_ETIMEOUT;
+    }
+    PrintAndLogEx(INFO, "Bruteforce is running on device side, press button to interrupt");
+    return PM3_SUCCESS;
+}
+
 typedef struct {
     uint16_t cnt;
     uint32_t value;
diff --git a/client/src/cmdlfem4x05.h b/client/src/cmdlfem4x05.h
index 276afebc2..f6e05c518 100644
--- a/client/src/cmdlfem4x05.h
+++ b/client/src/cmdlfem4x05.h
@@ -28,5 +28,6 @@ int CmdEM4x05Info(const char *Cmd);
 int CmdEM4x05Chk(const char *Cmd);
 int CmdEM4x05Unlock(const char *Cmd);
 int CmdEM4x05Sniff(const char *Cmd);
+int CmdEM4x05Brute(const char *Cmd);
 
 #endif
diff --git a/include/pm3_cmd.h b/include/pm3_cmd.h
index be2227b7c..c393ae218 100644
--- a/include/pm3_cmd.h
+++ b/include/pm3_cmd.h
@@ -500,6 +500,7 @@ typedef struct {
 #define CMD_LF_EM4X_READWORD                                              0x0218
 #define CMD_LF_EM4X_WRITEWORD                                             0x0219
 #define CMD_LF_EM4X_PROTECTWORD                                           0x021B
+#define CMD_LF_EM4X_BF                                                    0x022A
 #define CMD_LF_IO_WATCH                                                   0x021A
 #define CMD_LF_EM410X_WATCH                                               0x021C
 #define CMD_LF_EM4X50_INFO                                                0x0240

From ecf50070dd9e1d6ab47c4964636672bf51150cbc Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 14:16:15 +0200
Subject: [PATCH 14/35] typo, thanks iceman

---
 client/src/cmdlfem4x05.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 3ad9be5a1..7cb77803e 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1185,7 +1185,7 @@ int CmdEM4x05Brute(const char *Cmd) {
                   "Note: if you get many false positives, change position on the antenna"
                   "lf em 4x05_brute\n"
                   "lf em 4x05_brute -n 1                   -> stop after first candidate found\n"
-                  "lf em 4x05_brute -s 0x00000022B8        -> remember to use 0x for hex"
+                  "lf em 4x05_brute -s 0x000022B8          -> remember to use 0x for hex"
                  );
 
     void *argtable[] = {

From a6beff18a5bbd2c6127afc1e20f1aedc4265c069 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 15:46:44 +0200
Subject: [PATCH 15/35] fix em 4x05 bf

---
 armsrc/lfops.c           | 3 ++-
 client/src/cmdlfem4x05.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/armsrc/lfops.c b/armsrc/lfops.c
index 3d7154eb3..1ccc1879a 100644
--- a/armsrc/lfops.c
+++ b/armsrc/lfops.c
@@ -2545,9 +2545,10 @@ void EM4xBruteforce(uint32_t start_pwd, uint32_t n) {
         DoPartialAcquisition(0, false, 350, 1000);
         uint8_t *mem = BigBuf_get_addr();
         if (mem[334] < 128) {
+            candidates_found++;
             Dbprintf("Password candidate: " _GREEN_("%08X"), pwd);
             if ((n != 0) && (candidates_found == n)) {
-                Dbprintf("EM4x05 Bruteforce Stopped. %i candidates found", candidates_found);
+                Dbprintf("EM4x05 Bruteforce Stopped. %i candidate%s found", candidates_found, candidates_found > 1 ? "s" : "");
                 break;
             }
         }
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 7cb77803e..404a6af3d 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1196,7 +1196,7 @@ int CmdEM4x05Brute(const char *Cmd) {
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     uint32_t start_pwd = arg_get_u64_def(ctx, 1, 0);
-    uint32_t n = arg_get_int_def(ctx, 1, 0);
+    uint32_t n = arg_get_int_def(ctx, 2, 0);
     CLIParserFree(ctx);
 
     PrintAndLogEx(NORMAL, "");

From 96a6b99a800628a03b67c95abf91fd7656720289 Mon Sep 17 00:00:00 2001
From: mwalker33 <51802811+mwalker33@users.noreply.github.com>
Date: Wed, 21 Oct 2020 00:28:45 +1100
Subject: [PATCH 16/35] Update cmdlfem4x05.c

Early bug fixs and extend to all commands.
---
 client/src/cmdlfem4x05.c | 104 +++++++++++++++++++++++++--------------
 1 file changed, 68 insertions(+), 36 deletions(-)

diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 404a6af3d..c3a17a596 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1660,24 +1660,51 @@ static size_t em4x05_Sniff_GetNextBitStart (size_t idx, size_t sc, int *data, si
 uint32_t static em4x05_Sniff_GetBlock (char *bits, bool fwd) {
     uint32_t value = 0;
     uint8_t idx;
+    bool parityerror = false;
+    uint8_t parity;
 
+    parity = 0;
     for (idx = 0; idx < 8; idx++) {
         value <<= 1;
         value += (bits[idx] - '0');
+        parity += (bits[idx] - '0');
     }
+    parity = parity % 2;
+    if (parity != (bits[8] - '0'))
+        parityerror = true;
+
+    parity = 0;
     for (idx = 9; idx < 17; idx++) {
         value <<= 1;
         value += (bits[idx] - '0');
+        parity += (bits[idx] - '0');
     }
+    parity = parity % 2;
+    if (parity != (bits[17] - '0'))
+        parityerror = true;
+
+    parity = 0;
     for (idx = 18; idx < 26; idx++) {
         value <<= 1;
         value += (bits[idx] - '0');
+        parity += (bits[idx] - '0');
     }
+    parity = parity % 2;
+    if (parity != (bits[26] - '0'))
+        parityerror = true;
+
+    parity = 0;
     for (idx = 27; idx < 35; idx++) {
         value <<= 1;
         value += (bits[idx] - '0');
+        parity += (bits[idx] - '0');
     }
-    
+    parity = parity % 2;
+    if (parity != (bits[35] - '0'))
+        parityerror = true;
+
+    if (parityerror) printf ("parity error : ");
+
     if (!fwd) {
         uint32_t t1 = value;
         value = 0;
@@ -1754,11 +1781,8 @@ int CmdEM4x05Sniff(const char *Cmd) {
             idx = em4x05_Sniff_GetNextBitStart (idx, GraphTraceLen, GraphBuffer, &pulseSamples);
             ZeroWidth = idx - ZeroWidth;
 
-       //     printf ("Zero width after 2 0 bits : %llu 0 Zero width %d\n",idx,ZeroWidth);
-
             if (ZeroWidth <= 50) {
-                    pktOffset -= ZeroWidth;
-              //  ZeroSamples = 0;
+                pktOffset -= ZeroWidth;
                 memset(bits,0x00,sizeof(bits));
                 bitidx = 0;
 
@@ -1771,7 +1795,7 @@ int CmdEM4x05Sniff(const char *Cmd) {
                         eop = true;
                         bits[bitidx++] = '0';   // Append last zero from the last bit find
                         cmdText[0] = 0;
-                        // Memo6->Lines->Add("Bit widths... : "+T1);
+
                         // EM4305 command lengths
                         // Login        0011 <pwd>          => 4 +     45 => 49
                         // Write Word   0101 <adr> <data>   => 4 + 7 + 45 => 56
@@ -1780,6 +1804,18 @@ int CmdEM4x05Sniff(const char *Cmd) {
                         // Disable      1010       <data>   => 4 +     45 => 49
                         // -> disaable 1010 11111111 0 11111111 0 11111111 0 11111111 0 00000000 0
 
+                        // Check to see if we got the leading 0
+                        if  (((strncmp (bits,"00011",5) == 0)&& (bitidx == 50)) ||
+                             ((strncmp (bits,"00101",5) == 0)&& (bitidx == 57)) ||
+                             ((strncmp (bits,"01001",5) == 0)&& (bitidx == 12)) ||
+                             ((strncmp (bits,"01100",5) == 0)&& (bitidx == 50)) ||
+                             ((strncmp (bits,"01010",5) == 0)&& (bitidx == 50))) {
+                                 memcpy (bits,&bits[1],bitidx-1);
+                                 bitidx--;
+                             printf ("Trim leading 0\n");
+                        }
+                        bits[bitidx] = 0;
+         //   printf ("==> %s\n",bits);
                         // logon
                         if ((strncmp (bits,"0011",4) == 0) && (bitidx == 49)) {
                             haveData = true;
@@ -1794,7 +1830,6 @@ int CmdEM4x05Sniff(const char *Cmd) {
                         if ((strncmp (bits,"0101",4) == 0) && (bitidx == 56)) {
                             haveData = true;
                             sprintf (cmdText,"Write");
-                            tmpValue = 0;
                             tmpValue = (bits[4] - '0') + ((bits[5] - '0') << 1) + ((bits[6] - '0') << 2)  + ((bits[7] - '0') << 3);
                             sprintf (blkAddr,"%d",tmpValue);
                             if (tmpValue == 2)
@@ -1803,42 +1838,39 @@ int CmdEM4x05Sniff(const char *Cmd) {
                             sprintf (dataText,"%08X",tmpValue);
                         }
 
-                        // write 2 test
-                        if ((strncmp (bits,"00101",5) == 0) && (bitidx == 57)) {
+                        // read
+                        if ((strncmp (bits,"1001",4) == 0) && (bitidx == 11)) {
                             haveData = true;
-                            sprintf (cmdText,"Write");
-                            tmpValue = 0;
-                            tmpValue = (bits[5] - '0') + ((bits[6] - '0') << 1) + ((bits[7] - '0') << 2)  + ((bits[8] - '0') << 3);
+                            pwd = false;
+                            sprintf (cmdText,"Read");
+                            tmpValue = (bits[4] - '0') + ((bits[5] - '0') << 1) + ((bits[6] - '0') << 2)  + ((bits[7] - '0') << 3);
                             sprintf (blkAddr,"%d",tmpValue);
-                            if (tmpValue == 2)
-                                pwd = true;
-                            tmpValue = em4x05_Sniff_GetBlock (&bits[12], fwd);
+                            sprintf (dataText," ");
+                        }
+
+                        // protect
+                        if ((strncmp (bits,"1100",4) == 0) && (bitidx == 49)) {
+                            haveData = true;
+                            pwd = false;
+                            sprintf (cmdText,"Protect");
+                            sprintf (blkAddr," ");
+                            tmpValue = em4x05_Sniff_GetBlock (&bits[11], fwd);
                             sprintf (dataText,"%08X",tmpValue);
                         }
-/*
-                        if ((Bits.SubString(1,4) == "1001") && (Bits.Length() == 11)) {
-                            Addr = Bits.SubString(5,7);
-                            Data = "";
-                            Memo6->Lines->Add("Read  :     "+Addr+" "+Data);
+
+                        // disable
+                        if ((strncmp (bits,"1010",4) == 0) && (bitidx == 49)) {
+                            haveData = true;
+                            pwd = false;
+                            sprintf (cmdText,"Disable");
+                            sprintf (blkAddr," ");
+                            tmpValue = em4x05_Sniff_GetBlock (&bits[11], fwd);
+                            sprintf (dataText,"%08X",tmpValue);
                         }
 
-                        if ((Bits.SubString(1,4) == "1100") && (Bits.Length() == 49)) {
-                            Addr = "";
-                            Data = Bits.SubString(5,45);
-                            Memo6->Lines->Add("Protect :     "+Addr+" "+Data);
-                        }
-
-                        if ((Bits.SubString(1,4) == "1010") && (Bits.Length() == 49)) {
-                            Addr = "";
-                            Data = Bits.SubString(5,45);
-                            Memo6->Lines->Add("Disable :     "+Addr+" "+Data);
-                        }
-*/
-                        // Memo6->Lines->Add("Raw : "+Bits);
-                        bits[bitidx] = 0;
-                     //   printf ("%s\n",bits);
+                      //  bits[bitidx] = 0;
                     } else {
-                        i = (CycleWidth - ZeroWidth) / 30;
+                        i = (CycleWidth - ZeroWidth) / 28;
                         bits[bitidx++] = '0';
                         for (int ii = 0; ii < i; ii++)
                             bits[bitidx++] = '1';

From 3959b77febc19beb6f90f560d2452083eaa7505b Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 16:12:34 +0200
Subject: [PATCH 17/35] 4x05 sniff: available offline

---
 client/src/cmdlfem4x.c   | 2 +-
 client/src/cmdlfem4x05.c | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/client/src/cmdlfem4x.c b/client/src/cmdlfem4x.c
index 459f49a47..74ce5a737 100644
--- a/client/src/cmdlfem4x.c
+++ b/client/src/cmdlfem4x.c
@@ -646,7 +646,7 @@ static command_t CommandTable[] = {
     {"4x05_read",   CmdEM4x05Read,        IfPm3Lf,         "read word data from EM4x05/EM4x69"},
     {"4x05_write",  CmdEM4x05Write,       IfPm3Lf,         "write word data to EM4x05/EM4x69"},
     {"4x05_unlock", CmdEM4x05Unlock,      IfPm3Lf,         "execute tear off against EM4x05/EM4x69"},
-    {"4x05_sniff",  CmdEM4x05Sniff,       IfPm3Lf,         "Attempt to recover em4x05 commands from sample buffer"},
+    {"4x05_sniff",  CmdEM4x05Sniff,       AlwaysAvailable, "Attempt to recover em4x05 commands from sample buffer"},
     {"4x05_brute",  CmdEM4x05Brute,       IfPm3Lf,         "Bruteforce password"},
     {"----------",  CmdHelp,              AlwaysAvailable,         "----------------------- " _CYAN_("EM 4x50") " -----------------------"},
     {"4x50_dump",   CmdEM4x50Dump,        IfPm3EM4x50,     "dump EM4x50 tag"},
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index c3a17a596..7ff4cb07f 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -1756,6 +1756,10 @@ int CmdEM4x05Sniff(const char *Cmd) {
     // setup and sample data from Proxmark
     // if not directed to existing sample/graphbuffer
     if (sampleData) {
+        if (!IfPm3Lf()) {
+            PrintAndLogEx(WARNING, "Only offline mode is available");
+            return PM3_EINVARG;
+        }
         CmdLFSniff("");
     }
 

From 2e27a493e8b964ccb73af4abd9a1b605ea02cadb Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 17:34:42 +0200
Subject: [PATCH 18/35] revert to precision clock

---
 armsrc/appmain.c          |  6 +++++-
 armsrc/i2c.c              | 28 +++++++++-------------------
 client/src/cmdsmartcard.c | 21 +++++++++++++--------
 3 files changed, 27 insertions(+), 28 deletions(-)

diff --git a/armsrc/appmain.c b/armsrc/appmain.c
index aa0f23d8f..5399b326a 100644
--- a/armsrc/appmain.c
+++ b/armsrc/appmain.c
@@ -1613,7 +1613,11 @@ static void PacketReceived(PacketCommandNG *packet) {
             break;
         }
         case CMD_SMART_SETCLOCK: {
-            SmartCardSetClock(packet->oldarg[0]);
+            struct p {
+                uint32_t new_clk;
+            } PACKED;
+            struct p *payload = (struct p *)packet->data.asBytes;
+            SmartCardSetClock(payload->new_clk);
             break;
         }
         case CMD_SMART_RAW: {
diff --git a/armsrc/i2c.c b/armsrc/i2c.c
index 1ca742893..7b858dd36 100644
--- a/armsrc/i2c.c
+++ b/armsrc/i2c.c
@@ -47,12 +47,6 @@ static void __attribute__((optimize("O0"))) I2CSpinDelayClk(uint16_t delay) {
 #define I2C_DELAY_2CLK    I2CSpinDelayClk(2)
 #define I2C_DELAY_XCLK(x) I2CSpinDelayClk((x))
 
-#define I2C_DELAY_100us   I2CSpinDelayClk( 100 / 3)
-#define I2C_DELAY_600us   I2CSpinDelayClk( 600 / 3)
-#define I2C_DELAY_10ms    I2CSpinDelayClk( 10 * 1000 / 3 )
-#define I2C_DELAY_30ms    I2CSpinDelayClk( 30 * 1000 / 3 )
-#define I2C_DELAY_100ms   I2CSpinDelayClk( 100 * 1000 / 3)
-
 #define  ISO7618_MAX_FRAME 255
 
 // try i2c bus recovery at 100kHz = 5us high, 5us low
@@ -134,11 +128,11 @@ void I2C_Reset_EnterMainProgram(void) {
     StartTicks();
     I2C_init();
     I2C_SetResetStatus(0, 0, 0);
-    I2C_DELAY_30ms;
+    WaitMS(30);
     I2C_SetResetStatus(1, 0, 0);
-    I2C_DELAY_30ms;
+    WaitMS(30);
     I2C_SetResetStatus(1, 1, 1);
-    I2C_DELAY_10ms;
+    WaitMS(10);
 }
 
 // Reset the SIM_Adapter, then enter the bootloader program
@@ -147,9 +141,9 @@ void I2C_Reset_EnterBootloader(void) {
     StartTicks();
     I2C_init();
     I2C_SetResetStatus(0, 1, 1);
-    I2C_DELAY_100ms;
+    WaitMS(100);
     I2C_SetResetStatus(1, 1, 1);
-    I2C_DELAY_10ms;
+    WaitMS(10);
 }
 
 // Wait for the clock to go High.
@@ -193,7 +187,7 @@ static bool WaitSCL_L_timeout(void) {
         if (!SCL_read)
             return true;
 
-        I2C_DELAY_100us;
+        WaitMS(1);
     }
     return (delay == 0);
 }
@@ -440,8 +434,7 @@ int16_t I2C_BufferRead(uint8_t *data, uint8_t len, uint8_t device_cmd, uint8_t d
 
     // extra wait  500us (514us measured)
     // 200us  (xx measured)
-//    WaitUS(600);
-    I2C_DELAY_600us;
+    WaitUS(600);
 
     bool bBreak = true;
     uint16_t readcount = 0;
@@ -811,8 +804,7 @@ void SmartCardUpgrade(uint64_t arg0) {
         }
 
         // writing takes time.
-//        WaitMS(50);
-        I2C_DELAY_100ms;
+        WaitMS(100);
 
         // read
         res = I2C_ReadFW(verfiydata, size, msb, lsb, I2C_DEVICE_ADDRESS_BOOT);
@@ -844,12 +836,10 @@ void SmartCardSetClock(uint64_t arg0) {
     LED_D_ON();
     set_tracing(true);
     I2C_Reset_EnterMainProgram();
-
     // Send SIM CLC
     // start [C0 05 xx] stop
     I2C_WriteByte(arg0, I2C_DEVICE_CMD_SIM_CLC, I2C_DEVICE_ADDRESS_MAIN);
-
-    reply_mix(CMD_ACK, 1, 0, 0, 0, 0);
+    reply_ng(CMD_SMART_SETCLOCK, PM3_SUCCESS, NULL, 0);
     set_tracing(false);
     LEDsoff();
 }
diff --git a/client/src/cmdsmartcard.c b/client/src/cmdsmartcard.c
index dc8205948..c6b2e66e1 100644
--- a/client/src/cmdsmartcard.c
+++ b/client/src/cmdsmartcard.c
@@ -791,14 +791,14 @@ static int CmdSmartReader(const char *Cmd) {
 static int CmdSmartSetClock(const char *Cmd) {
     uint8_t cmdp = 0;
     bool errors = false;
-    uint8_t clock1 = 0;
+    uint8_t new_clk = 0;
     while (param_getchar(Cmd, cmdp) != 0x00 && !errors) {
         switch (tolower(param_getchar(Cmd, cmdp))) {
             case 'h':
                 return usage_sm_setclock();
             case 'c':
-                clock1 = param_get8ex(Cmd, cmdp + 1, 2, 10);
-                if (clock1 > 2)
+                new_clk = param_get8ex(Cmd, cmdp + 1, 2, 10);
+                if (new_clk > 2)
                     errors = true;
 
                 cmdp += 2;
@@ -813,21 +813,26 @@ static int CmdSmartSetClock(const char *Cmd) {
     //Validations
     if (errors || cmdp == 0) return usage_sm_setclock();
 
+    struct {
+        uint32_t new_clk;
+    } PACKED payload;
+    
+    payload.new_clk = new_clk;
+
     clearCommandBuffer();
-    SendCommandMIX(CMD_SMART_SETCLOCK, clock1, 0, 0, NULL, 0);
+    SendCommandNG(CMD_SMART_SETCLOCK, (uint8_t*)&payload, sizeof(payload));
     PacketResponseNG resp;
-    if (!WaitForResponseTimeout(CMD_ACK, &resp, 2500)) {
+    if (!WaitForResponseTimeout(CMD_SMART_SETCLOCK, &resp, 2500)) {
         PrintAndLogEx(WARNING, "smart card select failed");
         return PM3_ETIMEOUT;
     }
 
-    uint8_t isok = resp.oldarg[0] & 0xFF;
-    if (!isok) {
+    if (resp.status != PM3_SUCCESS) {
         PrintAndLogEx(WARNING, "smart card set clock failed");
         return PM3_ESOFT;
     }
 
-    switch (clock1) {
+    switch (new_clk) {
         case 0:
             PrintAndLogEx(SUCCESS, "Clock changed to 16MHz giving 10800 baudrate");
             break;

From d8294a958b0a801e90d6cd85f390762a191642db Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 17:36:01 +0200
Subject: [PATCH 19/35] hf 14a antifuzz - now uses NG

---
 armsrc/appmain.c      |  6 +++++-
 armsrc/iso14443a.c    |  2 +-
 client/src/cmdhf14a.c | 18 +++++++++++-------
 3 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/armsrc/appmain.c b/armsrc/appmain.c
index 5399b326a..f5eacc363 100644
--- a/armsrc/appmain.c
+++ b/armsrc/appmain.c
@@ -1259,7 +1259,11 @@ static void PacketReceived(PacketCommandNG *packet) {
             break;
         }
         case CMD_HF_ISO14443A_ANTIFUZZ: {
-            iso14443a_antifuzz(packet->oldarg[0]);
+            struct p {
+                uint8_t flag;
+            } PACKED;
+            struct p *payload = (struct p *) packet->data.asBytes;
+            iso14443a_antifuzz(payload->flag);
             break;
         }
         case CMD_HF_EPA_COLLECT_NONCE: {
diff --git a/armsrc/iso14443a.c b/armsrc/iso14443a.c
index 6e1e22738..cf0bce153 100644
--- a/armsrc/iso14443a.c
+++ b/armsrc/iso14443a.c
@@ -2390,7 +2390,7 @@ void iso14443a_antifuzz(uint32_t flags) {
         }
     }
 
-    reply_old(CMD_ACK, 1, 0, 0, 0, 0);
+    reply_ng(CMD_HF_ISO14443A_ANTIFUZZ, PM3_SUCCESS, NULL, 0);
     switch_off();
     BigBuf_free_keep_EM();
 }
diff --git a/client/src/cmdhf14a.c b/client/src/cmdhf14a.c
index dac2193c6..00b7d9484 100644
--- a/client/src/cmdhf14a.c
+++ b/client/src/cmdhf14a.c
@@ -1338,7 +1338,7 @@ static int CmdHF14ACmdRaw(const char *Cmd) {
         if (!res && datalen > 0)
             waitCmd(0, timeout);
     }
-    return 0;
+    return PM3_SUCCESS;
 }
 
 static int waitCmd(uint8_t iSelect, uint32_t timeout) {
@@ -1398,16 +1398,20 @@ static int CmdHF14AAntiFuzz(const char *Cmd) {
     };
     CLIExecWithReturn(ctx, Cmd, argtable, false);
 
-    uint8_t arg0 = FLAG_4B_UID_IN_DATA;
+    struct {
+        uint8_t flag;
+    } PACKED param;
+    param.flag = FLAG_4B_UID_IN_DATA;
+
     if (arg_get_lit(ctx, 2))
-        arg0 = FLAG_7B_UID_IN_DATA;
+        param.flag = FLAG_7B_UID_IN_DATA;
     if (arg_get_lit(ctx, 3))
-        arg0 = FLAG_10B_UID_IN_DATA;
+        param.flag = FLAG_10B_UID_IN_DATA;
 
     CLIParserFree(ctx);
     clearCommandBuffer();
-    SendCommandMIX(CMD_HF_ISO14443A_ANTIFUZZ, arg0, 0, 0, NULL, 0);
-    return 0;
+    SendCommandNG(CMD_HF_ISO14443A_ANTIFUZZ, (uint8_t*)&param, sizeof(param));
+    return PM3_SUCCESS;
 }
 
 static int CmdHF14AChaining(const char *Cmd) {
@@ -1438,7 +1442,7 @@ static int CmdHF14AChaining(const char *Cmd) {
 
     PrintAndLogEx(INFO, "\nISO 14443-4 input chaining %s.\n", APDUInFramingEnable ? "enabled" : "disabled");
 
-    return 0;
+    return PM3_SUCCESS;
 }
 
 static void printTag(const char *tag) {

From 8d8cafeea5b22107b7e4433e5cbc9c7fe5375e33 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 17:46:16 +0200
Subject: [PATCH 20/35] display cmake version

---
 client/CMakeLists.txt         | 1 +
 client/android/CMakeLists.txt | 1 +
 2 files changed, 2 insertions(+)

diff --git a/client/CMakeLists.txt b/client/CMakeLists.txt
index 46e77a14f..09271f1c4 100644
--- a/client/CMakeLists.txt
+++ b/client/CMakeLists.txt
@@ -18,6 +18,7 @@
 #    -DANDROID_NATIVE_API_LEVEL=android-19 \
 #    -DSKIPBT=1 -DSKIPPYTHON=1 -DSKIPPTHREAD=1 ..
 
+message("-- CMake ${CMAKE_VERSION}")
 cmake_minimum_required(VERSION 3.10)
 project(proxmark3)
 SET (PM3_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/..)
diff --git a/client/android/CMakeLists.txt b/client/android/CMakeLists.txt
index b3f432c6c..cafd11e7f 100644
--- a/client/android/CMakeLists.txt
+++ b/client/android/CMakeLists.txt
@@ -1,4 +1,5 @@
 # version
+message("-- CMake ${CMAKE_VERSION}")
 cmake_minimum_required(VERSION 3.4.1)
 
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3 -fvisibility=hidden -w")

From b671de7b943646d1e063f27f9a9a8a9335188b26 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 17:50:06 +0200
Subject: [PATCH 21/35] more...

---
 client/dictionaries/mfc_default_keys.dic | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/client/dictionaries/mfc_default_keys.dic b/client/dictionaries/mfc_default_keys.dic
index 58c2c40bc..cf40e63fd 100644
--- a/client/dictionaries/mfc_default_keys.dic
+++ b/client/dictionaries/mfc_default_keys.dic
@@ -1203,3 +1203,9 @@ FEE2A3FBC5B6
 # taurus avm
 #
 005078565703
+#
+# Ving?
+#
+0602721E8F06
+FC0B50AF8700
+F7BA51A9434E
\ No newline at end of file

From 183b375e27d03a44599e715ba1ace7fd3f5d39dd Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 18:54:31 +0200
Subject: [PATCH 22/35] fix cmake bug for cmake >= 3.18

---
 client/CMakeLists.txt         | 10 ----------
 client/android/CMakeLists.txt | 10 ----------
 client/deps/amiibo.cmake      |  1 -
 3 files changed, 21 deletions(-)

diff --git a/client/CMakeLists.txt b/client/CMakeLists.txt
index 09271f1c4..d3064bffb 100644
--- a/client/CMakeLists.txt
+++ b/client/CMakeLists.txt
@@ -497,20 +497,10 @@ if (NOT APPLE)
     set(ADDITIONAL_LNK ${ADDITIONAL_LNK} -Wl,--as-needed -latomic -Wl,--no-as-needed)
 endif (NOT APPLE)
 
-
-find_library(pm3rrg_rdv4_cliparser REQUIRED)
-find_library(pm3rrg_rdv4_tinycbor REQUIRED)
-find_library(pm3rrg_rdv4_lua REQUIRED)
-find_library(pm3rrg_rdv4_mbedtls REQUIRED)
-find_library(pm3rrg_rdv4_reveng REQUIRED)
-find_library(pm3rrg_rdv4_hardnested REQUIRED)
-
 if (NOT JANSSON_FOUND)
-    find_library(pm3rrg_rdv4_jansson REQUIRED)
     set(ADDITIONAL_LNK pm3rrg_rdv4_jansson ${ADDITIONAL_LNK})
 endif (NOT JANSSON_FOUND)
 if (NOT WHEREAMI_FOUND)
-    find_library(pm3rrg_rdv4_whereami REQUIRED)
     set(ADDITIONAL_LNK pm3rrg_rdv4_whereami ${ADDITIONAL_LNK})
 endif (NOT WHEREAMI_FOUND)
 
diff --git a/client/android/CMakeLists.txt b/client/android/CMakeLists.txt
index cafd11e7f..fcc4583fb 100644
--- a/client/android/CMakeLists.txt
+++ b/client/android/CMakeLists.txt
@@ -13,7 +13,6 @@ add_subdirectory(../deps deps)
 if (CMAKE_MAKE_PROGRAM MATCHES ".*ninja.*")
     set(BZIP2_INCLUDE_DIRS ${BZIP2_ROOT})
     set(BZIP2_LIBRARIES pm3rrg_rdv4_bzip2)
-    find_library(pm3rrg_rdv4_bzip2 REQUIRED)
 elseif (UNIX) # Cross compile at Unix Makefile System.
     # bzip2 dep.
     include(ExternalProject)
@@ -191,15 +190,6 @@ target_include_directories(pm3rrg_rdv4 PRIVATE
         ${PM3_ROOT}/common_fpga
         ${PM3_ROOT}/client/src)
 
-find_library(pm3rrg_rdv4_cliparser REQUIRED)
-find_library(pm3rrg_rdv4_jansson REQUIRED)
-find_library(pm3rrg_rdv4_tinycbor REQUIRED)
-find_library(pm3rrg_rdv4_lua REQUIRED)
-find_library(pm3rrg_rdv4_mbedtls REQUIRED)
-find_library(pm3rrg_rdv4_reveng REQUIRED)
-find_library(pm3rrg_rdv4_hardnested REQUIRED)
-find_library(pm3rrg_rdv4_whereami REQUIRED)
-
 target_link_libraries(pm3rrg_rdv4
         ${BZIP2_LIBRARIES}
         pm3rrg_rdv4_hardnested
diff --git a/client/deps/amiibo.cmake b/client/deps/amiibo.cmake
index 234547cd1..491d90d60 100644
--- a/client/deps/amiibo.cmake
+++ b/client/deps/amiibo.cmake
@@ -14,7 +14,6 @@ add_library(pm3rrg_rdv4_amiibo STATIC
 if (NOT TARGET pm3rrg_rdv4_mbedtls)
   include(mbedtls.cmake)
 endif()
-find_library(pm3rrg_rdv4_mbedtls REQUIRED)
 target_link_libraries(pm3rrg_rdv4_amiibo PRIVATE
         m
         pm3rrg_rdv4_mbedtls)

From e7a76cee5a119deca332ea578eca7739f67ffd06 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 19:28:57 +0200
Subject: [PATCH 23/35] ugly fix for gcc10 stringop-overflow warning

---
 client/src/cmdhfwaveshare.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/src/cmdhfwaveshare.c b/client/src/cmdhfwaveshare.c
index b47043be2..96547668f 100644
--- a/client/src/cmdhfwaveshare.c
+++ b/client/src/cmdhfwaveshare.c
@@ -542,7 +542,8 @@ static void read_black(uint32_t i, uint8_t *l, uint8_t model_nr, uint8_t *black)
     }
 }
 static void read_red(uint32_t i, uint8_t *l, uint8_t model_nr, uint8_t *red) {
-    for (uint8_t j = 0; j < models[model_nr].len; j++) {
+    // spurious warning with GCC10 (-Wstringop-overflow) when j is uint8_t, even if all len are < 128
+    for (uint16_t j = 0; j < models[model_nr].len; j++) {
         if (model_nr == M1in54B) {
             //1.54B needs to flip the red picture data, other screens do not need to flip data
             l[3 + j] = ~red[i * models[model_nr].len + j];

From 47cfc778e3faa65be04269f11d6e48aba78e7de5 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 20:21:57 +0200
Subject: [PATCH 24/35] typos

---
 armsrc/lfops.c           | 2 +-
 client/src/cmdlfem4x50.c | 2 +-
 client/src/cmdlft55xx.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/armsrc/lfops.c b/armsrc/lfops.c
index 1ccc1879a..f52bdd788 100644
--- a/armsrc/lfops.c
+++ b/armsrc/lfops.c
@@ -2491,7 +2491,7 @@ static void SendForward(uint8_t fwd_bit_count, bool fast) {
     TurnReadLF_off(EM_START_GAP);
     TurnReadLFOn(18 * 8);
 
-    // now start writting with bitbanging the antenna. (each bit should be 32*8 total length)
+    // now start writing with bitbanging the antenna. (each bit should be 32*8 total length)
     while (fwd_bit_sz-- > 0) { //prepare next bit modulation
         if (((*fwd_write_ptr++) & 1) == 1) {
             WaitUS(32 * 8);
diff --git a/client/src/cmdlfem4x50.c b/client/src/cmdlfem4x50.c
index 89da1efc1..2f768c62b 100644
--- a/client/src/cmdlfem4x50.c
+++ b/client/src/cmdlfem4x50.c
@@ -77,7 +77,7 @@ static int usage_lf_em4x50_dump(void) {
     PrintAndLogEx(NORMAL, "Usage:  lf em 4x50_dump [h] [f <filename prefix>] [p <pwd>]");
     PrintAndLogEx(NORMAL, "Options:");
     PrintAndLogEx(NORMAL, "       h                     - this help");
-    PrintAndLogEx(NORMAL, "       f <filename prefix>   - overide filename prefix (optional).  Default is based on UID");
+    PrintAndLogEx(NORMAL, "       f <filename prefix>   - override filename prefix (optional).  Default is based on UID");
     PrintAndLogEx(NORMAL, "       p <pwd>               - password (hex) (optional)");
     PrintAndLogEx(NORMAL, "Examples:");
     PrintAndLogEx(NORMAL, _YELLOW_("      lf em 4x50_dump"));
diff --git a/client/src/cmdlft55xx.c b/client/src/cmdlft55xx.c
index 7c8f39b3b..6abd811f6 100644
--- a/client/src/cmdlft55xx.c
+++ b/client/src/cmdlft55xx.c
@@ -186,7 +186,7 @@ static int usage_t55xx_dump(void) {
     PrintAndLogEx(NORMAL, "Options:");
     PrintAndLogEx(NORMAL, "     p <password> - OPTIONAL password 4bytes (8 hex symbols)");
     PrintAndLogEx(NORMAL, "     o            - OPTIONAL override, force pwd read despite danger to card");
-    PrintAndLogEx(NORMAL, "     f <prefix>   - overide filename prefix (optional).  Default is based on blk 0");
+    PrintAndLogEx(NORMAL, "     f <prefix>   - override filename prefix (optional).  Default is based on blk 0");
     print_usage_t55xx_downloadlink(T55XX_DLMODE_SINGLE, config.downlink_mode);
     PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(NORMAL, "Examples:");

From 189568107aa1f97991b432f8761dc5fa1ad20652 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 20:54:48 +0200
Subject: [PATCH 25/35] Move CMake version message to stdout, thanks gator

---
 client/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/CMakeLists.txt b/client/CMakeLists.txt
index d3064bffb..6d4abf82d 100644
--- a/client/CMakeLists.txt
+++ b/client/CMakeLists.txt
@@ -18,7 +18,7 @@
 #    -DANDROID_NATIVE_API_LEVEL=android-19 \
 #    -DSKIPBT=1 -DSKIPPYTHON=1 -DSKIPPTHREAD=1 ..
 
-message("-- CMake ${CMAKE_VERSION}")
+message(STATUS "CMake ${CMAKE_VERSION}")
 cmake_minimum_required(VERSION 3.10)
 project(proxmark3)
 SET (PM3_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/..)

From f4f514fca0dbaeab244dc74803fb516177a231e0 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 20:57:06 +0200
Subject: [PATCH 26/35] Move CMake version message to stdout, thanks gator

---
 client/android/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/android/CMakeLists.txt b/client/android/CMakeLists.txt
index fcc4583fb..69e71d5d5 100644
--- a/client/android/CMakeLists.txt
+++ b/client/android/CMakeLists.txt
@@ -1,5 +1,5 @@
 # version
-message("-- CMake ${CMAKE_VERSION}")
+message(STATUS "CMake ${CMAKE_VERSION}")
 cmake_minimum_required(VERSION 3.4.1)
 
 set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3 -fvisibility=hidden -w")

From fa96a6ef80445514da06d4ec14cf9921f414edf6 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 21:59:33 +0200
Subject: [PATCH 27/35] prepping for adding support of EM4305 to clone commands

---
 client/src/cmdlf.c       |   2 +-
 client/src/cmdlfem4x05.c | 125 ++++++++++++++++++---------------------
 client/src/cmdlfem4x05.h |  38 +++++++++++-
 3 files changed, 93 insertions(+), 72 deletions(-)

diff --git a/client/src/cmdlf.c b/client/src/cmdlf.c
index 95e38b6c0..44af2b092 100644
--- a/client/src/cmdlf.c
+++ b/client/src/cmdlf.c
@@ -1348,7 +1348,7 @@ static bool CheckChipType(bool getDeviceData) {
 
     //check for em4x05/em4x69 chips first
     uint32_t word = 0;
-    if (EM4x05IsBlock0(&word)) {
+    if (em4x05_isblock0(&word)) {
         PrintAndLogEx(SUCCESS, "Chipset detection: " _GREEN_("EM4x05 / EM4x69"));
         PrintAndLogEx(HINT, "Hint: try " _YELLOW_("`lf em 4x05`") " commands");
         retval = true;
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 7ff4cb07f..993a4a09d 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -36,6 +36,8 @@
 
 //////////////// 4205 / 4305 commands
 
+#define EM_PREAMBLE_LEN 8
+
 static int usage_lf_em4x05_wipe(void) {
     PrintAndLogEx(NORMAL, "Wipe EM4x05/EM4x69.  Tag must be on antenna. ");
     PrintAndLogEx(NORMAL, "");
@@ -90,19 +92,6 @@ static int usage_lf_em4x05_info(void) {
     return PM3_SUCCESS;
 }
 
-#define EM_SERIAL_BLOCK 1
-#define EM_CONFIG_BLOCK 4
-#define EM4305_PROT1_BLOCK 14
-#define EM4305_PROT2_BLOCK 15
-#define EM4469_PROT_BLOCK 3
-
-typedef enum {
-    EM_UNKNOWN,
-    EM_4205,
-    EM_4305,
-    EM_4X69,
-} em_tech_type_t;
-
 // 1 = EM4x69
 // 2 = EM4x05
 static em_tech_type_t em_get_card_type(uint32_t config) {
@@ -133,7 +122,7 @@ static const char *em_get_card_str(uint32_t config) {
 }
 
 // even parity COLUMN
-static bool EM_ColParityTest(uint8_t *bs, size_t size, uint8_t rows, uint8_t cols, uint8_t pType) {
+static bool em4x05_col_parity_test(uint8_t *bs, size_t size, uint8_t rows, uint8_t cols, uint8_t pType) {
     if (rows * cols > size) return false;
     uint8_t colP = 0;
 
@@ -147,14 +136,14 @@ static bool EM_ColParityTest(uint8_t *bs, size_t size, uint8_t rows, uint8_t col
     return true;
 }
 
-#define EM_PREAMBLE_LEN 8
+
 // download samples from device and copy to Graphbuffer
-static bool downloadSamplesEM(void) {
+static bool em4x05_download_samples(void) {
 
     // 8 bit preamble + 32 bit word response (max clock (128) * 40bits = 5120 samples)
     uint8_t got[6000];
     if (!GetFromDevice(BIG_BUF, got, sizeof(got), 0, NULL, 0, NULL, 2500, false)) {
-        PrintAndLogEx(WARNING, "(downloadSamplesEM) command execution time out");
+        PrintAndLogEx(WARNING, "(em_download_samples) command execution time out");
         return false;
     }
 
@@ -273,12 +262,12 @@ static bool detectNRZ(void) {
 }
 
 // param: idx - start index in demoded data.
-static int setDemodBufferEM(uint32_t *word, size_t idx) {
+static int em4x05_setdemod_buffer(uint32_t *word, size_t idx) {
 
     //test for even parity bits.
     uint8_t parity[45] = {0};
     memcpy(parity, DemodBuffer, 45);
-    if (!EM_ColParityTest(DemodBuffer + idx + EM_PREAMBLE_LEN, 45, 5, 9, 0)) {
+    if (!em4x05_col_parity_test(DemodBuffer + idx + EM_PREAMBLE_LEN, 45, 5, 9, 0)) {
         PrintAndLogEx(DEBUG, "DEBUG: Error - End Parity check failed");
         return PM3_ESOFT;
     }
@@ -296,7 +285,7 @@ static int setDemodBufferEM(uint32_t *word, size_t idx) {
 // FSK, PSK, ASK/MANCHESTER, ASK/BIPHASE, ASK/DIPHASE, NRZ
 // should cover 90% of known used configs
 // the rest will need to be manually demoded for now...
-static int demodEM4x05resp(uint32_t *word, bool onlyPreamble) {
+static int em4x05_demod_resp(uint32_t *word, bool onlyPreamble) {
     size_t idx = 0;
     *word = 0;
     bool found_err = false;
@@ -347,21 +336,24 @@ static int demodEM4x05resp(uint32_t *word, bool onlyPreamble) {
         }
         if (found_err)
             return PM3_EFAILED;
+
         return PM3_ESOFT;
     } while (0);
+
     if (onlyPreamble)
         return PM3_SUCCESS;
-    res = setDemodBufferEM(word, idx);
+
+    res = em4x05_setdemod_buffer(word, idx);
     if (res == PM3_SUCCESS)
         return res;
+
     if (found_err)
         return PM3_EFAILED;
     return res;
 }
 
 //////////////// 4205 / 4305 commands
-
-static int EM4x05Login_ext(uint32_t pwd) {
+static int em4x05_login_ext(uint32_t pwd) {
 
     struct {
         uint32_t password;
@@ -373,18 +365,18 @@ static int EM4x05Login_ext(uint32_t pwd) {
     SendCommandNG(CMD_LF_EM4X_LOGIN, (uint8_t *)&payload, sizeof(payload));
     PacketResponseNG resp;
     if (!WaitForResponseTimeout(CMD_LF_EM4X_LOGIN, &resp, 10000)) {
-        PrintAndLogEx(WARNING, "(EM4x05Login_ext) timeout while waiting for reply.");
+        PrintAndLogEx(WARNING, "(em4x05_login_ext) timeout while waiting for reply.");
         return PM3_ETIMEOUT;
     }
 
-    if (downloadSamplesEM() == false) {
+    if (em4x05_download_samples() == false) {
         return PM3_ESOFT;
     }
     uint32_t word;
-    return demodEM4x05resp(&word, true);
+    return em4x05_demod_resp(&word, true);
 }
 
-int EM4x05ReadWord_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word) {
+int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word) {
 
     struct {
         uint32_t password;
@@ -400,21 +392,19 @@ int EM4x05ReadWord_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word)
     SendCommandNG(CMD_LF_EM4X_READWORD, (uint8_t *)&payload, sizeof(payload));
     PacketResponseNG resp;
     if (!WaitForResponseTimeout(CMD_LF_EM4X_READWORD, &resp, 10000)) {
-        PrintAndLogEx(WARNING, "(EM4x05ReadWord_ext) timeout while waiting for reply.");
+        PrintAndLogEx(WARNING, "(em4x05_read_word_ext) timeout while waiting for reply.");
         return PM3_ETIMEOUT;
     }
 
-    if (downloadSamplesEM() == false) {
+    if (em4x05_download_samples() == false) {
         return PM3_ESOFT;
     }
-    return demodEM4x05resp(word, false);
+    return em4x05_demod_resp(word, false);
 }
 
 int CmdEM4x05Demod(const char *Cmd) {
-//    uint8_t ctmp = tolower(param_getchar(Cmd, 0));
-//   if (ctmp == 'h') return usage_lf_em4x05_demod();
     uint32_t dummy = 0;
-    return demodEM4x05resp(&dummy, false);
+    return em4x05_demod_resp(&dummy, false);
 }
 
 int CmdEM4x05Dump(const char *Cmd) {
@@ -458,7 +448,7 @@ int CmdEM4x05Dump(const char *Cmd) {
     uint32_t block0 = 0;
     // read word 0 (chip info)
     // block 0 can be read even without a password.
-    if (EM4x05IsBlock0(&block0) == false)
+    if (em4x05_isblock0(&block0) == false)
         return PM3_ESOFT;
 
     uint8_t bytes[4] = {0};
@@ -481,7 +471,7 @@ int CmdEM4x05Dump(const char *Cmd) {
 
     if (usePwd) {
         // Test first if the password is correct
-        status = EM4x05Login_ext(pwd);
+        status = em4x05_login_ext(pwd);
         if (status == PM3_SUCCESS) {
             PrintAndLogEx(INFO, "Password is " _GREEN_("correct"));
         } else if (status == PM3_EFAILED) {
@@ -502,7 +492,7 @@ int CmdEM4x05Dump(const char *Cmd) {
 
         // To flag any blocks locked we need to read blocks 14 and 15 first
         // dont swap endin until we get block lock flags.
-        status14 = EM4x05ReadWord_ext(EM4305_PROT1_BLOCK, pwd, usePwd, &word);
+        status14 = em4x05_read_word_ext(EM4305_PROT1_BLOCK, pwd, usePwd, &word);
         if (status14 == PM3_SUCCESS) {
             if ((word & 0x00008000) != 0x00) {
                 lock_bits = word;
@@ -512,7 +502,7 @@ int CmdEM4x05Dump(const char *Cmd) {
         } else {
             success = PM3_ESOFT; // If any error ensure fail is set so not to save invalid data
         }
-        status15 = EM4x05ReadWord_ext(EM4305_PROT2_BLOCK, pwd, usePwd, &word);
+        status15 = em4x05_read_word_ext(EM4305_PROT2_BLOCK, pwd, usePwd, &word);
         if (status15 == PM3_SUCCESS) {
             if ((word & 0x00008000) != 0x00) { // assume block 15 is the current lock block
                 lock_bits = word;
@@ -537,8 +527,8 @@ int CmdEM4x05Dump(const char *Cmd) {
                     PrintAndLogEx(INFO, "  %02u |          |       |   | %-10s " _YELLOW_("write only"), addr, info[addr]);
                 }
             } else {
-                // success &= EM4x05ReadWord_ext(addr, pwd, usePwd, &word);
-                status = EM4x05ReadWord_ext(addr, pwd, usePwd, &word); // Get status for single read
+                // success &= em4x05_read_word_ext(addr, pwd, usePwd, &word);
+                status = em4x05_read_word_ext(addr, pwd, usePwd, &word); // Get status for single read
                 if (status != PM3_SUCCESS)
                     success = PM3_ESOFT; // If any error ensure fail is set so not to save invalid data
                 data[addr] = BSWAP_32(word);
@@ -573,7 +563,7 @@ int CmdEM4x05Dump(const char *Cmd) {
 
         // To flag any blocks locked we need to read blocks 14 and 15 first
         // dont swap endin until we get block lock flags.
-        status14 = EM4x05ReadWord_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word);
+        status14 = em4x05_read_word_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word);
         if (status14 == PM3_SUCCESS) {
             if ((word & 0x00008000) != 0x00) {
                 lock_bits = word;
@@ -599,7 +589,7 @@ int CmdEM4x05Dump(const char *Cmd) {
                 }
             } else {
 
-                status = EM4x05ReadWord_ext(addr, pwd, usePwd, &word);
+                status = em4x05_read_word_ext(addr, pwd, usePwd, &word);
                 if (status != PM3_SUCCESS) {
                     success = PM3_ESOFT; // If any error ensure fail is set so not to save invalid data
                 }
@@ -662,7 +652,7 @@ int CmdEM4x05Read(const char *Cmd) {
     }
 
     uint32_t word = 0;
-    int status = EM4x05ReadWord_ext(addr, pwd, usePwd, &word);
+    int status = em4x05_read_word_ext(addr, pwd, usePwd, &word);
     if (status == PM3_SUCCESS)
         PrintAndLogEx(SUCCESS, "Address %02d | %08X - %s", addr, word, (addr > 13) ? "Lock" : "");
     else if (status == PM3_EFAILED)
@@ -741,11 +731,11 @@ int CmdEM4x05Write(const char *Cmd) {
             return PM3_ETIMEOUT;
         }
     }
-    if (!downloadSamplesEM())
+    if (em4x05_download_samples() == false)
         return PM3_ENODATA;
 
     uint32_t dummy = 0;
-    int status = demodEM4x05resp(&dummy, true);
+    int status = em4x05_demod_resp(&dummy, true);
     if (status == PM3_SUCCESS)
         PrintAndLogEx(SUCCESS, "Success writing to tag");
     else if (status == PM3_EFAILED)
@@ -1000,8 +990,8 @@ static void printEM4x05ProtectionBits(uint32_t word, uint8_t addr) {
 }
 
 //quick test for EM4x05/EM4x69 tag
-bool EM4x05IsBlock0(uint32_t *word) {
-    return (EM4x05ReadWord_ext(0, 0, false, word) == PM3_SUCCESS);
+bool em4x05_isblock0(uint32_t *word) {
+    return (em4x05_read_word_ext(0, 0, false, word) == PM3_SUCCESS);
 }
 
 int CmdEM4x05Info(const char *Cmd) {
@@ -1019,7 +1009,7 @@ int CmdEM4x05Info(const char *Cmd) {
 
     // read word 0 (chip info)
     // block 0 can be read even without a password.
-    if (EM4x05IsBlock0(&block0) == false)
+    if (em4x05_isblock0(&block0) == false)
         return PM3_ESOFT;
 
     // based on Block0 ,  decide type.
@@ -1027,13 +1017,13 @@ int CmdEM4x05Info(const char *Cmd) {
 
     // read word 1 (serial #) doesn't need pwd
     // continue if failed, .. non blocking fail.
-    EM4x05ReadWord_ext(EM_SERIAL_BLOCK, 0, false, &serial);
+    em4x05_read_word_ext(EM_SERIAL_BLOCK, 0, false, &serial);
 
     printEM4x05info(block0, serial);
 
     // read word 4 (config block)
     // needs password if one is set
-    if (EM4x05ReadWord_ext(EM_CONFIG_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS)
+    if (em4x05_read_word_ext(EM_CONFIG_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS)
         return PM3_ESOFT;
 
     printEM4x05config(word);
@@ -1043,7 +1033,7 @@ int CmdEM4x05Info(const char *Cmd) {
     if (card_type == EM_4205 || card_type == EM_4305) {
 
         // read word 14 and 15 to see which is being used for the protection bits
-        if (EM4x05ReadWord_ext(EM4305_PROT1_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS) {
+        if (em4x05_read_word_ext(EM4305_PROT1_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS) {
             return PM3_ESOFT;
         }
 
@@ -1051,7 +1041,7 @@ int CmdEM4x05Info(const char *Cmd) {
             printEM4x05ProtectionBits(word, EM4305_PROT1_BLOCK);
             return PM3_SUCCESS;
         } else { // if status bit says this is not the used protection word
-            if (EM4x05ReadWord_ext(EM4305_PROT2_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS)
+            if (em4x05_read_word_ext(EM4305_PROT2_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS)
                 return PM3_ESOFT;
             if (word & 0x8000) {
                 printEM4x05ProtectionBits(word, EM4305_PROT2_BLOCK);
@@ -1060,7 +1050,7 @@ int CmdEM4x05Info(const char *Cmd) {
         }
     } else if (card_type == EM_4X69) {
         // read word 3 to see which is being used for the protection bits
-        if (EM4x05ReadWord_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS) {
+        if (em4x05_read_word_ext(EM4469_PROT_BLOCK, pwd, usePwd, &word) != PM3_SUCCESS) {
             return PM3_ESOFT;
         }
         printEM4x05ProtectionBits(word, EM4469_PROT_BLOCK);
@@ -1114,7 +1104,7 @@ int CmdEM4x05Chk(const char *Cmd) {
         uint32_t pwd = lf_t55xx_white_pwdgen(card_id & 0xFFFFFFFF);
         PrintAndLogEx(INFO, "testing %08"PRIX32" generated ", pwd);
 
-        int status = EM4x05Login_ext(pwd);
+        int status = em4x05_login_ext(pwd);
         if (status == PM3_SUCCESS) {
             PrintAndLogEx(SUCCESS, "found valid password [ " _GREEN_("%08"PRIX32) " ]", pwd);
             found = true;
@@ -1157,7 +1147,7 @@ int CmdEM4x05Chk(const char *Cmd) {
 
             PrintAndLogEx(INFO, "testing %08"PRIX32, curr_password);
 
-            int status = EM4x05Login_ext(curr_password);
+            int status = em4x05_login_ext(curr_password);
             if (status == PM3_SUCCESS) {
                 PrintAndLogEx(SUCCESS, "found valid password [ " _GREEN_("%08"PRIX32) " ]", curr_password);
                 found = true;
@@ -1245,11 +1235,11 @@ static int unlock_write_protect(bool use_pwd, uint32_t pwd, uint32_t data, bool
         return PM3_ETIMEOUT;
     }
 
-    if (!downloadSamplesEM())
+    if (em4x05_download_samples() == false)
         return PM3_ENODATA;
 
     uint32_t dummy = 0;
-    int status = demodEM4x05resp(&dummy, true);
+    int status = em4x05_demod_resp(&dummy, true);
     if (status == PM3_SUCCESS && verbose)
         PrintAndLogEx(SUCCESS, "Success writing to tag");
     else if (status == PM3_EFAILED)
@@ -1332,7 +1322,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
     //
     // read word 14
     uint32_t init_14 = 0;
-    int res = EM4x05ReadWord_ext(14, pwd, use_pwd, &init_14);
+    int res = em4x05_read_word_ext(14, pwd, use_pwd, &init_14);
     if (res != PM3_SUCCESS) {
         PrintAndLogEx(FAILED, "failed to read word 14\n");
         return PM3_ENODATA;
@@ -1341,7 +1331,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
     // read 15
     uint32_t init_15 = 0;
-    res = EM4x05ReadWord_ext(15, pwd, use_pwd, &init_15);
+    res = em4x05_read_word_ext(15, pwd, use_pwd, &init_15);
     if (res != PM3_SUCCESS) {
         PrintAndLogEx(FAILED, "failed to read word 15\n");
         return PM3_ENODATA;
@@ -1457,14 +1447,14 @@ int CmdEM4x05Unlock(const char *Cmd) {
         res = unlock_write_protect(use_pwd, pwd, write_value, verbose);
 
         // read after trigger
-        res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14);
+        res = em4x05_read_word_ext(14, pwd, use_pwd, &word14);
         if (res != PM3_SUCCESS) {
             PrintAndLogEx(WARNING, "failed to read 14");
             return PM3_ESOFT;
         }
 
         // read after trigger
-        res = EM4x05ReadWord_ext(15, pwd, use_pwd, &word15);
+        res = em4x05_read_word_ext(15, pwd, use_pwd, &word15);
         if (res != PM3_SUCCESS) {
             PrintAndLogEx(WARNING, "failed to read 15");
             return PM3_ESOFT;
@@ -1500,7 +1490,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
                 unlock_reset(use_pwd, pwd, write_value, verbose);
 
                 // read after reset
-                res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14b);
+                res = em4x05_read_word_ext(14, pwd, use_pwd, &word14b);
                 if (res != PM3_SUCCESS) {
                     PrintAndLogEx(WARNING, "failed to read 14");
                     return PM3_ESOFT;
@@ -1510,7 +1500,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
                     unlock_reset(use_pwd, pwd, write_value, verbose);
 
-                    res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14b);
+                    res = em4x05_read_word_ext(14, pwd, use_pwd, &word14b);
                     if (res != PM3_SUCCESS) {
                         PrintAndLogEx(WARNING, "failed to read 14");
                         return PM3_ESOFT;
@@ -1519,7 +1509,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
 
                 if (word14b != search_value) {
 
-                    res = EM4x05ReadWord_ext(15, pwd, use_pwd, &word15b);
+                    res = em4x05_read_word_ext(15, pwd, use_pwd, &word15b);
                     if (res == PM3_SUCCESS) {
                         PrintAndLogEx(INFO, "Status: new definitive value!       => " _RED_("SUCCESS:") " 14: " _CYAN_("%08X") "  15: %08X", word14b, word15b);
                         success = true;
@@ -1548,13 +1538,13 @@ int CmdEM4x05Unlock(const char *Cmd) {
                     unlock_reset(use_pwd, pwd, write_value, verbose);
 
                     // read after reset
-                    res = EM4x05ReadWord_ext(14, pwd, use_pwd, &word14b);
+                    res = em4x05_read_word_ext(14, pwd, use_pwd, &word14b);
                     if (res != PM3_SUCCESS) {
                         PrintAndLogEx(WARNING, "failed to read 14");
                         return PM3_ESOFT;
                     }
 
-                    res = EM4x05ReadWord_ext(15, pwd, use_pwd, &word15b);
+                    res = em4x05_read_word_ext(15, pwd, use_pwd, &word15b);
                     if (res != PM3_SUCCESS) {
                         PrintAndLogEx(WARNING, "failed to read 15");
                         return PM3_ESOFT;
@@ -1566,7 +1556,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
                     if ((word14b & ACTIVE_MASK) == ACTIVE_MASK) {
 
                         if (word14b == word15) {
-                            PrintAndLogEx(INFO, "Status: confirmed                   => " _RED_("SUCCESS:   ") "14: " _CYAN_("%08X") "  15: %08X", word14b, word15b);
+                            PrintAndLogEx(INFO, "Status: confirmed                   => " _GREEN_("SUCCESS:   ") "14: " _GREEN_("%08X") "  15: %08X", word14b, word15b);
 
                             unlock_add_item(flipped, 64, word14b);
                             success = true;
@@ -1640,8 +1630,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
     return exit_code;
 }
 
-static size_t em4x05_Sniff_GetNextBitStart (size_t idx, size_t sc, int *data, size_t *pulsesamples)
-{
+static size_t em4x05_Sniff_GetNextBitStart (size_t idx, size_t sc, int *data, size_t *pulsesamples) {
     while ((idx < sc) && (data[idx] <= 10)) // find a going high
         idx++;
 
diff --git a/client/src/cmdlfem4x05.h b/client/src/cmdlfem4x05.h
index f6e05c518..3c981d09c 100644
--- a/client/src/cmdlfem4x05.h
+++ b/client/src/cmdlfem4x05.h
@@ -13,11 +13,43 @@
 
 #include "common.h"
 
+
+#define EM_SERIAL_BLOCK 1
+#define EM_CONFIG_BLOCK 4
+#define EM4305_PROT1_BLOCK 14
+#define EM4305_PROT2_BLOCK 15
+#define EM4469_PROT_BLOCK 3
+
+
+#define EM4305_INFO_BLOCK          0x00
+#define EM4305_UID_BLOCK           0x01
+#define EM4305_PWD_BLOCK           0x02
+#define EM4305_CONFIGURATION_BLOCK 0x04
+
+
+// config blocks
+#define EM4305_DEFAULT_CONFIG_BLOCK      0x0002008F  // ASK/ BIPHASE , data rate 32, 4 data blocks
+
+#define EM4305_EM_UNIQUE_CONFIG_BLOCK    0x0001805F  // ASK, EM4x02/unique - manchester, data rate 64, 2 data blocks
+#define EM4305_PAXTON_CONFIG_BLOCK       0x0001805F  // ASK, EM4x02/paxton - manchester, data rate 64, 2 data blocks
+#define EM4305_VISA2000_CONFIG_BLOCK     0x0001805F  // ASK, data rate 64, 3 data blocks
+#define EM4305_VIKING_CONFIG_BLOCK       0x0001805F  // ASK, data rate 32, Manchester, 2 data blocks
+#define EM4305_NORALSY_CONFIG_BLOCK      0x0001805F  // ASK, data rate 32, 3 data blocks
+#define EM4305_PRESCO_CONFIG_BLOCK       0x0001805F  // ASK, data rate 32, Manchester, 4 data blocks
+#define EM4305_SECURAKEY_CONFIG_BLOCK    0x0001805F  // ASK, Manchester, data rate 40, 3 data blocks
+
+
+typedef enum {
+    EM_UNKNOWN,
+    EM_4205,
+    EM_4305,
+    EM_4X69,
+} em_tech_type_t;
+
 int CmdLFEM4X05(const char *Cmd);
 
-bool EM4x05IsBlock0(uint32_t *word);
-int EM4x05ReadWord_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word);
-
+bool em4x05_isblock0(uint32_t *word);
+int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word);
 
 int CmdEM4x05Demod(const char *Cmd);
 int CmdEM4x05Dump(const char *Cmd);

From 2479b54eb9d86a8603118ba4874b12cf66b34552 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 22:22:21 +0200
Subject: [PATCH 28/35] forgot

---
 client/src/scripting.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/scripting.c b/client/src/scripting.c
index 4c9e3686f..c1f457da8 100644
--- a/client/src/scripting.c
+++ b/client/src/scripting.c
@@ -1121,7 +1121,7 @@ static int l_em4x05_read(lua_State *L) {
         PrintAndLogEx(DEBUG, " Pwd %08X", password);
 
     uint32_t word = 0;
-    int res = EM4x05ReadWord_ext(addr, password, use_pwd, &word);
+    int res = em4x05_read_word_ext(addr, password, use_pwd, &word);
     if (res != PM3_SUCCESS) {
         return returnToLuaWithError(L, "Failed to read EM4x05 data");
     }

From 527d1c944256aa5a3cafd13664334065f205c321 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Tue, 20 Oct 2020 23:10:34 +0200
Subject: [PATCH 29/35] all prepped for EM4x05 to be used with clone commands

---
 client/src/cmdlfem4x05.c | 44 ++++++++++++++++++++++-----------------
 client/src/cmdlfem4x05.h | 45 ++++++++++++++++++++++++++--------------
 include/protocols.h      | 14 ++++++-------
 3 files changed, 61 insertions(+), 42 deletions(-)

diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 993a4a09d..2da553be8 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -402,6 +402,29 @@ int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word
     return em4x05_demod_resp(word, false);
 }
 
+int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t data) {
+    struct {
+        uint32_t password;
+        uint32_t data;
+        uint8_t address;
+        uint8_t usepwd;
+    } PACKED payload;
+
+    payload.password = pwd;
+    payload.data = data;
+    payload.address = addr;
+    payload.usepwd = usePwd;
+
+    clearCommandBuffer();
+    SendCommandNG(CMD_LF_EM4X_WRITEWORD, (uint8_t *)&payload, sizeof(payload));
+    PacketResponseNG resp;
+    if (!WaitForResponseTimeout(CMD_LF_EM4X_WRITEWORD, &resp, 2000)) {
+        PrintAndLogEx(ERR, "Error occurred, device did not respond during write operation.");
+        return PM3_ETIMEOUT;
+    }
+    return PM3_SUCCESS;
+}
+
 int CmdEM4x05Demod(const char *Cmd) {
     uint32_t dummy = 0;
     return em4x05_demod_resp(&dummy, false);
@@ -711,26 +734,9 @@ int CmdEM4x05Write(const char *Cmd) {
             return PM3_ETIMEOUT;
         }
     } else {
-        struct {
-            uint32_t password;
-            uint32_t data;
-            uint8_t address;
-            uint8_t usepwd;
-        } PACKED payload;
-
-        payload.password = pwd;
-        payload.data = data;
-        payload.address = addr;
-        payload.usepwd = usePwd;
-
-        clearCommandBuffer();
-        SendCommandNG(CMD_LF_EM4X_WRITEWORD, (uint8_t *)&payload, sizeof(payload));
-        PacketResponseNG resp;
-        if (!WaitForResponseTimeout(CMD_LF_EM4X_WRITEWORD, &resp, 2000)) {
-            PrintAndLogEx(ERR, "Error occurred, device did not respond during write operation.");
-            return PM3_ETIMEOUT;
-        }
+        em4x05_write_word_ext(addr, pwd, usePwd, data);
     }
+
     if (em4x05_download_samples() == false)
         return PM3_ENODATA;
 
diff --git a/client/src/cmdlfem4x05.h b/client/src/cmdlfem4x05.h
index 3c981d09c..c8c19a6ff 100644
--- a/client/src/cmdlfem4x05.h
+++ b/client/src/cmdlfem4x05.h
@@ -13,31 +13,43 @@
 
 #include "common.h"
 
-
 #define EM_SERIAL_BLOCK 1
 #define EM_CONFIG_BLOCK 4
 #define EM4305_PROT1_BLOCK 14
 #define EM4305_PROT2_BLOCK 15
 #define EM4469_PROT_BLOCK 3
 
-
-#define EM4305_INFO_BLOCK          0x00
-#define EM4305_UID_BLOCK           0x01
-#define EM4305_PWD_BLOCK           0x02
-#define EM4305_CONFIGURATION_BLOCK 0x04
-
-
 // config blocks
-#define EM4305_DEFAULT_CONFIG_BLOCK      0x0002008F  // ASK/ BIPHASE , data rate 32, 4 data blocks
+#define EM4305_DEFAULT_CONFIG_BLOCK      (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(4) ) // ASK/MAN , data rate 32, 4 data blocks
+//#define EM4305_DEFAULT_CONFIG_BLOCK    (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_BIPHASE | EM4x05_SET_NUM_BLOCKS(4) ) // ASK/BIPHASE , data rate 32, 4 data blocks
 
-#define EM4305_EM_UNIQUE_CONFIG_BLOCK    0x0001805F  // ASK, EM4x02/unique - manchester, data rate 64, 2 data blocks
-#define EM4305_PAXTON_CONFIG_BLOCK       0x0001805F  // ASK, EM4x02/paxton - manchester, data rate 64, 2 data blocks
-#define EM4305_VISA2000_CONFIG_BLOCK     0x0001805F  // ASK, data rate 64, 3 data blocks
-#define EM4305_VIKING_CONFIG_BLOCK       0x0001805F  // ASK, data rate 32, Manchester, 2 data blocks
-#define EM4305_NORALSY_CONFIG_BLOCK      0x0001805F  // ASK, data rate 32, 3 data blocks
-#define EM4305_PRESCO_CONFIG_BLOCK       0x0001805F  // ASK, data rate 32, Manchester, 4 data blocks
-#define EM4305_SECURAKEY_CONFIG_BLOCK    0x0001805F  // ASK, Manchester, data rate 40, 3 data blocks
+#define EM4305_EM_UNIQUE_CONFIG_BLOCK    (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(2) ) // ASK/MAN, EM4x02/unique - data rate 64, 2 data blocks
+#define EM4305_PAXTON_CONFIG_BLOCK       (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(2) ) // ASK/MAN, EM4x02/paxton - data rate 64, 2 data blocks
+#define EM4305_VISA2000_CONFIG_BLOCK     (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(3) ) // ASK, data rate 64, 3 data blocks
+#define EM4305_VIKING_CONFIG_BLOCK       (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(2) ) // ASK/MAN, data rate 32, 2 data blocks
+#define EM4305_NORALSY_CONFIG_BLOCK      (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(3) ) // ASK, data rate 32, 3 data blocks
+#define EM4305_PRESCO_CONFIG_BLOCK       (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(4) ) // ASK/MAN, data rate 32, 4 data blocks
+#define EM4305_SECURAKEY_CONFIG_BLOCK    (EM4x05_SET_BITRATE(40) | EM4x05_MODULATION_MANCHESTER | EM4x05_SET_NUM_BLOCKS(3) ) // ASK/MAN, data rate 40, 3 data blocks
 
+#define EM4305_HID_26_CONFIG_BLOCK       (EM4x05_SET_BITRATE(50) | EM4x05_MODULATION_FSK2 | EM4x05_SET_NUM_BLOCKS(3) ) // FSK2a, hid 26 bit, data rate 50, 3 data blocks
+#define EM4305_PARADOX_CONFIG_BLOCK      (EM4x05_SET_BITRATE(50) | EM4x05_MODULATION_FSK2 | EM4x05_SET_NUM_BLOCKS(3) ) // FSK2a, hid 26 bit, data rate 50, 3 data blocks
+#define EM4305_AWID_CONFIG_BLOCK         (EM4x05_SET_BITRATE(50) | EM4x05_MODULATION_FSK2 | EM4x05_SET_NUM_BLOCKS(3) ) // FSK2a, hid 26 bit, data rate 50, 3 data blocks
+#define EM4305_PYRAMID_CONFIG_BLOCK      (EM4x05_SET_BITRATE(50) | EM4x05_MODULATION_FSK2 | EM4x05_SET_NUM_BLOCKS(4) ) // FSK2a, Pyramid 26 bit, data rate 50, 4 data blocks
+#define EM4305_IOPROX_CONFIG_BLOCK       (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_FSK2 | EM4x05_SET_NUM_BLOCKS(2) ) // FSK2a, data rate 64, 2 data blocks
+
+#define EM4305_INDALA_64_CONFIG_BLOCK    (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_PSK1 | EM4x05_PSK_RF_2 | EM4x05_SET_NUM_BLOCKS(2) ) // PSK1, indala 64 bit, psk carrier FC * 2, data rate 32, maxblock 2
+#define EM4305_INDALA_224_CONFIG_BLOCK   (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_PSK1 | EM4x05_PSK_RF_2 | EM4x05_SET_NUM_BLOCKS(7) ) // PSK1, indala 224 bit, psk carrier FC * 2, data rate 32, maxblock 7
+#define EM4305_MOTOROLA_CONFIG_BLOCK     (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_PSK1 | EM4x05_PSK_RF_2 | EM4x05_SET_NUM_BLOCKS(2) ) // PSK1, data rate 32, 2 data blocks
+#define EM4305_NEXWATCH_CONFIG_BLOCK     (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_PSK1 | EM4x05_PSK_RF_2 | EM4x05_SET_NUM_BLOCKS(3) ) // PSK1 data rate 16, psk carrier FC * 2, 3 data blocks
+#define EM4305_KERI_CONFIG_BLOCK         (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_PSK1 | EM4x05_PSK_RF_2 | EM4x05_SET_NUM_BLOCKS(2) ) // PSK1, 2 data blocks
+
+#define EM4305_JABLOTRON_CONFIG_BLOCK    (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_BIPHASE | EM4x05_SET_NUM_BLOCKS(2) ) // Biphase, data rate 64, 2 data blocks
+#define EM4305_GUARDPROXII_CONFIG_BLOCK  (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_BIPHASE | EM4x05_SET_NUM_BLOCKS(3) ) // Biphase, data rate 64, Direct modulation, 3 data blocks
+#define EM4305_NEDAP_64_CONFIG_BLOCK     (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_BIPHASE | EM4x05_SET_NUM_BLOCKS(2) ) // Biphase, data rate 64, 2 data blocks
+#define EM4305_NEDAP_128_CONFIG_BLOCK    (EM4x05_SET_BITRATE(64) | EM4x05_MODULATION_BIPHASE | EM4x05_SET_NUM_BLOCKS(4) ) // Biphase, data rate 64, 4 data blocks
+
+#define EM4305_PAC_CONFIG_BLOCK          (EM4x05_SET_BITRATE(32) | EM4x05_MODULATION_NRZ | EM4x05_SET_NUM_BLOCKS(4) )  // NRZ, data rate 32, 4 data blocks
+#define EM4305_VERICHIP_CONFIG_BLOCK     (EM4x05_SET_BITRATE(40) | EM4x05_MODULATION_NRZ | EM4x05_SET_NUM_BLOCKS(4) )  // NRZ, data rate 40, 4 data blocks
 
 typedef enum {
     EM_UNKNOWN,
@@ -50,6 +62,7 @@ int CmdLFEM4X05(const char *Cmd);
 
 bool em4x05_isblock0(uint32_t *word);
 int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word);
+int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t data);
 
 int CmdEM4x05Demod(const char *Cmd);
 int CmdEM4x05Dump(const char *Cmd);
diff --git a/include/protocols.h b/include/protocols.h
index d2af15647..bb520a71f 100644
--- a/include/protocols.h
+++ b/include/protocols.h
@@ -559,13 +559,13 @@ ISO 7816-4 Basic interindustry commands. For command APDU's.
 #define EM4x05_FIRST_USER_BLOCK         5
 #define EM4x05_SET_NUM_BLOCKS(x)        ((x+5-1)<<14) //# of blocks sent during default read mode
 #define EM4x05_GET_NUM_BLOCKS(x)        (((x>>14) & 0xF)-5+1)
-#define EM4x05_READ_LOGIN_REQ           1<<18
-#define EM4x05_READ_HK_LOGIN_REQ        1<<19
-#define EM4x05_WRITE_LOGIN_REQ          1<<20
-#define EM4x05_WRITE_HK_LOGIN_REQ       1<<21
-#define EM4x05_READ_AFTER_WRITE         1<<22
-#define EM4x05_DISABLE_ALLOWED          1<<23
-#define EM4x05_READER_TALK_FIRST        1<<24
+#define EM4x05_READ_LOGIN_REQ           (1 << 18)
+#define EM4x05_READ_HK_LOGIN_REQ        (1 << 19)
+#define EM4x05_WRITE_LOGIN_REQ          (1 << 20)
+#define EM4x05_WRITE_HK_LOGIN_REQ       (1 << 21)
+#define EM4x05_READ_AFTER_WRITE         (1 << 22)
+#define EM4x05_DISABLE_ALLOWED          (1 << 23)
+#define EM4x05_READER_TALK_FIRST        (1 << 24)
 
 
 // FeliCa protocol

From 50c0d93951f8cf5ec882519fe82471127b9d8e0f Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Tue, 20 Oct 2020 23:49:03 +0200
Subject: [PATCH 30/35] Change EM4x05 reader timings Closer to the spec and
 better results, more robust to tag position

---
 armsrc/lfops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/armsrc/lfops.c b/armsrc/lfops.c
index f52bdd788..a6fbb7bba 100644
--- a/armsrc/lfops.c
+++ b/armsrc/lfops.c
@@ -2497,7 +2497,7 @@ static void SendForward(uint8_t fwd_bit_count, bool fast) {
             WaitUS(32 * 8);
         } else {
             TurnReadLF_off(23 * 8);
-            TurnReadLFOn((32 - 23) * 8);
+            TurnReadLFOn(18 * 8);
         }
     }
 }

From 0ccbd6e0fbd0f6d6e392cc4216ea3a856ee2d64e Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Wed, 21 Oct 2020 00:37:36 +0200
Subject: [PATCH 31/35] just for testing,  lf keri clone , now has experimental
 support for EM4305

---
 client/src/cmdlfem4x05.c | 68 +++++++++++++++++++++++++++++++++++++---
 client/src/cmdlfem4x05.h |  5 +--
 client/src/cmdlfkeri.c   | 35 +++++++++++++++------
 3 files changed, 92 insertions(+), 16 deletions(-)

diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index 2da553be8..fed515b37 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -352,7 +352,67 @@ static int em4x05_demod_resp(uint32_t *word, bool onlyPreamble) {
     return res;
 }
 
+
 //////////////// 4205 / 4305 commands
+
+static bool em4x05_verify_write(uint8_t addr, uint32_t pwd, bool use_pwd, uint32_t data) {
+    uint32_t r = 0;
+    int res = em4x05_read_word_ext(addr, pwd, use_pwd, &r);
+    if (res == PM3_SUCCESS) {
+        return (r == data);
+    }    
+    return false;
+}
+
+int em4x05_clone_tag(uint32_t *blockdata, uint8_t numblocks, uint32_t pwd, bool use_pwd) {
+
+    if (blockdata == NULL)
+        return PM3_EINVARG;
+
+    if (numblocks < 1 || numblocks > 8)
+        return PM3_EINVARG;
+
+    // fast push mode
+    conn.block_after_ACK = true;
+
+    int res = em4x05_write_word_ext(EM_CONFIG_BLOCK, pwd, use_pwd, blockdata[0]);
+    if (res != PM3_SUCCESS) {
+        PrintAndLogEx(FAILED, "(em4x05_clone_tag) Time out writing to tag");
+        return res;
+    }
+
+    for (int8_t i = 1; i < numblocks; i++) {
+
+        // Disable fast mode on last packet
+        if (i == numblocks - 1) {
+            conn.block_after_ACK = false;
+        }
+
+        res = em4x05_write_word_ext(4 + i, pwd, use_pwd, blockdata[i]);
+        if (res != PM3_SUCCESS) {
+            PrintAndLogEx(FAILED, "(em4x05_clone_tag) Time out writing to tag");
+            return res;
+        }
+    }
+
+    res = 0;
+    if (em4x05_verify_write(EM_CONFIG_BLOCK, use_pwd, pwd, blockdata[0]) == false) {
+        res++;
+    }
+    
+    for (int8_t i = 1; i < numblocks; i++) {
+        if (em4x05_verify_write(4 + i, use_pwd, pwd, blockdata[i]) == false) {
+            res++;
+        }
+    }
+
+    if (res == 0) {
+        PrintAndLogEx(SUCCESS, "Success writing to tag");
+    }
+
+    return PM3_SUCCESS;
+}
+
 static int em4x05_login_ext(uint32_t pwd) {
 
     struct {
@@ -376,7 +436,7 @@ static int em4x05_login_ext(uint32_t pwd) {
     return em4x05_demod_resp(&word, true);
 }
 
-int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word) {
+int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool use_pwd, uint32_t *word) {
 
     struct {
         uint32_t password;
@@ -386,7 +446,7 @@ int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word
 
     payload.password = pwd;
     payload.address = addr;
-    payload.usepwd = usePwd;
+    payload.usepwd = use_pwd;
 
     clearCommandBuffer();
     SendCommandNG(CMD_LF_EM4X_READWORD, (uint8_t *)&payload, sizeof(payload));
@@ -402,7 +462,7 @@ int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word
     return em4x05_demod_resp(word, false);
 }
 
-int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t data) {
+int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool use_pwd, uint32_t data) {
     struct {
         uint32_t password;
         uint32_t data;
@@ -413,7 +473,7 @@ int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t data
     payload.password = pwd;
     payload.data = data;
     payload.address = addr;
-    payload.usepwd = usePwd;
+    payload.usepwd = use_pwd;
 
     clearCommandBuffer();
     SendCommandNG(CMD_LF_EM4X_WRITEWORD, (uint8_t *)&payload, sizeof(payload));
diff --git a/client/src/cmdlfem4x05.h b/client/src/cmdlfem4x05.h
index c8c19a6ff..cf8d35d20 100644
--- a/client/src/cmdlfem4x05.h
+++ b/client/src/cmdlfem4x05.h
@@ -61,8 +61,9 @@ typedef enum {
 int CmdLFEM4X05(const char *Cmd);
 
 bool em4x05_isblock0(uint32_t *word);
-int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t *word);
-int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool usePwd, uint32_t data);
+int em4x05_read_word_ext(uint8_t addr, uint32_t pwd, bool use_pwd, uint32_t *word);
+int em4x05_write_word_ext(uint8_t addr, uint32_t pwd, bool use_pwd, uint32_t data);
+int em4x05_clone_tag(uint32_t *blockdata, uint8_t numblocks, uint32_t pwd, bool use_pwd);
 
 int CmdEM4x05Demod(const char *Cmd);
 int CmdEM4x05Dump(const char *Cmd);
diff --git a/client/src/cmdlfkeri.c b/client/src/cmdlfkeri.c
index 396a4a79f..7260bc494 100644
--- a/client/src/cmdlfkeri.c
+++ b/client/src/cmdlfkeri.c
@@ -8,23 +8,21 @@
 // PSK1, RF/128, RF/2, 64 bits long
 //-----------------------------------------------------------------------------
 #include "cmdlfkeri.h"
-
 #include <string.h>
 #include <inttypes.h>
-
 #include <ctype.h>
 #include <stdlib.h>
-
-#include "commonutil.h"     // ARRAYLEN
+#include "commonutil.h"   // ARRAYLEN
 #include "cmdparser.h"    // command_t
 #include "cliparser.h"
 #include "comms.h"
 #include "ui.h"
 #include "cmddata.h"
 #include "cmdlf.h"
-#include "protocols.h"  // for T55xx config register definitions
-#include "lfdemod.h"    // preamble test
-#include "cmdlft55xx.h" // verifywrite
+#include "protocols.h"    // for T55xx config register definitions
+#include "lfdemod.h"      // preamble test
+#include "cmdlft55xx.h"   // verifywrite
+#include "cmdlfem4x05.h"  // 
 
 static int CmdHelp(const char *Cmd);
 typedef enum  {Scramble = 0, Descramble = 1} KeriMSScramble_t;
@@ -185,7 +183,7 @@ static int CmdKeriRead(const char *Cmd) {
 
 static int CmdKeriClone(const char *Cmd) {
 
-    bool q5 = false;
+    bool q5 = false, em4305 = false;
 
     uint8_t keritype[2] = {'i'}; // default to internalid
     int typeLen = 0;
@@ -207,7 +205,7 @@ static int CmdKeriClone(const char *Cmd) {
 
     CLIParserContext *ctx;
     CLIParserInit(&ctx, "lf keri clone",
-                  "clone a KERI tag to a T55x7 or Q5/T5555 tag",
+                  "clone a KERI tag to a T55x7, Q5/T5555 or EM4305 tag",
                   "lf keri clone -t i --id 12345\n"
                   "lf keri clone -t m --fc 6 --id 12345\n");
 
@@ -217,6 +215,7 @@ static int CmdKeriClone(const char *Cmd) {
         arg_str0("t",  "type", "<m|i>", "Type m - MS, i - Internal ID"),
         arg_int0(NULL, "fc",   "<dec>", "Facility Code"),
         arg_int1(NULL, "id",   "<dec>", "Keri ID"),
+        arg_lit0(NULL,  "em4305",       "specify writing to EM5405 tag"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, false);
@@ -225,12 +224,22 @@ static int CmdKeriClone(const char *Cmd) {
         blocks[0] = T5555_FIXED | T5555_MODULATION_PSK1 | T5555_SET_BITRATE(32) | T5555_PSK_RF_2 | 2 << T5555_MAXBLOCK_SHIFT;
         q5 = true;
     }
+    if (arg_get_lit(ctx, 5)) {
+        blocks[0] = EM4305_KERI_CONFIG_BLOCK;        
+        em4305 = true;
+    }
+
     typeLen = sizeof(keritype);
     CLIGetStrWithReturn(ctx, 2, keritype, &typeLen);
 
     fc = arg_get_int_def(ctx, 3, 0);
     cid = arg_get_int_def(ctx, 4, 0);
     CLIParserFree(ctx);
+    
+    if (q5 && em4305) {
+        PrintAndLogEx(FAILED, "Can't specify both Q5 and EM4305 at the same time");
+        return PM3_EINVARG;
+    }
 
     // Setup card data/build internal id
     switch (keritype[0]) {
@@ -256,7 +265,13 @@ static int CmdKeriClone(const char *Cmd) {
 
     print_blocks(blocks,  ARRAYLEN(blocks));
 
-    int res = clone_t55xx_tag(blocks, ARRAYLEN(blocks));
+    int res;
+    if (em4305) {
+        res = em4x05_clone_tag(blocks, ARRAYLEN(blocks), 0, false);
+    } else {
+        res = clone_t55xx_tag(blocks, ARRAYLEN(blocks));
+    }
+    
     PrintAndLogEx(SUCCESS, "Done");
     PrintAndLogEx(HINT, "Hint: try " _YELLOW_("`lf keri read`") " to verify");
     return res;

From be8d2fbd255d8ce5be252f186b5c942506ba291b Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Wed, 21 Oct 2020 08:42:33 +0200
Subject: [PATCH 32/35] add u64_from_hex,  no need to use 0x,  thanks
 @mwalker33!\n reverse blocks when cloning for em4305/4469

---
 client/deps/cliparser/cliparser.c | 23 ++++++++++++++--
 client/deps/cliparser/cliparser.h |  2 ++
 client/src/cmdlfem4x05.c          | 46 ++++++++++++++-----------------
 client/src/cmdlfkeri.c            | 11 +++++---
 client/src/cmdlfvisa2000.c        | 42 +++++++++++++++++++++-------
 include/protocols.h               |  8 +++---
 6 files changed, 85 insertions(+), 47 deletions(-)

diff --git a/client/deps/cliparser/cliparser.c b/client/deps/cliparser/cliparser.c
index 258346c00..ca119ac14 100644
--- a/client/deps/cliparser/cliparser.c
+++ b/client/deps/cliparser/cliparser.c
@@ -11,8 +11,10 @@
 #include "cliparser.h"
 #include <string.h>
 #include <stdlib.h>
-#include <util.h> // Get color constants
-#include <ui.h> // get PrintAndLogEx
+#include <util.h>   // Get color constants
+#include <ui.h>     // get PrintAndLogEx
+#include <ctype.h>  // tolower
+#include <inttypes.h> // PRIu64
 
 #ifndef ARRAYLEN
 # define ARRAYLEN(x) (sizeof(x)/sizeof((x)[0]))
@@ -125,7 +127,6 @@ int CLIParserParseArg(CLIParserContext *ctx, int argc, char **argv, void *vargta
     return 0;
 }
 
-
 enum ParserState {
     PS_FIRST,
     PS_ARGUMENT,
@@ -272,4 +273,20 @@ int CLIParamStrToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int
     return 0;
 }
 
+uint64_t arg_get_u64_hexstr_def(CLIParserContext *ctx, uint8_t paramnum, uint64_t def) {
+    uint64_t rv = 0;
+    uint8_t data[8];
+    int datalen = 0;
+    int res = CLIParamHexToBuf(arg_get_str(ctx, paramnum), data, sizeof(data), &datalen);
+    if (res == 0) {
+        for (uint8_t i = 0; i < datalen; i++) {
+            rv <<= 8;
+            rv |= data[i];
+        }
+    } else  {
+        rv = def;
+    }   
+    return rv;
+}
+
 
diff --git a/client/deps/cliparser/cliparser.h b/client/deps/cliparser/cliparser.h
index 89c9e00ca..996ad81ef 100644
--- a/client/deps/cliparser/cliparser.h
+++ b/client/deps/cliparser/cliparser.h
@@ -66,4 +66,6 @@ int CLIParserParseArg(CLIParserContext *ctx, int argc, char **argv, void *vargta
 
 int CLIParamHexToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int *datalen);
 int CLIParamStrToBuf(struct arg_str *argstr, uint8_t *data, int maxdatalen, int *datalen);
+
+uint64_t arg_get_u64_hexstr_def(CLIParserContext *ctx, uint8_t paramnum, uint64_t def);
 #endif
diff --git a/client/src/cmdlfem4x05.c b/client/src/cmdlfem4x05.c
index fed515b37..24a16d8e5 100644
--- a/client/src/cmdlfem4x05.c
+++ b/client/src/cmdlfem4x05.c
@@ -374,19 +374,17 @@ int em4x05_clone_tag(uint32_t *blockdata, uint8_t numblocks, uint32_t pwd, bool
 
     // fast push mode
     conn.block_after_ACK = true;
-
-    int res = em4x05_write_word_ext(EM_CONFIG_BLOCK, pwd, use_pwd, blockdata[0]);
-    if (res != PM3_SUCCESS) {
-        PrintAndLogEx(FAILED, "(em4x05_clone_tag) Time out writing to tag");
-        return res;
-    }
-
-    for (int8_t i = 1; i < numblocks; i++) {
+    int res = 0;
+    for (int8_t i = 0; i < numblocks; i++) {
 
         // Disable fast mode on last packet
         if (i == numblocks - 1) {
             conn.block_after_ACK = false;
         }
+        
+        if (i != 0) {
+            blockdata[i] = reflect(blockdata[i], 32);
+        }
 
         res = em4x05_write_word_ext(4 + i, pwd, use_pwd, blockdata[i]);
         if (res != PM3_SUCCESS) {
@@ -396,19 +394,14 @@ int em4x05_clone_tag(uint32_t *blockdata, uint8_t numblocks, uint32_t pwd, bool
     }
 
     res = 0;
-    if (em4x05_verify_write(EM_CONFIG_BLOCK, use_pwd, pwd, blockdata[0]) == false) {
-        res++;
-    }
-    
-    for (int8_t i = 1; i < numblocks; i++) {
+    for (int8_t i = 0; i < numblocks; i++) {
         if (em4x05_verify_write(4 + i, use_pwd, pwd, blockdata[i]) == false) {
             res++;
         }
     }
 
-    if (res == 0) {
+    if (res == 0)
         PrintAndLogEx(SUCCESS, "Success writing to tag");
-    }
 
     return PM3_SUCCESS;
 }
@@ -496,19 +489,19 @@ int CmdEM4x05Dump(const char *Cmd) {
     CLIParserInit(&ctx, "lf em dump",
                   "Dump EM4x05/EM4x69.  Tag must be on antenna.",
                   "lf em dump\n"
-                  "lf em dump -p 0x11223344\n"
-                  "lf em dump -f myfile -p 0x11223344"
+                  "lf em dump -p 11223344\n"
+                  "lf em dump -f myfile -p 11223344"
                  );
 
     void *argtable[] = {
         arg_param_begin,
-        arg_u64_0("p", "pwd", "<hex>", "password (0x00000000)"),
+        arg_str0("p", "pwd", "<hex>", "password (00000000)"),
         arg_str0("f", "file", "<filename>", "override filename prefix (optional).  Default is based on UID"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
 
-    uint64_t inputpwd = arg_get_u64_def(ctx, 1, 0xFFFFFFFFFFFFFFFF);
+    uint64_t inputpwd = arg_get_u64_hexstr_def(ctx, 1, 0xFFFFFFFFFFFFFFFF);
     int fnlen = 0;
     char filename[FILE_PATH_SIZE] = {0};
     CLIParamStrToBuf(arg_get_str(ctx, 2), (uint8_t *)filename, FILE_PATH_SIZE, &fnlen);
@@ -1139,21 +1132,22 @@ int CmdEM4x05Chk(const char *Cmd) {
     CLIParserInit(&ctx, "lf em 4x05_chk",
                   "This command uses a dictionary attack against EM4205/4305/4469/4569",
                   "lf em 4x05_chk\n"
-                  "lf em 4x05_chk -e 0x00000022B8        -> remember to use 0x for hex\n"
+                  "lf em 4x05_chk -e 000022B8            -> remember to use 0x for hex\n"
                   "lf em 4x05_chk -f t55xx_default_pwds  -> use T55xx default dictionary"
                  );
 
     void *argtable[] = {
         arg_param_begin,
         arg_strx0("f", "file", "<*.dic>", "loads a default keys dictionary file <*.dic>"),
-        arg_u64_0("e", "em", "<EM4100>", "try the calculated password from some cloners based on EM4100 ID"),
+        arg_str0("e", "em", "<EM4100>", "try the calculated password from some cloners based on EM4100 ID"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
     int fnlen = 0;
     char filename[FILE_PATH_SIZE] = {0};
     CLIParamStrToBuf(arg_get_str(ctx, 1), (uint8_t *)filename, FILE_PATH_SIZE, &fnlen);
-    uint64_t card_id = arg_get_u64_def(ctx, 2, 0);
+
+    uint64_t card_id = arg_get_u64_hexstr_def(ctx, 2, 0);
     CLIParserFree(ctx);
 
     if (strlen(filename) == 0) {
@@ -1241,7 +1235,7 @@ int CmdEM4x05Brute(const char *Cmd) {
                   "Note: if you get many false positives, change position on the antenna"
                   "lf em 4x05_brute\n"
                   "lf em 4x05_brute -n 1                   -> stop after first candidate found\n"
-                  "lf em 4x05_brute -s 0x000022B8          -> remember to use 0x for hex"
+                  "lf em 4x05_brute -s 000022B8            -> remember to use 0x for hex"
                  );
 
     void *argtable[] = {
@@ -1251,7 +1245,7 @@ int CmdEM4x05Brute(const char *Cmd) {
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, true);
-    uint32_t start_pwd = arg_get_u64_def(ctx, 1, 0);
+    uint32_t start_pwd = arg_get_u64_hexstr_def(ctx, 1, 0);
     uint32_t n = arg_get_int_def(ctx, 2, 0);
     CLIParserFree(ctx);
 
@@ -1352,7 +1346,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
         arg_int0("n", NULL, NULL, "steps to skip"),
         arg_int0("s", "start", "<us>", "start scan from delay (us)"),
         arg_int0("e", "end", "<us>", "end scan at delay (us)"),
-        arg_u64_0("p", "pwd", "", "password (0x00000000)"),
+        arg_str0("p", "pwd", "", "password (00000000)"),
         arg_lit0("v", "verbose", "verbose output"),
         arg_param_end
     };
@@ -1360,7 +1354,7 @@ int CmdEM4x05Unlock(const char *Cmd) {
     double n = (double)arg_get_int_def(ctx, 1, 0);
     double start = (double)arg_get_int_def(ctx, 2, 2000);
     double end = (double)arg_get_int_def(ctx, 3, 6000);
-    uint64_t inputpwd = arg_get_u64_def(ctx, 4, 0xFFFFFFFFFFFFFFFF);
+    uint64_t inputpwd = arg_get_u64_hexstr_def(ctx, 4, 0xFFFFFFFFFFFFFFFF);
     bool verbose = arg_get_lit(ctx, 5);
     CLIParserFree(ctx);
 
diff --git a/client/src/cmdlfkeri.c b/client/src/cmdlfkeri.c
index 7260bc494..a35ad4c81 100644
--- a/client/src/cmdlfkeri.c
+++ b/client/src/cmdlfkeri.c
@@ -205,7 +205,7 @@ static int CmdKeriClone(const char *Cmd) {
 
     CLIParserContext *ctx;
     CLIParserInit(&ctx, "lf keri clone",
-                  "clone a KERI tag to a T55x7, Q5/T5555 or EM4305 tag",
+                  "clone a KERI tag to a T55x7, Q5/T5555 or EM4305/4469 tag",
                   "lf keri clone -t i --id 12345\n"
                   "lf keri clone -t m --fc 6 --id 12345\n");
 
@@ -215,17 +215,20 @@ static int CmdKeriClone(const char *Cmd) {
         arg_str0("t",  "type", "<m|i>", "Type m - MS, i - Internal ID"),
         arg_int0(NULL, "fc",   "<dec>", "Facility Code"),
         arg_int1(NULL, "id",   "<dec>", "Keri ID"),
-        arg_lit0(NULL,  "em4305",       "specify writing to EM5405 tag"),
+        arg_lit0(NULL,  "em",           "specify writing to EM4305/4469 tag"),
         arg_param_end
     };
     CLIExecWithReturn(ctx, Cmd, argtable, false);
 
+    char cardtype[16] = {"T55x7"};
     if (arg_get_lit(ctx, 1)) {
         blocks[0] = T5555_FIXED | T5555_MODULATION_PSK1 | T5555_SET_BITRATE(32) | T5555_PSK_RF_2 | 2 << T5555_MAXBLOCK_SHIFT;
+        snprintf(cardtype, sizeof(cardtype) ,"Q5/T5555");
         q5 = true;
     }
     if (arg_get_lit(ctx, 5)) {
-        blocks[0] = EM4305_KERI_CONFIG_BLOCK;        
+        blocks[0] = EM4305_KERI_CONFIG_BLOCK;
+        snprintf(cardtype, sizeof(cardtype) ,"EM4305/4469");
         em4305 = true;
     }
 
@@ -258,7 +261,7 @@ static int CmdKeriClone(const char *Cmd) {
     // Prepare and write to card
     // 3 LSB is ONE
     uint64_t data = ((uint64_t)internalid << 3) + 7;
-    PrintAndLogEx(INFO, "Preparing to clone KERI to " _YELLOW_("%s") " with Internal Id " _YELLOW_("%" PRIx32), (q5) ? "Q5/T5555" : "T55x7", internalid);
+    PrintAndLogEx(INFO, "Preparing to clone KERI to " _YELLOW_("%s") " with Internal Id " _YELLOW_("%" PRIx32), cardtype, internalid);
 
     blocks[1] = data >> 32;
     blocks[2] = data & 0xFFFFFFFF;
diff --git a/client/src/cmdlfvisa2000.c b/client/src/cmdlfvisa2000.c
index 97f5dc48e..84abc6177 100644
--- a/client/src/cmdlfvisa2000.c
+++ b/client/src/cmdlfvisa2000.c
@@ -10,23 +10,23 @@
 //-----------------------------------------------------------------------------
 
 #include "cmdlfvisa2000.h"
-
 #include <string.h>
 #include <ctype.h>
 #include <stdlib.h>
 #include <inttypes.h>
-
-#include "commonutil.h"     // ARRAYLEN
+#include <stdio.h>
+#include "commonutil.h"    // ARRAYLEN
 #include "common.h"
-#include "cmdparser.h"    // command_t
+#include "cmdparser.h"     // command_t
 #include "comms.h"
 #include "ui.h"
 #include "graph.h"
 #include "cmddata.h"
 #include "cmdlf.h"
-#include "protocols.h"  // for T55xx config register definitions
-#include "lfdemod.h"    // parityTest
+#include "protocols.h"     // for T55xx config register definitions
+#include "lfdemod.h"       // parityTest
 #include "cmdlft55xx.h"    // write verify
+#include "cmdlfem4x05.h"   //
 
 #define BL0CK1 0x56495332
 
@@ -39,10 +39,12 @@ static int usage_lf_visa2k_clone(void) {
     PrintAndLogEx(NORMAL, "      h          : This help");
     PrintAndLogEx(NORMAL, "      <card ID>  : Visa2k card ID");
     PrintAndLogEx(NORMAL, "      <Q5>       : specify writing to Q5/T5555 tag");
+    PrintAndLogEx(NORMAL, "      <em4305>   : specify writing to EM4305/4469 tag");
     PrintAndLogEx(NORMAL, "");
     PrintAndLogEx(NORMAL, "Examples:");
     PrintAndLogEx(NORMAL, _YELLOW_("      lf visa2000 clone 112233"));
     PrintAndLogEx(NORMAL, _YELLOW_("      lf visa2000 clone 112233 q5") "      -- encode for Q5/T5555");
+    PrintAndLogEx(NORMAL, _YELLOW_("      lf visa2000 clone 112233 em4305") "  -- encode for EM4305/4469");
     return PM3_SUCCESS;
 }
 
@@ -180,18 +182,38 @@ static int CmdVisa2kClone(const char *Cmd) {
 
     id = param_get32ex(Cmd, 0, 0, 10);
 
-    //Q5
+    char cardtype[16] = {"T55x7"};
+    // Q5
     bool q5 = tolower(param_getchar(Cmd, 1)) == 'q';
-    if (q5)
+    if (q5) {
         blocks[0] = T5555_FIXED | T5555_MODULATION_MANCHESTER | T5555_SET_BITRATE(64) | T5555_ST_TERMINATOR | 3 << T5555_MAXBLOCK_SHIFT;
+        snprintf(cardtype, sizeof(cardtype) ,"Q5/T5555");
+    }
 
+    // EM4305
+    bool em4305 = tolower(param_getchar(Cmd, 1)) == 'e';
+    if (em4305) {
+        blocks[0] = EM4305_VISA2000_CONFIG_BLOCK;
+        snprintf(cardtype, sizeof(cardtype) ,"EM4305/4469");
+    }
+    
+    if (q5 && em4305) {
+        PrintAndLogEx(FAILED, "Can't specify both Q5 and EM4305 at the same time");
+        return PM3_EINVARG;
+    }
+        
     blocks[2] = id;
     blocks[3] = (visa_parity(id) << 4) | visa_chksum(id);
 
-    PrintAndLogEx(INFO, "Preparing to clone Visa2000 to " _YELLOW_("%s") " with CardId: %"PRIu64, (q5) ? "Q5/T5555" : "T55x7", id);
+    PrintAndLogEx(INFO, "Preparing to clone Visa2000 to " _YELLOW_("%s") " with CardId: %"PRIu64, cardtype, id);
     print_blocks(blocks,  ARRAYLEN(blocks));
 
-    int res = clone_t55xx_tag(blocks, ARRAYLEN(blocks));
+    int res;
+    if (em4305) {
+        res = em4x05_clone_tag(blocks, ARRAYLEN(blocks), 0, false);
+    } else {
+        res = clone_t55xx_tag(blocks, ARRAYLEN(blocks));
+    }
     PrintAndLogEx(SUCCESS, "Done");
     PrintAndLogEx(HINT, "Hint: try " _YELLOW_("`lf visa2000 read`") " to verify");
     return res;
diff --git a/include/protocols.h b/include/protocols.h
index bb520a71f..6a079f354 100644
--- a/include/protocols.h
+++ b/include/protocols.h
@@ -541,8 +541,8 @@ ISO 7816-4 Basic interindustry commands. For command APDU's.
 #define T55XX_WRITE_TIMEOUT 1500
 
 // em4x05 & em4x69 chip configuration register definitions
-#define EM4x05_GET_BITRATE(x)           (((x & 0x3F)*2)+2)
-#define EM4x05_SET_BITRATE(x)           ((x-2)/2)
+#define EM4x05_GET_BITRATE(x)           ((((x) & 0x3F) * 2) + 2)
+#define EM4x05_SET_BITRATE(x)           (((x) - 2) / 2)
 #define EM4x05_MODULATION_NRZ           0x00000000
 #define EM4x05_MODULATION_MANCHESTER    0x00000040
 #define EM4x05_MODULATION_BIPHASE       0x00000080
@@ -557,8 +557,8 @@ ISO 7816-4 Basic interindustry commands. For command APDU's.
 #define EM4x05_PSK_RF_8                 0x00000800
 #define EM4x05_MAXBLOCK_SHIFT           14
 #define EM4x05_FIRST_USER_BLOCK         5
-#define EM4x05_SET_NUM_BLOCKS(x)        ((x+5-1)<<14) //# of blocks sent during default read mode
-#define EM4x05_GET_NUM_BLOCKS(x)        (((x>>14) & 0xF)-5+1)
+#define EM4x05_SET_NUM_BLOCKS(x)        (( (x) + 4) << 14) //# of blocks sent during default read mode
+#define EM4x05_GET_NUM_BLOCKS(x)        ((( (x) >> 14) & 0xF) - 4)
 #define EM4x05_READ_LOGIN_REQ           (1 << 18)
 #define EM4x05_READ_HK_LOGIN_REQ        (1 << 19)
 #define EM4x05_WRITE_LOGIN_REQ          (1 << 20)

From ce50c50fcdc4b329fa3bd34f6e03cc1dbf458b46 Mon Sep 17 00:00:00 2001
From: iceman1001 <iceman@iuse.se>
Date: Wed, 21 Oct 2020 08:49:40 +0200
Subject: [PATCH 33/35] lf keri demod -  when doing invert of bits,  do before
 decoding

---
 client/src/cmdlfkeri.c | 38 +++++++++++++++++++++-----------------
 1 file changed, 21 insertions(+), 17 deletions(-)

diff --git a/client/src/cmdlfkeri.c b/client/src/cmdlfkeri.c
index a35ad4c81..6e4475950 100644
--- a/client/src/cmdlfkeri.c
+++ b/client/src/cmdlfkeri.c
@@ -123,17 +123,6 @@ int demodKeri(bool verbose) {
     setDemodBuff(DemodBuffer, size, idx);
     setClockGrid(g_DemodClock, g_DemodStartIdx + (idx * g_DemodClock));
 
-    //got a good demod
-    uint32_t raw1 = bytebits_to_byte(DemodBuffer, 32);
-    uint32_t raw2 = bytebits_to_byte(DemodBuffer + 32, 32);
-
-    //get internal id
-    // uint32_t ID = bytebits_to_byte(DemodBuffer + 29, 32);
-    // Due to the 3 sync bits being at the start of the capture
-    // We can take the last 32bits as the internal ID.
-    uint32_t ID = raw2;
-    ID &= 0x7FFFFFFF;
-
     /*
         000000000000000000000000000001XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX111
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^1###############################^^^
@@ -148,25 +137,40 @@ int demodKeri(bool verbose) {
         Might be a hash of FC & CN to generate Internal ID
     */
 
-    PrintAndLogEx(SUCCESS, "KERI - Internal ID: " _GREEN_("%u") ", Raw: %08X%08X", ID, raw1, raw2);
+
     /*
         Descramble Data.
     */
     uint32_t fc = 0;
     uint32_t cardid = 0;
-
-    // Just need to the low 32 bits without the 111 trailer
-    CmdKeriMSScramble(Descramble, &fc, &cardid, &raw2);
-
-    PrintAndLogEx(SUCCESS, "Descrambled MS - FC: " _GREEN_("%d") " Card: " _GREEN_("%d"), fc, cardid);
+    //got a good demod
+    uint32_t raw1 = bytebits_to_byte(DemodBuffer, 32);
+    uint32_t raw2 = bytebits_to_byte(DemodBuffer + 32, 32);
 
     if (invert) {
         PrintAndLogEx(INFO, "Had to Invert - probably KERI");
         for (size_t i = 0; i < size; i++)
             DemodBuffer[i] ^= 1;
 
+        raw1 = bytebits_to_byte(DemodBuffer, 32);
+        raw2 = bytebits_to_byte(DemodBuffer + 32, 32);
+    
         CmdPrintDemodBuff("x");
     }
+
+    //get internal id
+    // uint32_t ID = bytebits_to_byte(DemodBuffer + 29, 32);
+    // Due to the 3 sync bits being at the start of the capture
+    // We can take the last 32bits as the internal ID.
+    uint32_t ID = raw2;
+    ID &= 0x7FFFFFFF;
+
+    PrintAndLogEx(SUCCESS, "KERI - Internal ID: " _GREEN_("%u") ", Raw: %08X%08X", ID, raw1, raw2);
+    
+    // Just need to the low 32 bits without the 111 trailer
+    CmdKeriMSScramble(Descramble, &fc, &cardid, &raw2);
+
+    PrintAndLogEx(SUCCESS, "Descrambled MS - FC: " _GREEN_("%d") " Card: " _GREEN_("%d"), fc, cardid);
     return PM3_SUCCESS;
 }
 

From e4aec4d282b8284e90370420178e5a54cc4bf867 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Wed, 21 Oct 2020 09:59:29 +0200
Subject: [PATCH 34/35] Add ISOC99 to cliparser for %zu

---
 client/deps/cliparser/Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/client/deps/cliparser/Makefile b/client/deps/cliparser/Makefile
index 4873372c4..1994992f9 100644
--- a/client/deps/cliparser/Makefile
+++ b/client/deps/cliparser/Makefile
@@ -9,3 +9,12 @@ MYSRCS = \
 LIB_A = libcliparser.a
 
 include ../../../Makefile.host
+
+$(info PLATFORM $(platform))
+ifneq (,$(findstring MINGW,$(platform)))
+    # Mingw uses by default Microsoft printf, we want the GNU printf (e.g. for %z)
+    # and setting _ISOC99_SOURCE sets internally __USE_MINGW_ANSI_STDIO=1
+    # FTR __USE_MINGW_ANSI_STDIO seems deprecated in Mingw32
+    # but not Mingw64 https://fr.osdn.net/projects/mingw/lists/archive/users/2019-January/000199.html
+    CFLAGS += -D_ISOC99_SOURCE
+endif

From edda8adbc5c3afb08e30ff1a0cae45b58ba89f72 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Wed, 21 Oct 2020 10:02:32 +0200
Subject: [PATCH 35/35] cmake: Add ISOC99 to cliparser for %zu

---
 client/deps/cliparser.cmake | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/deps/cliparser.cmake b/client/deps/cliparser.cmake
index b16451c07..fccae33b7 100644
--- a/client/deps/cliparser.cmake
+++ b/client/deps/cliparser.cmake
@@ -3,6 +3,7 @@ add_library(pm3rrg_rdv4_cliparser STATIC
         cliparser/cliparser.c
 )
 
+target_compile_definitions(pm3rrg_rdv4_cliparser PRIVATE _ISOC99_SOURCE)
 target_include_directories(pm3rrg_rdv4_cliparser PRIVATE
         ../../common
         ../../include