github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 05:43:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix cppchecker, bad boolean compare and unused value

Browse source
This commit is contained in:
iceman1001 2021-05-13 21:19:16 +02:00
commit ec46f55821
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
client/src/cmdhffido.c
View file

@ -195,7 +195,7 @@ static int CmdHFFidoRegister(const char *cmd) {
return PM3_EINVARG; return PM3_EINVARG;
} }
} }
if (cphex & !cpplain) { if (cphex && cpplain == false) {
chlen = sizeof(cdata); chlen = sizeof(cdata);
CLIGetHexWithReturn(ctx, 7, cdata, &chlen); CLIGetHexWithReturn(ctx, 7, cdata, &chlen);
if (chlen && chlen != 32) { if (chlen && chlen != 32) {
@ -219,7 +219,7 @@ static int CmdHFFidoRegister(const char *cmd) {
return PM3_EINVARG; return PM3_EINVARG;
} }
} }
if (aphex & !applain) { if (aphex && applain == false) {
applen = sizeof(adata); applen = sizeof(adata);
CLIGetHexWithReturn(ctx, 8, adata, &applen); CLIGetHexWithReturn(ctx, 8, adata, &applen);
if (applen && applen != 32) { if (applen && applen != 32) {
@ -380,6 +380,7 @@ static int CmdHFFidoRegister(const char *cmd) {
//sprintf(filename, "hf-fido2-params"); //sprintf(filename, "hf-fido2-params");
res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose); res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose);
(void)res;
} }
json_decref(root); json_decref(root);
return PM3_SUCCESS; return PM3_SUCCESS;
@ -635,6 +636,7 @@ static int CmdHFFidoAuthenticate(const char *cmd) {
sprintf(filename, "hf-fido2-params"); sprintf(filename, "hf-fido2-params");
res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose); res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose);
(void)res;
} }
json_decref(root); json_decref(root);
return PM3_ESOFT; return PM3_ESOFT;
@ -754,6 +756,7 @@ static int CmdHFFido2MakeCredential(const char *cmd) {
// new file name.. // new file name..
sprintf(filename, "hf-fido2"); sprintf(filename, "hf-fido2");
res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose); res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose);
(void)res;
json_decref(root); json_decref(root);
return res; return res;
} }
@ -873,6 +876,7 @@ static int CmdHFFido2GetAssertion(const char *cmd) {
// new file name.. // new file name..
sprintf(filename, "hf-fido2"); sprintf(filename, "hf-fido2");
res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose); res = saveFileJSONroot(filename, root, JSON_INDENT(2), verbose);
(void)res;
json_decref(root); json_decref(root);
return res; return res;
} }