github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-19 21:03:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

FIX: Coverity Scan fixes to emvcmd.c among others.

Browse source 
FIX: emclearmem bug.
This commit is contained in:
iceman1001 2017-03-05 18:43:06 +01:00
commit dfcf20d641
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
armsrc/emvcard.h
View file

@ -178,7 +178,7 @@ typedef struct {
uint8_t tag_9F34[3]; //Cardholder Verification Method (CVM) Results uint8_t tag_9F34[3]; //Cardholder Verification Method (CVM) Results
uint8_t tag_9F35[1]; //Terminal Type uint8_t tag_9F35[1]; //Terminal Type
uint8_t tag_9F36[2]; //Application Transaction Counter (ATC) uint8_t tag_9F36[2]; //Application Transaction Counter (ATC)
uint8_t tag_9F37[4]; //Unpredictable Number uint8_t tag_9F37[8]; //Unpredictable Number
uint8_t tag_9F38_len; uint8_t tag_9F38_len;
uint8_t tag_9F38[255]; //PDOL uint8_t tag_9F38[255]; //PDOL
uint8_t tag_9F39[1]; //Point-of-Service (POS) Entry Mode uint8_t tag_9F39[1]; //Point-of-Service (POS) Entry Mode
@ -209,7 +209,7 @@ typedef struct {
uint8_t tag_9F63[6]; //Track 1 Bit Map for UN and ATC (PUNATCTRACK1) uint8_t tag_9F63[6]; //Track 1 Bit Map for UN and ATC (PUNATCTRACK1)
uint8_t tag_9F64[1]; //Track 1 Number of ATC Digits (NATCTRACK1) uint8_t tag_9F64[1]; //Track 1 Number of ATC Digits (NATCTRACK1)
uint8_t tag_9F65[2]; //rack 2 Bit Map for CVC3 (PCVC3TRACK2) uint8_t tag_9F65[2]; //rack 2 Bit Map for CVC3 (PCVC3TRACK2)
uint8_t tag_9F66[2]; //Track 2 Bit Map for UN and ATC (PUNATCTRACK2), or VISA card type uint8_t tag_9F66[4]; //Track 2 Bit Map for UN and ATC (PUNATCTRACK2), or VISA card type
uint8_t tag_9F67[1]; //Track 2 Number of ATC Digits (NATCTRACK2) uint8_t tag_9F67[1]; //Track 2 Number of ATC Digits (NATCTRACK2)
uint8_t tag_9F68_len; uint8_t tag_9F68_len;
uint8_t tag_9F68[252]; //Mag Stripe CVM List uint8_t tag_9F68[252]; //Mag Stripe CVM List

2
armsrc/emvcmd.c
View file

@ -1068,7 +1068,7 @@ void EMVFuzz_RATS(uint8_t ratslen, uint8_t* RATS)
uint8_t *receivedCmdPar = BigBuf_malloc(MAX_PARITY_SIZE); uint8_t *receivedCmdPar = BigBuf_malloc(MAX_PARITY_SIZE);
// To control where we are in the protocol // To control where we are in the protocol
int order; int order = 0;
// We need to listen to the high-frequency, peak-detected path. // We need to listen to the high-frequency, peak-detected path.
iso14443a_setup(FPGA_HF_ISO14443A_TAGSIM_LISTEN); iso14443a_setup(FPGA_HF_ISO14443A_TAGSIM_LISTEN);

2
armsrc/mifareutil.c
View file

@ -578,7 +578,7 @@ void emlClearMem(void) {
memset(emCARD, 0, CARD_MEMORY_SIZE); memset(emCARD, 0, CARD_MEMORY_SIZE);
// fill sectors trailer data // fill sectors trailer data
for(uint8_t b = 3; b < 256; ((b < 127) ? (b += 4) : (b += 16))) for(uint16_t b = 3; b < 256; ((b < 127) ? (b += 4) : (b += 16)))
emlSetMem((uint8_t *)trailer, b, 1); emlSetMem((uint8_t *)trailer, b, 1);
// uid // uid

4
common/emvtags.h
View file

@ -182,7 +182,7 @@ typedef struct {
uint8_t tag_9F34[3]; //Cardholder Verification Method (CVM) Results uint8_t tag_9F34[3]; //Cardholder Verification Method (CVM) Results
uint8_t tag_9F35[1]; //Terminal Type uint8_t tag_9F35[1]; //Terminal Type
uint8_t tag_9F36[2]; //Application Transaction Counter (ATC) uint8_t tag_9F36[2]; //Application Transaction Counter (ATC)
uint8_t tag_9F37[4]; //Unpredictable Number uint8_t tag_9F37[8]; //Unpredictable Number
uint8_t tag_9F38_len; uint8_t tag_9F38_len;
uint8_t tag_9F38[255]; //PDOL uint8_t tag_9F38[255]; //PDOL
uint8_t tag_9F39[1]; //Point-of-Service (POS) Entry Mode uint8_t tag_9F39[1]; //Point-of-Service (POS) Entry Mode
@ -213,7 +213,7 @@ typedef struct {
uint8_t tag_9F63[6]; //Track 1 Bit Map for UN and ATC (PUNATCTRACK1) uint8_t tag_9F63[6]; //Track 1 Bit Map for UN and ATC (PUNATCTRACK1)
uint8_t tag_9F64[1]; //Track 1 Number of ATC Digits (NATCTRACK1) uint8_t tag_9F64[1]; //Track 1 Number of ATC Digits (NATCTRACK1)
uint8_t tag_9F65[2]; //rack 2 Bit Map for CVC3 (PCVC3TRACK2) uint8_t tag_9F65[2]; //rack 2 Bit Map for CVC3 (PCVC3TRACK2)
uint8_t tag_9F66[2]; //Track 2 Bit Map for UN and ATC (PUNATCTRACK2), or VISA card type uint8_t tag_9F66[4]; //Track 2 Bit Map for UN and ATC (PUNATCTRACK2), or VISA card type
uint8_t tag_9F67[1]; //Track 2 Number of ATC Digits (NATCTRACK2) uint8_t tag_9F67[1]; //Track 2 Number of ATC Digits (NATCTRACK2)
uint8_t tag_9F68_len; uint8_t tag_9F68_len;
uint8_t tag_9F68[252]; //Mag Stripe CVM List uint8_t tag_9F68[252]; //Mag Stripe CVM List