github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 05:43:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

analyse demodbuff - bad reference to string pointer after free

Browse source
This commit is contained in:
iceman1001 2021-01-29 11:59:32 +01:00
commit dc01b63d49
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
client/src/cmdanalyse.c
View file

@ -931,19 +931,14 @@ static int CmdAnalyseDemodBuffer(const char *Cmd) {
}; };
CLIExecWithReturn(ctx, Cmd, argtable, true); CLIExecWithReturn(ctx, Cmd, argtable, true);
const char *s = arg_get_str(ctx, 1)->sval[0]; const char *s = arg_get_str(ctx, 1)->sval[0];
CLIParserFree(ctx);
if (s == NULL) {
PrintAndLogEx(FAILED, "Must provide a binary string");
return PM3_EINVARG;
}
int len = MIN(strlen(s), MAX_DEMOD_BUF_LEN); int len = MIN(strlen(s), MAX_DEMOD_BUF_LEN);
// add 1 for null terminator. // add 1 for null terminator.
uint8_t *data = calloc(len + 1, sizeof(uint8_t)); uint8_t *data = calloc(len + 1, sizeof(uint8_t));
if (data == NULL) if (data == NULL) {
CLIParserFree(ctx);
return PM3_EMALLOC; return PM3_EMALLOC;
}
for (int i = 0; i <= strlen(s); i++) { for (int i = 0; i <= strlen(s); i++) {
char c = s[i]; char c = s[i];
@ -954,6 +949,9 @@ static int CmdAnalyseDemodBuffer(const char *Cmd) {
PrintAndLogEx(NORMAL, "%c" NOLF, c); PrintAndLogEx(NORMAL, "%c" NOLF, c);
} }
CLIParserFree(ctx);
PrintAndLogEx(NORMAL, ""); PrintAndLogEx(NORMAL, "");
DemodBufferLen = len; DemodBufferLen = len;
free(data); free(data);