github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 22:03:42 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

coverity fix 286921, 286922, ..

Browse source
This commit is contained in:
iceman1001 2020-04-26 19:29:22 +02:00
commit cf9a5a4850
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
client/src/cmdhfmfdes.c
View file

@ -2180,6 +2180,7 @@ static int CmdHF14ADesGetValueData(const char *Cmd) {
arg_param_end arg_param_end
}; };
CLIExecWithReturn(Cmd, argtable, false); CLIExecWithReturn(Cmd, argtable, false);
int aidlength = 0; int aidlength = 0;
uint8_t aid[3] = {0}; uint8_t aid[3] = {0};
CLIGetHexWithReturn(1, aid, &aidlength); CLIGetHexWithReturn(1, aid, &aidlength);
@ -2219,7 +2220,7 @@ static int CmdHF14ADesGetValueData(const char *Cmd) {
int len = 0; int len = 0;
res = handler_desfire_getvalue(&value, &len); res = handler_desfire_getvalue(&value, &len);
if (res == PM3_SUCCESS) { if (res == PM3_SUCCESS) {
PrintAndLogEx(SUCCESS, "Successfully read value from File %d:", fileno); PrintAndLogEx(SUCCESS, "Successfully read value from File %u:", fileno);
PrintAndLogEx(NORMAL, "\nOffset | Data | Ascii"); PrintAndLogEx(NORMAL, "\nOffset | Data | Ascii");
PrintAndLogEx(NORMAL, "----------------------------------------------------------------------------"); PrintAndLogEx(NORMAL, "----------------------------------------------------------------------------");
for (int i = 0; i < len; i += 16) { for (int i = 0; i < len; i += 16) {
@ -2360,7 +2361,9 @@ static int CmdHF14ADesChangeValue(const char *Cmd) {
CLIGetHexWithReturn(1, aid, &aidlength); CLIGetHexWithReturn(1, aid, &aidlength);
int filenolen = 0; int filenolen = 0;
CLIGetHexWithReturn(2, &value.fileno, &filenolen); uint8_t fileno[1] = {0};
CLIGetHexWithReturn(2, fileno, &filenolen);
value.fileno = fileno[0];
int vlength = 0x0; int vlength = 0x0;
CLIParamHexToBuf(arg_get_str(3), value.value, 4, &vlength); CLIParamHexToBuf(arg_get_str(3), value.value, 4, &vlength);
@ -2427,12 +2430,6 @@ static int CmdHF14ADesChangeValue(const char *Cmd) {
static int CmdHF14ADesWriteData(const char *Cmd) { static int CmdHF14ADesWriteData(const char *Cmd) {
uint8_t *data = (uint8_t *)calloc(0xFFFF, sizeof(uint8_t));
if (data == NULL) {
PrintAndLogEx(ERR, "failed to allocate memory");
return PM3_EMALLOC;
}
CLIParserInit("hf mfdes writedata", CLIParserInit("hf mfdes writedata",
"Write data to File", "Write data to File",
"Usage:" "Usage:"
@ -2464,6 +2461,11 @@ static int CmdHF14ADesWriteData(const char *Cmd) {
CLIParamHexToBuf(arg_get_str(3), offset, 3, &offsetlength); CLIParamHexToBuf(arg_get_str(3), offset, 3, &offsetlength);
int dlength = 0xFFFF; int dlength = 0xFFFF;
uint8_t *data = (uint8_t *)calloc(0xFFFF, sizeof(uint8_t));
if (data == NULL) {
PrintAndLogEx(ERR, "failed to allocate memory");
return PM3_EMALLOC;
}
CLIParamHexToBuf(arg_get_str(4), data, 0xFFFF, &dlength); CLIParamHexToBuf(arg_get_str(4), data, 0xFFFF, &dlength);
int type = arg_get_int(5); int type = arg_get_int(5);