Merge pull request #1484 from AxisRay/fix-dynamic-stack-buffer-overflow

fix dynamic-stack-buffer-overflow
This commit is contained in:
Philippe Teuwen 2021-08-24 16:50:55 +02:00 committed by GitHub
commit ce4eed2acf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -11,6 +11,7 @@
#include "ndef.h" #include "ndef.h"
#include <string.h> #include <string.h>
#include <stdlib.h>
#include "ui.h" #include "ui.h"
#include "util.h" // sprint_hex... #include "util.h" // sprint_hex...
@ -637,7 +638,7 @@ static int ndefDecodePayload(NDEFHeader_t *ndef) {
break; break;
} }
char begin[ndef->TypeLen]; char *begin = calloc(ndef->TypeLen + 1,sizeof(char));
memcpy(begin, ndef->Type, ndef->TypeLen); memcpy(begin, ndef->Type, ndef->TypeLen);
str_lower(begin); str_lower(begin);
@ -651,6 +652,8 @@ static int ndefDecodePayload(NDEFHeader_t *ndef) {
ndefDecodeMime_bt(ndef); ndefDecodeMime_bt(ndef);
} }
free(begin);
begin = NULL;
break; break;
} }
case tnfAbsoluteURIRecord: case tnfAbsoluteURIRecord: