From b14730d57c3ce13d990e55068cd12754993d6360 Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Sat, 10 Dec 2022 03:32:18 +0100 Subject: [PATCH] fix codeql #155 - narrow type with wide type comparison in loop --- client/src/cmdhfmf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/cmdhfmf.c b/client/src/cmdhfmf.c index e5ab53d66..51a9a13f0 100644 --- a/client/src/cmdhfmf.c +++ b/client/src/cmdhfmf.c @@ -6212,7 +6212,7 @@ int CmdHFMFNDEFWrite(const char *Cmd) { uint8_t freemem[MIFARE_4K_MAXSECTOR] = {0}; uint16_t sum = 0; uint8_t block_no = 0; - for (uint8_t i = 1; i < madlen; i++) { + for (uint8_t i = 1; i < (madlen & 0xFF); i++) { freemem[i] = (mad[i] == NDEF_MFC_AID);