From b12be75a5b3bb733cfb61be1c79066e7991e88a9 Mon Sep 17 00:00:00 2001 From: Philippe Teuwen Date: Fri, 26 Apr 2019 12:02:34 +0200 Subject: [PATCH] Remove block_after_ACK mechanism on NG frames, flashing uses OLD and NG won't use ACK anymore --- client/comms.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/client/comms.c b/client/comms.c index d04581175..4501326c1 100644 --- a/client/comms.c +++ b/client/comms.c @@ -438,10 +438,6 @@ __attribute__((force_align_arg_pointer)) if (!error) { // PrintAndLogEx(NORMAL, "Received reply NG full !!"); PacketResponseReceived(&rx); -//TODO NG don't send ACK anymore but reply with the corresponding cmd, still things seem to work fine... - if (rx.cmd == CMD_ACK) { - ACK_received = true; - } } } else { // Old style reply PacketResponseOLD rx_old; @@ -480,6 +476,7 @@ __attribute__((force_align_arg_pointer)) if (connection->block_after_ACK) { // if we just received an ACK, wait here until a new command is to be transmitted + // This is only working on OLD frames, and only used by flasher if (ACK_received) { while (!txBuffer_pending) { pthread_cond_wait(&txBufferSig, &txBufferMutex);