github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 22:03:42 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1487 from rknoll/fix-pac-checksum

Browse source 
Fix PAC/Stanley checksum calculation
This commit is contained in:
Philippe Teuwen 2021-08-28 19:48:19 +02:00 • committed by GitHub
commit 8a925b496a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -3,6 +3,7 @@ All notable changes to this project will be documented in this file.
This project uses the changelog in accordance with [keepchangelog](http://keepachangelog.com/). Please use this to write notable changes, which is not the same as git commit log... This project uses the changelog in accordance with [keepchangelog](http://keepachangelog.com/). Please use this to write notable changes, which is not the same as git commit log...
## [unreleased][unreleased] ## [unreleased][unreleased]
- Fix PAC/Stanley checksum calculation (@rknoll)
- Added option --mem to `hf mf nested`, from icopyx source (@doegox) - Added option --mem to `hf mf nested`, from icopyx source (@doegox)
- Port fpga-xc3s100e and icopyx source code specificities to this repo (@doegox) - Port fpga-xc3s100e and icopyx source code specificities to this repo (@doegox)
- `hf mfdes` - Transactions. commit, abort, commit reader id. (@merlokk) - `hf mfdes` - Transactions. commit, abort, commit reader id. (@merlokk)

2
client/src/cmdlfpac.c
View file

@ -54,7 +54,7 @@ static int pac_buf_to_cardid(uint8_t *src, const size_t src_size, uint8_t *dst,
PrintAndLogEx(DEBUG, "DEBUG: Error - PAC: Parity check failed"); PrintAndLogEx(DEBUG, "DEBUG: Error - PAC: Parity check failed");
return PM3_ESOFT; return PM3_ESOFT;
} }
if (idx < dataLength - 1) checksum ^= byte; if (idx < dataLength - 1) checksum ^= dst[idx];
} }
if (dst[dataLength - 1] != checksum) { if (dst[dataLength - 1] != checksum) {
PrintAndLogEx(DEBUG, "DEBUG: Error - PAC: Bad checksum - expected: %02X, actual: %02X", dst[dataLength - 1], checksum); PrintAndLogEx(DEBUG, "DEBUG: Error - PAC: Bad checksum - expected: %02X, actual: %02X", dst[dataLength - 1], checksum);