From 89dd574f53e6aea5917e24868cda74662775a051 Mon Sep 17 00:00:00 2001
From: Philippe Teuwen <phil@teuwen.org>
Date: Wed, 9 Oct 2019 15:29:42 +0200
Subject: [PATCH] new coverity scripts

---
 .coverity.conf.sample | 35 ++++++++++++++++++++++++++++++++
 covbuild.sh           | 46 ++++++++++++++-----------------------------
 covconfig.sh          | 13 +++---------
 covsubmit.sh          | 31 +++++++++++++++++++++++++++++
 4 files changed, 84 insertions(+), 41 deletions(-)
 create mode 100644 .coverity.conf.sample
 create mode 100755 covsubmit.sh

diff --git a/.coverity.conf.sample b/.coverity.conf.sample
new file mode 100644
index 000000000..2beb3e519
--- /dev/null
+++ b/.coverity.conf.sample
@@ -0,0 +1,35 @@
+COVLOGIN=myemail@corp.com
+COVTOKEN=aAbBcCdDeEfFgGhHiIjJkK
+COVBINDIR="/opt/cov-analysis-linux64-2019.03/bin"
+# Nickname included in scan description:
+NICKNAME=myself
+
+COVDIR=cov-int
+COVBUILD="cov-build --dir $COVDIR"
+
+# Depending if your kernel > 4.8.x, you might need to activate this to run Coverity executables
+# (but latest tools with kernel 5.2 run fine)
+#sysctl vsyscall=emulate
+
+export PATH="$PATH:$COVBINDIR"
+
+function pre_build_hook() {
+    # tmp dir will be /tmp/cov-$username/
+    # It's the good place if you need to redirect to elsewhere with a symlink
+    return 0
+}
+
+function post_build_hook() {
+    return 0
+}
+
+function pre_submit_hook() {
+    return 0
+}
+
+function post_submit_hook() {
+    # Clean up build folders?
+    rm -rf "$COVDIR"
+    echo "Coverity build cleaned"
+    return 0
+}
diff --git a/covbuild.sh b/covbuild.sh
index ab6273d73..bd06630d4 100755
--- a/covbuild.sh
+++ b/covbuild.sh
@@ -1,36 +1,20 @@
 #!/bin/bash
 
-## 2016-01-16,  Iceman
-## build script for Coverity Scan of the proxmark3 source code
+set -e
+. .coverity.conf || exit 1
 
-## clean up pre-compiled objects.
+pre_build_hook
+
+rm -rf "$COVDIR"
+mkdir "$COVDIR"
 make clean
+$COVBUILD make -j 4 bootrom
+$COVBUILD make -j 4 fullimage
+$COVBUILD make -j 4 mfkey
+$COVBUILD make -j 4 nonce2key
+$COVBUILD make -j 4 fpga_compress
+# make sure to do client after ARM because Coverity retains one build info per file
+# and we want the client-side of the common/ analysis
+$COVBUILD make -j 4 client
 
-## coverity build
-/home/user/cov-analysis-linux-2017.07/bin/cov-build --dir cov-int make all
-
-## delete all previous tarballs
-rm proxmark3.all.*.tgz
-
-##
-VERSION="0.1.`date --date now +%H%M`"
-TODAY="`date --date now +%Y%m%d.%H%M`"
-DESCNAME="autoMango.$TODAY"
-FILENAME=proxmark3.all.$TODAY.tgz
-
-## create tarball
-tar cfz $FILENAME cov-int
-echo "Coverity build file is ready"
-
-## clean up build folders
-rm -rf cov-int
-echo "Coverity build cleaned"
-
-## upload tarball to Coverity.com
-curl --form token=dY262wIFmfkcRkA5Pyw0eA \
- --form email=herrmann1001@gmail.com \
-  --form file=@$FILENAME \
-  --form version="$VERSION" \
-  --form description="$DESCNAME" \
-  https://scan.coverity.com/builds?project=proxmark3_iceman_fork
-echo "tarball uploaded to Coverity for analyse"
+post_build_hook
diff --git a/covconfig.sh b/covconfig.sh
index 91b59ceaa..5f4878b3c 100755
--- a/covconfig.sh
+++ b/covconfig.sh
@@ -1,13 +1,6 @@
 #!/bin/bash
 
-## 20160116, iceman
-## remove old
-rm /home/user/cov-analysis-linux-2017.07/config/coverity_config.xml
-rm -rf /home/user/cov-analysis-linux-2017.07/config/gcc-config-?
-rm -rf /home/user/cov-analysis-linux-2017.07/config/g++-config-?
- 
- ## Configure ARM ,  make sure you have the arm gcc in your $PATH variable.
-#/home/user/cov-analysis-linux-2017.07/bin/cov-configure -co arm-none-eabi-gcc -- -mthumb-interwork
-/home/user/cov-analysis-linux-2017.07/bin/cov-configure -co arm-none-eabi-gcc -- -std=c99 -mthumb -mthumb-interwork
+set -e
+. .coverity.conf || exit 1
 
-echo "Done."
\ No newline at end of file
+cov-configure --template --compiler arm-none-eabi-gcc --comptype gcc
diff --git a/covsubmit.sh b/covsubmit.sh
new file mode 100755
index 000000000..daa8d203d
--- /dev/null
+++ b/covsubmit.sh
@@ -0,0 +1,31 @@
+#!/bin/bash
+
+set -e
+. .coverity.conf || exit 1
+
+pre_submit_hook
+
+## delete all previous tarballs
+rm proxmark3.all.*.tgz
+
+VERSION="0.1.$(date --date now +%H%M)"
+TODAY="$(date --date now +%Y%m%d.%H%M)"
+DESCNAME="manual_by_$NICKNAME.$TODAY"
+FILENAME="proxmark3.all.$TODAY.tgz"
+LOGFILENAME="${FILENAME/.tgz/.log}"
+
+## create tarball
+tar cfz "$FILENAME" "$COVDIR" || exit $?
+echo "Coverity build file is ready"
+
+## upload tarball to Coverity.com
+curl --progress-bar --fail \
+  --form token="$COVTOKEN" \
+  --form email="$COVLOGIN" \
+  --form file="@$FILENAME" \
+  --form version="$VERSION" \
+  --form description="$DESCNAME" \
+  https://scan.coverity.com/builds?project=Proxmark3+RRG+Iceman+repo | tee -a "${LOGFILENAME}" ; test "${PIPESTATUS[0]}" -eq 0  || exit $?
+echo "tarball uploaded to Coverity for analyse"
+
+post_submit_hook