github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 05:43:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Avoid useless loop by moving check to the default case

Browse source
This commit is contained in:
DidierA 2023-07-19 21:46:20 +02:00
commit 8543db11b5
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
client/src/cmdhflist.c
View file

@ -1264,13 +1264,6 @@ void annotateMfPlus(char *exp, size_t size, uint8_t *cmd, uint8_t cmdsize) {
data_size = cmdsize - (data - cmd); data_size = cmdsize - (data - cmd);
} }
// Messages for commands that do not need args are treated first
const char *annotation = mfpGetAnnotationForCode(cmd[pos]) ;
if (annotation != NULL) {
snprintf(exp, size, "%s", annotation) ;
break ;
}
switch (cmd[pos]) { switch (cmd[pos]) {
case MFP_AUTHENTICATEFIRST: case MFP_AUTHENTICATEFIRST:
case MFP_AUTHENTICATEFIRST_VARIANT: case MFP_AUTHENTICATEFIRST_VARIANT:
@ -1407,7 +1400,13 @@ void annotateMfPlus(char *exp, size_t size, uint8_t *cmd, uint8_t cmdsize) {
break; break;
default: default:
found_annotation = false; // Messages for commands that do not need args are treated here
const char *annotation = mfpGetAnnotationForCode(cmd[pos]) ;
if (annotation != NULL) {
snprintf(exp, size, "%s", annotation) ;
} else {
found_annotation = false;
}
break; break;
} }
if (found_annotation) { if (found_annotation) {