github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-14 18:48:13 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

wrong handling of array sizes

Browse source
This commit is contained in:
iceman1001 2024-01-26 23:06:01 +01:00
commit 6104086374
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
client/src/cmdhfxerox.c
View file

@ -752,10 +752,10 @@ static int CmdHFXeroxInfo(const char *Cmd) {
PrintAndLogEx(SUCCESS, " UID..... %s", sprint_hex(card.uid, card.uidlen));
PrintAndLogEx(SUCCESS, " ATQB.... %s", sprint_hex(card.atqb, sizeof(card.atqb)));
uint8_t data[sizeof(info_blocks) * XEROX_BLOCK_SIZE] = {0};
uint8_t data[ARRAYLEN(info_blocks) * XEROX_BLOCK_SIZE] = {0};
// special blocks to read.
for (int i = 0; i < sizeof(i); i++) {
for (int i = 0; i < ARRAYLEN(info_blocks); i++) {
status = read_xerox_block(&card, info_blocks[i], data + (i * XEROX_BLOCK_SIZE));
if (status != PM3_SUCCESS) {
@ -960,13 +960,12 @@ static int CmdHFXeroxView(const char *Cmd) {
PrintAndLogEx(INFO, "File size %zu bytes, file blocks %d (0x%x)", bytes_read, blockno, blockno);
}
// 5 different blocks is used
uint8_t tmp[5 * XEROX_BLOCK_SIZE] = {0};
uint8_t tmp[ARRAYLEN(info_blocks) * XEROX_BLOCK_SIZE] = {0};
for (uint8_t i = 0; i < ARRAYLEN(info_blocks); i++) {
memcpy(tmp + (i * XEROX_BLOCK_SIZE), dump + (info_blocks[i] * XEROX_BLOCK_SIZE), XEROX_BLOCK_SIZE);
}
xerox_print_info(tmp);
xerox_print_info(tmp);
xerox_print_hdr();
xerox_print(dump, bytes_read, dense_output);
xerox_print_footer();