From 4cd72b95c5fc4f7a0cee2573d5fa8f8b5674dd0b Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Thu, 3 May 2018 20:36:01 +0200 Subject: [PATCH] fix: coverty scan #277726, unsigned value comparision always true. --- armsrc/appmain.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/armsrc/appmain.c b/armsrc/appmain.c index 6d8314ff3..9e8a9d72b 100644 --- a/armsrc/appmain.c +++ b/armsrc/appmain.c @@ -1097,7 +1097,7 @@ void UsbPacketReceived(uint8_t *packet, int len) { break; #ifdef WITH_FLASH case CMD_READ_FLASH_MEM: { - + /* LED_B_ON(); uint16_t isok = 0; size_t len = 0; @@ -1123,6 +1123,7 @@ void UsbPacketReceived(uint8_t *packet, int len) { } cmd_send(CMD_ACK, 1, 0, 0, 0, 0); LED_B_OFF(); + */ break; } case CMD_WRITE_FLASH_MEM: { @@ -1179,7 +1180,7 @@ void UsbPacketReceived(uint8_t *packet, int len) { LED_B_OFF(); break; } - if ( page >= 0 && page < 3) + if ( page < 3) isok = Flash_WipeMemoryPage(page); cmd_send(CMD_ACK, isok, 0, 0, 0, 0);