github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 05:43:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

FIX: Coverity , Argument can't be negative, CID #121323, ftell(f) can be negative, not allowed in malloc.

Browse source 
FIX: forgot to close the filehandle :(
This commit is contained in:
iceman1001 2016-01-12 22:47:48 +01:00
commit 4bb17c6633
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
client/cmdhficlass.c
View file

@ -286,10 +286,10 @@ int CmdHFiClassELoad(const char *Cmd) {
if (fsize < 0) { if (fsize < 0) {
prnlog("Error, when getting filesize"); prnlog("Error, when getting filesize");
fclose(f);
return 1; return 1;
} }
uint8_t *dump = malloc(fsize); uint8_t *dump = malloc(fsize);
size_t bytes_read = fread(dump, 1, fsize, f); size_t bytes_read = fread(dump, 1, fsize, f);
@ -1509,6 +1509,12 @@ static int loadKeys(char *filename) {
long fsize = ftell(f); long fsize = ftell(f);
fseek(f, 0, SEEK_SET); fseek(f, 0, SEEK_SET);
if ( fsize < 0 ) {
PrintAndLog("Error, when getting filesize");
fclose(f);
return 1;
}
uint8_t *dump = malloc(fsize); uint8_t *dump = malloc(fsize);
size_t bytes_read = fread(dump, 1, fsize, f); size_t bytes_read = fread(dump, 1, fsize, f);