From 49c764de8c3047ccfc4ffa76388dfd45145bb366 Mon Sep 17 00:00:00 2001 From: iceman1001 Date: Sun, 2 May 2021 16:18:02 +0200 Subject: [PATCH] fix proper null-terminator in filename. Thanks to @metalauricle --- armsrc/Standalone/hf_iceclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/armsrc/Standalone/hf_iceclass.c b/armsrc/Standalone/hf_iceclass.c index ee34b98e8..5b64f174b 100644 --- a/armsrc/Standalone/hf_iceclass.c +++ b/armsrc/Standalone/hf_iceclass.c @@ -163,6 +163,7 @@ static void save_to_flash(uint8_t *data, uint16_t datalen, char *filename) { rdv40_spiffs_lazy_mount(); char fn[SPIFFS_OBJ_NAME_LEN]; + memset(fn, 0, sizeof(fn)); if (filename == NULL) { sprintf(fn, "iclass-%02X%02X%02X%02X%02X%02X%02X%02X.bin", @@ -170,7 +171,7 @@ static void save_to_flash(uint8_t *data, uint16_t datalen, char *filename) { data[4], data[5], data[6], data[7] ); } else { - int fnlen = MIN(strlen(filename), SPIFFS_OBJ_NAME_LEN); + int fnlen = MIN(strlen(filename), SPIFFS_OBJ_NAME_LEN - 1); // if the given name len longer than buffer allows, cut it down to size memcpy(fn, filename, fnlen); }