github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-14 18:48:13 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

coverity migth consider this to be better

Browse source
This commit is contained in:
iceman1001 2023-07-24 00:14:56 +02:00
commit 300d274d43
3 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
client/src/flash.c
View file

@ -240,7 +240,8 @@ static int print_and_validate_version(struct version_information_t *vi) {
return PM3_EFILE;
}
char temp[PM3_CMD_DATA_SIZE - 12]; // same limit as for ARM image
// same limit as for ARM image
char temp[PM3_CMD_DATA_SIZE - 12] = {0};
FormatVersionInformation(temp, sizeof(temp), "", vi);
PrintAndLogEx(SUCCESS, _CYAN_("ELF file version") _YELLOW_(" %s"), temp);

8
client/src/proxendian.h
View file

@ -53,11 +53,15 @@
#else
static inline uint16_t le16(uint16_t v) {
return (v >> 8) | (v << 8);
return (uint16_t)(
(v >> 8) | (v << 8)
);
}
static inline uint32_t le32(uint32_t v) {
return (le16(v) << 16) | (le16(v >> 16));
return (uint32_t)(
(le16(v) << 16) | (le16(v >> 16))
);
}
#endif // HOST_LITTLE_ENDIAN