fix out-of-bounds access

This commit is contained in:
iceman1001 2021-06-20 07:49:41 +02:00
commit 2f432788cf

View file

@ -2445,7 +2445,7 @@ static int CmdHF14ADesGetUID(const char *Cmd) {
uint8_t uidlen = 16; uint8_t uidlen = 16;
// Get datalen <uid len> + <crclen> by removing padding. // Get datalen <uid len> + <crclen> by removing padding.
while ((uidlen > 0) && (uid[uidlen] == 0x00)) while ((uidlen > 0) && (uid[uidlen - 1] == 0x00))
uidlen--; uidlen--;
if (tag->authentication_scheme == AS_LEGACY) if (tag->authentication_scheme == AS_LEGACY)
@ -2458,7 +2458,6 @@ static int CmdHF14ADesGetUID(const char *Cmd) {
else else
uidlen = 7; uidlen = 7;
// PrintAndLogEx(SUCCESS, " UID: " _GREEN_("%s"), sprint_hex(uid, sizeof(uid)));
PrintAndLogEx(SUCCESS, " UID: " _GREEN_("%s"), sprint_hex(uid, uidlen)); PrintAndLogEx(SUCCESS, " UID: " _GREEN_("%s"), sprint_hex(uid, uidlen));
return res; return res;
} }