fix some CodeQL warnings

This commit is contained in:
Philippe Teuwen 2022-02-15 16:01:23 +01:00
commit 160245e0d5

View file

@ -147,8 +147,10 @@ void printarr(const char *name, uint8_t *arr, int len) {
char *output = calloc(outsize, sizeof(char)); char *output = calloc(outsize, sizeof(char));
cx = snprintf(output, outsize, "uint8_t %s[] = {", name); cx = snprintf(output, outsize, "uint8_t %s[] = {", name);
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
if (cx < outsize)
cx += snprintf(output + cx, outsize - cx, "0x%02x,", *(arr + i)); //5 bytes per byte cx += snprintf(output + cx, outsize - cx, "0x%02x,", *(arr + i)); //5 bytes per byte
} }
if (cx < outsize)
snprintf(output + cx, outsize - cx, "};"); snprintf(output + cx, outsize - cx, "};");
PrintAndLogEx(INFO, output); PrintAndLogEx(INFO, output);
free(output); free(output);
@ -165,11 +167,15 @@ void printarr_human_readable(const char *title, uint8_t *arr, int len) {
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
if (i % 16 == 0) { if (i % 16 == 0) {
if (i == 0) if (i == 0) {
if (cx < outsize)
cx += snprintf(output + cx, outsize - cx, "%02x| ", i); cx += snprintf(output + cx, outsize - cx, "%02x| ", i);
else } else {
if (cx < outsize)
cx += snprintf(output + cx, outsize - cx, "\n%02x| ", i); cx += snprintf(output + cx, outsize - cx, "\n%02x| ", i);
} }
}
if (cx < outsize)
cx += snprintf(output + cx, outsize - cx, "%02x ", *(arr + i)); cx += snprintf(output + cx, outsize - cx, "%02x ", *(arr + i));
} }
PrintAndLogEx(INFO, output); PrintAndLogEx(INFO, output);