github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-21 05:43:48 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

cppcheck fixes

Browse source
This commit is contained in:
iceman1001 2022-01-06 20:49:35 +01:00
commit 0b4d584dd7
6 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
client/src/cmdhfmfdes.c
View file

@ -815,7 +815,7 @@ static void DesFill2bPattern(
static int AuthCheckDesfire(DesfireContext_t *dctx,
DesfireSecureChannel secureChannel,
uint8_t *aid,
const uint8_t *aid,
uint8_t deskeyList[MAX_KEYS_LIST_LEN][8], uint32_t deskeyListLen,
uint8_t aeskeyList[MAX_KEYS_LIST_LEN][16], uint32_t aeskeyListLen,
uint8_t k3kkeyList[MAX_KEYS_LIST_LEN][24], uint32_t k3kkeyListLen,

2
client/src/cmdhfmfhard.c
View file

@ -152,7 +152,7 @@ static inline void set_bit24(uint32_t *bitarray, uint32_t index) {
bitarray[index >> 5] |= 0x80000000 >> (index & 0x0000001f);
}
static inline uint32_t test_bit24(uint32_t *bitarray, uint32_t index) {
static inline uint32_t test_bit24(const uint32_t *bitarray, uint32_t index) {
return bitarray[index >> 5] & (0x80000000 >> (index & 0x0000001f));
}

10
client/src/cmdhfmfp.c
View file

@ -1213,9 +1213,11 @@ static int CmdHFMFPChk(const char *Cmd) {
if (dict_filenamelen) {
uint32_t keycnt = 0;
res = loadFileDICTIONARYEx((char *)dict_filename, keyList, sizeof(keyList), NULL, 16, &keycnt, 0, &endFilePosition, true);
keyListLen = keycnt;
if (endFilePosition)
if (res == PM3_SUCCESS && endFilePosition) {
keyListLen = keycnt;
PrintAndLogEx(SUCCESS, "First part of dictionary successfully loaded.");
}
}
if (keyListLen == 0) {
@ -1255,7 +1257,9 @@ static int CmdHFMFPChk(const char *Cmd) {
uint32_t keycnt = 0;
res = loadFileDICTIONARYEx((char *)dict_filename, keyList, sizeof(keyList), NULL, 16, &keycnt, endFilePosition, &endFilePosition, false);
keyListLen = keycnt;
if (res == PM3_SUCCESS && endFilePosition) {
keyListLen = keycnt;
}
continue;
}
break;

2
client/src/cmdhfmfu.c
View file

@ -475,7 +475,7 @@ static int ul_print_default(uint8_t *data, uint8_t *real_uid) {
return PM3_SUCCESS;
}
static int ndef_get_maxsize(uint8_t *data) {
static int ndef_get_maxsize(const uint8_t *data) {
// no NDEF message
if (data[0] != 0xE1)
return 0;

2
client/src/cmdhfseos.c
View file

@ -24,7 +24,7 @@
static int CmdHelp(const char *Cmd);
static uint16_t get_sw(uint8_t *d, uint8_t n) {
static uint16_t get_sw(const uint8_t *d, uint8_t n) {
if (n < 2)
return 0;

2
client/src/cmdhfst25ta.c
View file

@ -103,7 +103,7 @@ static void print_st25ta_system_info(uint8_t *d, uint8_t n) {
*/
}
static uint16_t get_sw(uint8_t *d, uint8_t n) {
static uint16_t get_sw(const uint8_t *d, uint8_t n) {
if (n < 2)
return 0;