fix few missing declarations -> static or add include file

client/cmddata.c

@@ -508,7 +508,7 @@ int CmdGetBitStream(const char *Cmd) {
     RepaintGraphWindow();
     return PM3_SUCCESS;
 }
-int CmdConvertBitStream(const char *Cmd) {
+static int CmdConvertBitStream(const char *Cmd) {
 
     if (isGraphBitstream()) {
         convertGraphFromBitstream();

client/cmdhf.c

@@ -8,7 +8,7 @@
 //-----------------------------------------------------------------------------
 // High frequency commands
 //-----------------------------------------------------------------------------
-//#include "cmdhf.h"
+#include "cmdhf.h"
 
 #include <ctype.h>        // tolower
 

client/cmdhw.c

@@ -366,7 +366,7 @@ static void lookupChipID(uint32_t iChipID, uint32_t mem_used) {
     PrintAndLogEx(NORMAL, "  --= Nonvolatile Program Memory Type: %s", asBuff);
 }
 
-int CmdDbg(const char *Cmd) {
+static int CmdDbg(const char *Cmd) {
 
     char ctmp = tolower(param_getchar(Cmd, 0));
     if (strlen(Cmd) < 1 || ctmp == 'h') return usage_dbg();

client/cmdlf.c

@@ -213,7 +213,7 @@ static int usage_lf_tune(void) {
     return PM3_SUCCESS;
 }
 
-int CmdLFTune(const char *Cmd) {
+static int CmdLFTune(const char *Cmd) {
     int iter = 0;
     uint8_t divisor =  LF_DIVISOR_125;//Frequency divisor
     bool errors = false;

client/cmdlfhitag.c

@@ -8,6 +8,8 @@
 // Low frequency Hitag support
 //-----------------------------------------------------------------------------
 
+#include "cmdlfhitag.h"
+
 #include <ctype.h>
 
 #include "cmdparser.h"    // command_t

client/cmdlfnedap.c

@@ -426,7 +426,7 @@ static int CmdLfNedapGen(const char *Cmd) {
     return PM3_SUCCESS;
 }
 
-int CmdLFNedapClone(const char *Cmd) {
+static int CmdLFNedapClone(const char *Cmd) {
     uint8_t max;
     uint32_t blocks[5] = {0};
 

client/fileutils.c

@@ -74,7 +74,8 @@ int fileExists(const char *filename) {
  * @param filename
  * @return
  */
-bool is_regular_file(const char *filename) {
+/*
+static bool is_regular_file(const char *filename) {
 #ifdef _WIN32
     struct _stat st;
     if (_stat(filename, &st) == -1)
@@ -87,12 +88,14 @@ bool is_regular_file(const char *filename) {
 #endif
     return S_ISREG(st.st_mode) != 0;
 }
+*/
+
 /**
  * @brief checks if path is directory.
  * @param filename
  * @return
  */
-bool is_directory(const char *filename) {
+static bool is_directory(const char *filename) {
 #ifdef _WIN32
     struct _stat st;
     if (_stat(filename, &st) == -1)

client/loclass/ikeys.c

@@ -58,6 +58,8 @@ From "Dismantling iclass":
     output of hash0 is the diversified card key k = k [0] , . . . , k [7] ∈ (F 82 ) 8 .
 
 **/
+#include "ikeys.h"
+
 #include <stdint.h>
 #include <stdbool.h>
 #include <string.h>

client/loclass/ikeys.h

@@ -38,6 +38,7 @@
 #ifndef IKEYS_H
 #define IKEYS_H
 
+#include <inttypes.h>
 
 /**
  * @brief

client/proxmark3.c

@@ -56,7 +56,7 @@ static void showBanner(void) {
     g_printAndLog = PRINTANDLOG_PRINT | PRINTANDLOG_LOG;
 }
 
-int check_comm(void) {
+static int check_comm(void) {
     // If communications thread goes down. Device disconnected then this should hook up PM3 again.
     if (IsCommunicationThreadDead() && session.pm3_present) {
         rl_set_prompt(PROXPROMPT_OFFLINE);
@@ -86,7 +86,7 @@ int push_cmdscriptfile(char *path, bool stayafter) {
     return PM3_SUCCESS;
 }
 
-FILE *current_cmdscriptfile() {
+static FILE *current_cmdscriptfile() {
     return cmdscriptfile[cmdscriptfile_idx];
 }
 

client/wiegand_formats.c

@@ -650,7 +650,7 @@ bool HIDPack(int format_idx, wiegand_card_t *card, wiegand_message_t *packed) {
     return FormatTable[format_idx].Pack(card, packed);
 }
 
-void HIDDisplayUnpackedCard(wiegand_card_t *card, const cardformat_t format) {
+static void HIDDisplayUnpackedCard(wiegand_card_t *card, const cardformat_t format) {
 
     /*
         PrintAndLogEx(SUCCESS, "       Format: %s (%s)", format.Name, format.Descrp);

client/wiegand_formatutils.c

@@ -120,7 +120,7 @@ bool set_nonlinear_field(wiegand_message_t *data, uint64_t value, uint8_t numBit
     return result;
 }
 
-uint8_t get_length_from_header(wiegand_message_t *data) {
+static uint8_t get_length_from_header(wiegand_message_t *data) {
     uint8_t len = 0;
     uint32_t hfmt = 0; // for calculating card length