github/RRG-Proxmark3
1
0
Fork 0
mirror of https://github.com/RfidResearchGroup/proxmark3.git synced 2025-08-20 13:23:51 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

coverity fixes for my latest changes.

Browse source 
Forgot some breaks in 7816 annotation, and  presco used an uninitalized char array.
This commit is contained in:
iceman1001 2016-03-22 08:40:20 +01:00
commit 06eb3b1a8c
3 changed files with 18 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
armsrc/crapto1.h
View file

@ -88,7 +88,7 @@ static inline int filter(uint32_t const x)
f |= 0x3c8b0 >> (x >> 8 & 0xf) & 4; f |= 0x3c8b0 >> (x >> 8 & 0xf) & 4;
f |= 0x1e458 >> (x >> 12 & 0xf) & 2; f |= 0x1e458 >> (x >> 12 & 0xf) & 2;
f |= 0x0d938 >> (x >> 16 & 0xf) & 1; f |= 0x0d938 >> (x >> 16 & 0xf) & 1;
return BIT(0xEC57E80A, f); return BIT(0xEC57E80A, 0xf);
} }
#ifdef __cplusplus #ifdef __cplusplus
} }

2
client/cmdlfpresco.c
View file

@ -45,6 +45,8 @@ int GetWiegandFromPresco(const char *Cmd, uint32_t *sitecode, uint32_t *usercode
uint8_t cmdp = 0; uint8_t cmdp = 0;
char id[11]; char id[11];
int stringlen = 0; int stringlen = 0;
memset(id, 0x00, sizeof(id));
while(param_getchar(Cmd, cmdp) != 0x00) { while(param_getchar(Cmd, cmdp) != 0x00) {
switch(param_getchar(Cmd, cmdp)) { switch(param_getchar(Cmd, cmdp)) {
case 'h': case 'h':

1
include/common.h
View file

@ -29,6 +29,5 @@ typedef unsigned char byte_t;
#ifndef ABS #ifndef ABS
# define ABS(a) ( ((a)<0) ? -(a) : (a) ) # define ABS(a) ( ((a)<0) ? -(a) : (a) )
#endif #endif
#define RAMFUNC __attribute((long_call, section(".ramfunc"))) #define RAMFUNC __attribute((long_call, section(".ramfunc")))
#endif #endif