github/Ombi
1
0
Fork 0
mirror of https://github.com/Ombi-app/Ombi.git synced 2025-08-20 13:23:20 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed an issue where we could grab the wrong imdbid

Browse source
This commit is contained in:
tidusjar 2020-12-17 21:42:58 +00:00
commit e6751903a7
1 changed files with 18 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/Ombi.Schedule/Jobs/Ombi/RefreshMetadata.cs
View file

@ -128,7 +128,7 @@ namespace Ombi.Schedule.Jobs.Ombi
if (!hasImdb) if (!hasImdb)
{ {
var id = await GetImdbId(hasTheMovieDb, hasTvDbId, show.Title, show.TheMovieDbId, show.TvDbId); var id = await GetImdbId(hasTheMovieDb, hasTvDbId, show.Title, show.TheMovieDbId, show.TvDbId, RequestType.TvShow);
show.ImdbId = id; show.ImdbId = id;
_plexRepo.UpdateWithoutSave(show); _plexRepo.UpdateWithoutSave(show);
} }
@ -162,7 +162,7 @@ namespace Ombi.Schedule.Jobs.Ombi
if (!hasImdb) if (!hasImdb)
{ {
var id = await GetImdbId(hasTheMovieDb, hasTvDbId, show.Title, show.TheMovieDbId, show.TvDbId); var id = await GetImdbId(hasTheMovieDb, hasTvDbId, show.Title, show.TheMovieDbId, show.TvDbId, RequestType.TvShow);
show.ImdbId = id; show.ImdbId = id;
_embyRepo.UpdateWithoutSave(show); _embyRepo.UpdateWithoutSave(show);
} }
@ -193,7 +193,7 @@ namespace Ombi.Schedule.Jobs.Ombi
if (!hasImdb) if (!hasImdb)
{ {
var imdbId = await GetImdbId(hasTheMovieDb, false, movie.Title, movie.TheMovieDbId, string.Empty); var imdbId = await GetImdbId(hasTheMovieDb, false, movie.Title, movie.TheMovieDbId, string.Empty, RequestType.Movie);
movie.ImdbId = imdbId; movie.ImdbId = imdbId;
_plexRepo.UpdateWithoutSave(movie); _plexRepo.UpdateWithoutSave(movie);
} }
@ -247,7 +247,7 @@ namespace Ombi.Schedule.Jobs.Ombi
if (!movie.HasImdb) if (!movie.HasImdb)
{ {
var imdbId = await GetImdbId(movie.HasTheMovieDb, false, movie.Title, movie.TheMovieDbId, string.Empty); var imdbId = await GetImdbId(movie.HasTheMovieDb, false, movie.Title, movie.TheMovieDbId, string.Empty, RequestType.Movie);
movie.ImdbId = imdbId; movie.ImdbId = imdbId;
_embyRepo.UpdateWithoutSave(movie); _embyRepo.UpdateWithoutSave(movie);
} }
@ -305,7 +305,7 @@ namespace Ombi.Schedule.Jobs.Ombi
return string.Empty; return string.Empty;
} }
private async Task<string> GetImdbId(bool hasTheMovieDb, bool hasTvDbId, string title, string theMovieDbId, string tvDbId) private async Task<string> GetImdbId(bool hasTheMovieDb, bool hasTvDbId, string title, string theMovieDbId, string tvDbId, RequestType type)
{ {
_log.LogInformation("The media item {0} does not have a ImdbId, searching for ImdbId", title); _log.LogInformation("The media item {0} does not have a ImdbId, searching for ImdbId", title);
// Looks like TV Maze does not provide the moviedb id, neither does the TV endpoint on TheMovieDb // Looks like TV Maze does not provide the moviedb id, neither does the TV endpoint on TheMovieDb
@ -314,13 +314,22 @@ namespace Ombi.Schedule.Jobs.Ombi
_log.LogInformation("The show {0} has TheMovieDbId but not ImdbId, searching for ImdbId", title); _log.LogInformation("The show {0} has TheMovieDbId but not ImdbId, searching for ImdbId", title);
if (int.TryParse(theMovieDbId, out var id)) if (int.TryParse(theMovieDbId, out var id))
{ {
switch (type)
{
case RequestType.TvShow:
var result = await _movieApi.GetTvExternals(id); var result = await _movieApi.GetTvExternals(id);
return result.imdb_id; return result.imdb_id;
case RequestType.Movie:
var r = await _movieApi.GetMovieInformationWithExtraInfo(id);
return r.ImdbId;
default:
break;
}
} }
} }
if (hasTvDbId) if (hasTvDbId && type == RequestType.TvShow)
{ {
_log.LogInformation("The show {0} has tvdbid but not ImdbId, searching for ImdbId", title); _log.LogInformation("The show {0} has tvdbid but not ImdbId, searching for ImdbId", title);
if (int.TryParse(tvDbId, out var id)) if (int.TryParse(tvDbId, out var id))