github/Ombi
1
0
Fork 0
mirror of https://github.com/Ombi-app/Ombi.git synced 2025-07-05 12:45:45 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: filter out excluded notification agents from user preferences

Browse source 
The webhook notification field was inconsistently showing up for some users despite being excluded in the backend. This was happening because the frontend was displaying all notification preferences without filtering out the excluded agents.

Changes:
- Added excludedAgents array to match backend's excluded notification types
- Filter notification preferences in both edit and create user flows
- Prevents webhook, email, and mobile notification fields from appearing in user preferences

This change aligns the frontend behavior with the backend's intended design where webhook notifications are managed globally rather than per-user.

Fixes #5196
This commit is contained in:
tidusjar 2025-05-14 22:16:34 +01:00
parent acb679f99d
commit c9ab4f4f9f
1 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/Ombi/ClientApp/src/app/usermanagement/usermanagement-user.component.ts
View file

@ -37,6 +37,13 @@ export class UserManagementUserComponent implements OnInit {
private appUrl: string = this.customizationFacade.appUrl();
private accessToken: string;
// List of excluded notification agents that should not be shown in user preferences
private readonly excludedAgents = [
INotificationAgent.Email,
INotificationAgent.Mobile,
INotificationAgent.Webhook
];
constructor(private identityService: IdentityService,
private notificationService: MessageService,
private router: Router,
@ -74,9 +81,15 @@ export class UserManagementUserComponent implements OnInit {
}
});
if(this.edit) {
this.identityService.getNotificationPreferencesForUser(this.userId).subscribe(x => this.notificationPreferences = x);
this.identityService.getNotificationPreferencesForUser(this.userId).subscribe(x => {
// Filter out excluded notification agents
this.notificationPreferences = x.filter(pref => !this.excludedAgents.includes(pref.agent));
});
} else {
this.identityService.getNotificationPreferences().subscribe(x => this.notificationPreferences = x);
this.identityService.getNotificationPreferences().subscribe(x => {
// Filter out excluded notification agents
this.notificationPreferences = x.filter(pref => !this.excludedAgents.includes(pref.agent));
});
}
this.sonarrService.getQualityProfilesWithoutSettings().subscribe(x => {
this.sonarrQualities = x;