started adding some more unit tests #1596

src/Ombi.Core.Tests/Rule/Search/CouchPotatoCacheRuleTests.cs

@@ -0,0 +1,64 @@
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Linq.Expressions;
+using System.Threading.Tasks;
+using Moq;
+using NUnit.Framework;
+using Ombi.Core.Models.Search;
+using Ombi.Core.Rule.Rules.Search;
+using Ombi.Store.Entities;
+using Ombi.Store.Repository;
+
+namespace Ombi.Core.Tests.Rule.Search
+{
+    public class CouchPotatoCacheRuleTests
+    {
+        [SetUp]
+        public void Setup()
+        {
+            ContextMock = new Mock<IRepository<CouchPotatoCache>>();
+            Rule = new CouchPotatoCacheRule(ContextMock.Object);
+
+        }
+
+        private CouchPotatoCacheRule Rule { get; set; }
+        private Mock<IRepository<CouchPotatoCache>> ContextMock { get; set; }
+
+        [Test]
+        public async Task Should_ReturnApproved_WhenMovieIsInCouchPotato()
+        {
+            var list = new CouchPotatoCache
+            {
+                TheMovieDbId = 123
+            };
+            
+            ContextMock.Setup(x => x.FirstOrDefaultAsync(It.IsAny<Expression<Func<CouchPotatoCache, bool>>>())).ReturnsAsync(list);
+
+            var request = new SearchMovieViewModel { Id = 123 };
+            var result =await  Rule.Execute(request);
+
+            Assert.True(result.Success);
+            Assert.True(request.Approved);
+        }
+
+
+        [Test]
+        public async Task Should_ReturnNotApproved_WhenMovieIsNotCouchPotato()
+        {
+            var list = DbHelper.GetQueryableMockDbSet(new CouchPotatoCache
+            {
+                TheMovieDbId = 000012
+            });
+
+            ContextMock.Setup(x => x.GetAll()).Returns(list);
+
+            var request = new SearchMovieViewModel { Id = 123 };
+            var result = await Rule.Execute(request);
+
+            Assert.True(result.Success);
+            Assert.False(request.Approved);
+        }
+    }
+}

src/Ombi.Core.Tests/Rule/Search/EmbyAvailabilityRuleTests.cs

@@ -0,0 +1,50 @@
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using Moq;
+using NUnit.Framework;
+using Ombi.Core.Models.Search;
+using Ombi.Core.Rule.Rules.Search;
+using Ombi.Store.Entities;
+using Ombi.Store.Repository;
+using Ombi.Store.Repository.Requests;
+
+namespace Ombi.Core.Tests.Rule.Search
+{
+    public class EmbyAvailabilityRuleTests
+    {
+        [SetUp]
+        public void Setup()
+        {
+            ContextMock = new Mock<IEmbyContentRepository>();
+            Rule = new EmbyAvailabilityRule(ContextMock.Object);
+        }
+
+        private EmbyAvailabilityRule Rule { get; set; }
+        private Mock<IEmbyContentRepository> ContextMock { get; set; }
+
+        [Test]
+        public async Task Movie_ShouldBe_Available_WhenFoundInEmby()
+        {
+            ContextMock.Setup(x => x.Get(It.IsAny<string>())).ReturnsAsync(new EmbyContent
+            {
+                ProviderId = "123"
+            });
+            var search = new SearchMovieViewModel();
+            var result = await Rule.Execute(search);
+
+            Assert.True(result.Success);
+            Assert.True(search.Available);
+        }
+
+        [Test]
+        public async Task Movie_ShouldBe_NotAvailable_WhenNotFoundInEmby()
+        {
+            ContextMock.Setup(x => x.Get(It.IsAny<string>())).Returns(Task.FromResult(default(EmbyContent)));
+            var search = new SearchMovieViewModel();
+            var result = await Rule.Execute(search);
+
+            Assert.True(result.Success);
+            Assert.False(search.Available);
+        }
+    }
+}

src/Ombi.Core/Rule/Rules/Search/CouchPotatoCacheRule.cs

@@ -5,24 +5,25 @@ using Ombi.Core.Models.Search;
 using Ombi.Core.Rule.Interfaces;
 using Ombi.Store.Context;
 using Ombi.Store.Entities;
+using Ombi.Store.Repository;
 
 namespace Ombi.Core.Rule.Rules.Search
 {
     public class CouchPotatoCacheRule : BaseSearchRule, IRules<SearchViewModel>
     {
-        public CouchPotatoCacheRule(IOmbiContext ctx)
+        public CouchPotatoCacheRule(IRepository<CouchPotatoCache> ctx)
         {
             _ctx = ctx;
         }
 
-        private readonly IOmbiContext _ctx;
+        private readonly IRepository<CouchPotatoCache> _ctx;
 
         public async Task<RuleResult> Execute(SearchViewModel obj)
         {
             if (obj.Type == RequestType.Movie)
             {
                 // Check if it's in Radarr
-                var result = await _ctx.CouchPotatoCache.FirstOrDefaultAsync(x => x.TheMovieDbId == obj.Id);
+                var result = await _ctx.FirstOrDefaultAsync(x => x.TheMovieDbId == obj.Id);
                 if (result != null)
                 {
                     obj.Approved =

src/Ombi.Schedule.Tests/PlexAvailabilityCheckerTests.cs

@@ -1,5 +1,7 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
+using System.Linq.Expressions;
 using System.Threading.Tasks;
 using Castle.Components.DictionaryAdapter;
 using Hangfire;
@@ -103,6 +105,7 @@ namespace Ombi.Schedule.Tests
                     SeasonNumber = 2
                 }
             }.AsQueryable);
+            _repo.Setup(x => x.Include(It.IsAny<IQueryable<PlexEpisode>>(),It.IsAny<Expression<Func<PlexEpisode, PlexContent>>>()));
 
             await Checker.Start();
 

src/Ombi.Schedule/Jobs/Plex/PlexAvailabilityChecker.cs

@@ -103,7 +103,7 @@ namespace Ombi.Schedule.Jobs.Plex
                         NotificationType = NotificationType.RequestAvailable,
                         RequestId = movie.Id,
                         RequestType = RequestType.Movie,
-                        Recipient = movie.RequestedUser.Email
+                        Recipient = movie.RequestedUser != null ? movie.RequestedUser.Email : string.Empty
                     }));
                 }
             }

src/Ombi.Tests/IdentityControllerTests.cs

@@ -0,0 +1,132 @@
+
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
+using AutoMapper;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Features.Authentication;
+using Microsoft.AspNetCore.Identity;
+using Microsoft.AspNetCore.Identity.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using Moq;
+using NUnit.Framework;
+using Ombi.Api.Emby;
+using Ombi.Api.Plex;
+using Ombi.Config;
+using Ombi.Controllers;
+using Ombi.Core.Authentication;
+using Ombi.Core.Settings;
+using Ombi.Core.Settings.Models.External;
+using Ombi.Models;
+using Ombi.Notifications;
+using Ombi.Schedule.Jobs.Ombi;
+using Ombi.Settings.Settings.Models;
+using Ombi.Settings.Settings.Models.Notifications;
+using Ombi.Store.Context;
+using Ombi.Store.Entities;
+
+namespace Ombi.Tests
+{
+    [TestFixture]
+    [Ignore("Need to sort out the DB, looks like it's using the real one...")]
+    public class IdentityControllerTests
+    {
+        [SetUp]
+        public void Setup()
+        {
+            _plexApi = new Mock<IPlexApi>();
+            _embyApi = new Mock<IEmbyApi>();
+            _mapper = new Mock<IMapper>();
+            _emailProvider = new Mock<IEmailProvider>();
+            _emailSettings = new Mock<ISettingsService<EmailNotificationSettings>>();
+            _customizationSettings = new Mock<ISettingsService<CustomizationSettings>>();
+            _welcomeEmail = new Mock<IWelcomeEmail>();
+            _embySettings = new Mock<ISettingsService<EmbySettings>>();
+            _plexSettings = new Mock<ISettingsService<PlexSettings>>();
+
+            var services = new ServiceCollection();
+            services.AddEntityFrameworkInMemoryDatabase()
+                .AddDbContext<OmbiContext>();
+            services.AddIdentity<OmbiUser, IdentityRole>()
+                .AddEntityFrameworkStores<OmbiContext>().AddUserManager<OmbiUserManager>();
+
+            services.AddTransient(x => _plexApi.Object);
+            services.AddTransient(x => _embyApi.Object);
+            services.AddTransient(x => _customizationSettings.Object);
+            services.AddTransient(x => _welcomeEmail.Object);
+            services.AddTransient(x => _emailSettings.Object);
+            services.AddTransient(x => _emailProvider.Object);
+            services.AddTransient(x => _mapper.Object);
+            services.AddTransient(x => _embySettings.Object);
+            services.AddTransient(x => _plexSettings.Object);
+
+            services.Configure<IdentityOptions>(options =>
+            {
+                options.Password.RequireDigit = false;
+                options.Password.RequiredLength = 1;
+                options.Password.RequireLowercase = false;
+                options.Password.RequireNonAlphanumeric = false;
+                options.Password.RequireUppercase = false;
+                options.User.AllowedUserNameCharacters = string.Empty;
+            });
+
+            // Taken from https://github.com/aspnet/MusicStore/blob/dev/test/MusicStore.Test/ManageControllerTest.cs (and modified)
+            var context = new DefaultHttpContext();
+            context.Features.Set<IHttpAuthenticationFeature>(new HttpAuthenticationFeature());
+            services.AddSingleton<IHttpContextAccessor>(h => new HttpContextAccessor { HttpContext = context });
+            _serviceProvider = services.BuildServiceProvider();
+            _userManager = _serviceProvider.GetRequiredService<OmbiUserManager>();
+            
+            Controller = new IdentityController(_userManager, _mapper.Object, _serviceProvider.GetService<RoleManager<IdentityRole>>(), _emailProvider.Object,
+                _emailSettings.Object, _customizationSettings.Object,_welcomeEmail.Object);
+        }
+
+        private OmbiUserManager _userManager;
+        private Mock<IEmailProvider> _emailProvider;
+        private Mock<ISettingsService<EmailNotificationSettings>> _emailSettings;
+        private Mock<ISettingsService<CustomizationSettings>> _customizationSettings;
+        private Mock<ISettingsService<EmbySettings>> _embySettings;
+        private Mock<ISettingsService<PlexSettings>> _plexSettings;
+        private Mock<IWelcomeEmail> _welcomeEmail;
+        private Mock<IMapper> _mapper;
+        private Mock<IPlexApi> _plexApi;
+        private Mock<IEmbyApi> _embyApi;
+        private ServiceProvider _serviceProvider;
+
+        private IdentityController Controller { get; set; }
+
+        [Test]
+        public async Task CreateWizardUser_Should_CreateUser_WhenThereAreNoOtherUsers()
+        {
+            var model = new UserAuthModel
+            {
+                Password = "a",
+                Username = "b"
+            };
+
+            var result = await Controller.CreateWizardUser(model);
+
+            Assert.That(result, Is.True);
+        }
+
+        [Test]
+        public async Task CreateWizardUser_ShouldNot_CreateUser_WhenThereAreOtherUsers()
+        {
+            var um = _serviceProvider.GetService<OmbiUserManager>();
+            var r  = await um.CreateAsync(new OmbiUser { UserName = "aaaa",UserType = UserType.LocalUser}, "bbb");
+            var model = new UserAuthModel
+            {
+                Password = "a",
+                Username = "b"
+            };
+
+            var result = await Controller.CreateWizardUser(model);
+
+            Assert.That(result, Is.False);
+        }
+    }
+}

src/Ombi.Tests/Ombi.Tests.csproj

@@ -0,0 +1,23 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>netcoreapp2.0</TargetFramework>
+
+    <IsPackable>false</IsPackable>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.AspNetCore.TestHost" Version="2.0.0" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="2.0.0" />
+    <PackageReference Include="Moq" Version="4.7.99" />
+    <PackageReference Include="Nunit" Version="3.8.1" />
+    <PackageReference Include="NUnit.ConsoleRunner" Version="3.7.0" />
+    <PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
+    <packagereference Include="Microsoft.NET.Test.Sdk" Version="15.0.0"></packagereference>
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\Ombi\Ombi.csproj" />
+  </ItemGroup>
+
+</Project>

src/Ombi.Tests/TestStartup.cs

@@ -0,0 +1,71 @@
+using System;
+using Microsoft.AspNetCore.Builder;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Features.Authentication;
+using Microsoft.AspNetCore.Identity;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using Moq;
+using Ombi.Api.Emby;
+using Ombi.Api.Plex;
+using Ombi.Core.Authentication;
+using Ombi.Core.Settings;
+using Ombi.Core.Settings.Models.External;
+using Ombi.Models.Identity;
+using Ombi.Store.Context;
+using Ombi.Store.Entities;
+using Ombi.Store.Repository;
+
+namespace Ombi.Tests
+{
+    public class TestStartup
+    {
+        public IServiceProvider ConfigureServices(IServiceCollection services)
+        {
+            var _plexApi = new Mock<IPlexApi>();
+            var _embyApi = new Mock<IEmbyApi>();
+            var _tokenSettings = new Mock<IOptions<TokenAuthentication>>();
+            var _embySettings = new Mock<ISettingsService<EmbySettings>>();
+            var _plexSettings = new Mock<ISettingsService<PlexSettings>>();
+            var audit = new Mock<IAuditRepository>();
+            var tokenRepo = new Mock<ITokenRepository>();
+
+            services.AddEntityFrameworkInMemoryDatabase()
+                .AddDbContext<OmbiContext>();
+            services.AddIdentity<OmbiUser, IdentityRole>()
+                .AddEntityFrameworkStores<OmbiContext>().AddUserManager<OmbiUserManager>();
+
+            services.AddTransient(x => _plexApi.Object);
+            services.AddTransient(x => _embyApi.Object);
+            services.AddTransient(x => _tokenSettings.Object);
+            services.AddTransient(x => _embySettings.Object);
+            services.AddTransient(x => _plexSettings.Object);
+            services.AddTransient(x => audit.Object);
+            services.AddTransient(x => tokenRepo.Object);
+            // Taken from https://github.com/aspnet/MusicStore/blob/dev/test/MusicStore.Test/ManageControllerTest.cs (and modified)
+            var context = new DefaultHttpContext();
+            context.Features.Set<IHttpAuthenticationFeature>(new HttpAuthenticationFeature());
+            services.AddSingleton<IHttpContextAccessor>(h => new HttpContextAccessor { HttpContext = context });
+
+
+            services.Configure<IdentityOptions>(options =>
+            {
+                options.Password.RequireDigit = false;
+                options.Password.RequiredLength = 1;
+                options.Password.RequireLowercase = false;
+                options.Password.RequireNonAlphanumeric = false;
+                options.Password.RequireUppercase = false;
+                options.User.AllowedUserNameCharacters = string.Empty;
+            });
+
+            return services.BuildServiceProvider();
+
+        }
+
+        public void Configure(IApplicationBuilder app, IHostingEnvironment env)
+        {
+            
+        }
+    }
+}

src/Ombi.Tests/TokenControllerTests.cs

@@ -0,0 +1,60 @@
+using System.Net.Http;
+using System.Threading.Tasks;
+using AutoMapper;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Features.Authentication;
+using Microsoft.AspNetCore.Identity;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using Moq;
+using NUnit.Framework;
+using Ombi.Api.Emby;
+using Ombi.Api.Plex;
+using Ombi.Controllers;
+using Ombi.Core.Authentication;
+using Ombi.Core.Settings;
+using Ombi.Core.Settings.Models.External;
+using Ombi.Models.Identity;
+using Ombi.Notifications;
+using Ombi.Schedule.Jobs.Ombi;
+using Ombi.Settings.Settings.Models;
+using Ombi.Settings.Settings.Models.Notifications;
+using Ombi.Store.Context;
+using Ombi.Store.Entities;
+using Ombi.Store.Repository;
+using Microsoft.AspNetCore.Hosting.Server;
+using Microsoft.AspNetCore.TestHost;
+using Newtonsoft.Json;
+using Ombi.Models;
+
+namespace Ombi.Tests
+{
+    [TestFixture]
+    [Ignore("TODO")]
+    public class TokenControllerTests
+    {
+        [SetUp]
+        public void Setup()
+        {
+            _testServer = new TestServer(new WebHostBuilder()
+                .UseStartup<TestStartup>());
+            _client = _testServer.CreateClient();
+        }
+
+        private TestServer _testServer;
+        private HttpClient _client;
+        
+
+        [Test]
+        public async Task GetToken_FromValid_LocalUser()
+        {
+            var model = new UserAuthModel
+            {
+                Password = "a",
+                Username = "a"
+            };
+            HttpResponseMessage response = await _client.PostAsync("/api/v1/token", new StringContent(JsonConvert.SerializeObject(model)) );
+        }
+    }
+}

src/Ombi.sln

@@ -82,7 +82,9 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Ombi.Schedule.Tests", "Ombi
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Ombi.Api.CouchPotato", "Ombi.Api.CouchPotato\Ombi.Api.CouchPotato.csproj", "{87D7897D-7C73-4856-A0AA-FF5948F4EA86}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ombi.Api.DogNzb", "Ombi.Api.DogNzb\Ombi.Api.DogNzb.csproj", "{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Ombi.Api.DogNzb", "Ombi.Api.DogNzb\Ombi.Api.DogNzb.csproj", "{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ombi.Tests", "Ombi.Tests\Ombi.Tests.csproj", "{C12F5276-352A-43CF-8E33-400E768E9757}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -214,6 +216,10 @@ Global
 		{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E}.Release|Any CPU.Build.0 = Release|Any CPU
+		{C12F5276-352A-43CF-8E33-400E768E9757}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{C12F5276-352A-43CF-8E33-400E768E9757}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{C12F5276-352A-43CF-8E33-400E768E9757}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{C12F5276-352A-43CF-8E33-400E768E9757}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -244,6 +250,7 @@ Global
 		{BDD8B924-016E-4CDA-9FFA-50B0A34BCD3C} = {6F42AB98-9196-44C4-B888-D5E409F415A1}
 		{87D7897D-7C73-4856-A0AA-FF5948F4EA86} = {9293CA11-360A-4C20-A674-B9E794431BF5}
 		{4F3BF03A-6AAC-4960-A2CD-1EAD7273115E} = {9293CA11-360A-4C20-A674-B9E794431BF5}
+		{C12F5276-352A-43CF-8E33-400E768E9757} = {6F42AB98-9196-44C4-B888-D5E409F415A1}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {192E9BF8-00B4-45E4-BCCC-4C215725C869}

src/Ombi/Controllers/IdentityController.cs

@@ -41,7 +41,6 @@ namespace Ombi.Controllers
         public IdentityController(OmbiUserManager user, IMapper mapper, RoleManager<IdentityRole> rm, IEmailProvider prov,
             ISettingsService<EmailNotificationSettings> s,
             ISettingsService<CustomizationSettings> c,
-            IOptions<UserSettings> userSettings,
             IWelcomeEmail welcome)
         {
             UserManager = user;
@@ -50,7 +49,6 @@ namespace Ombi.Controllers
             EmailProvider = prov;
             EmailSettings = s;
             CustomizationSettings = c;
-            UserSettings = userSettings;
             WelcomeEmail = welcome;
         }
 
@@ -60,7 +58,6 @@ namespace Ombi.Controllers
         private IEmailProvider EmailProvider { get; }
         private ISettingsService<EmailNotificationSettings> EmailSettings { get; }
         private ISettingsService<CustomizationSettings> CustomizationSettings { get; }
-        private IOptions<UserSettings> UserSettings { get; }
         private IWelcomeEmail WelcomeEmail { get; }
 
         /// <summary>
@@ -97,7 +94,7 @@ namespace Ombi.Controllers
                 await UserManager.AddToRoleAsync(userToCreate, OmbiRoles.Admin);
             }
 
-            return true;
+            return result.Succeeded;
         }
 
         private async Task CreateRoles()

src/Ombi/Controllers/TokenController.cs

@@ -22,18 +22,15 @@ namespace Ombi.Controllers
     [Produces("application/json")]
     public class TokenController
     {
-        public TokenController(OmbiUserManager um, IOptions<TokenAuthentication> ta,
-            IApplicationConfigRepository config, IAuditRepository audit, ITokenRepository token)
+        public TokenController(OmbiUserManager um, IOptions<TokenAuthentication> ta, IAuditRepository audit, ITokenRepository token)
         {
             _userManager = um;
             _tokenAuthenticationOptions = ta.Value;
-            _config = config;
             _audit = audit;
             _token = token;
         }
 
         private readonly TokenAuthentication _tokenAuthenticationOptions;
-        private IApplicationConfigRepository _config;
         private readonly IAuditRepository _audit;
         private readonly ITokenRepository _token;
         private readonly OmbiUserManager _userManager;