github/Ombi
1
0
Fork 0
mirror of https://github.com/Ombi-app/Ombi.git synced 2025-07-14 01:02:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: 🐛 Fixed the Request On Behalf autocomplete not filtering correctly

Browse source 
#4539
This commit is contained in:
tidusjar 2022-03-10 11:55:11 +00:00
parent 76af4a193f
commit a8ba2f3544
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/Ombi/ClientApp/src/app/shared/admin-request-dialog/admin-request-dialog.component.ts
View file

@ -1,7 +1,7 @@
import { Component, Inject, OnInit } from "@angular/core"; import { Component, Inject, OnInit } from "@angular/core";
import { FormBuilder, FormGroup } from "@angular/forms"; import { FormBuilder, FormGroup } from "@angular/forms";
import { MatDialogRef, MAT_DIALOG_DATA } from "@angular/material/dialog"; import { MatDialogRef, MAT_DIALOG_DATA } from "@angular/material/dialog";
import { Observable } from "rxjs"; import { firstValueFrom, Observable } from "rxjs";
import { startWith, map } from "rxjs/operators"; import { startWith, map } from "rxjs/operators";
import { ILanguageProfiles, IRadarrProfile, IRadarrRootFolder, ISonarrProfile, ISonarrRootFolder, ISonarrSettings, IUserDropdown, RequestType } from "../../interfaces"; import { ILanguageProfiles, IRadarrProfile, IRadarrRootFolder, ISonarrProfile, ISonarrRootFolder, ISonarrSettings, IUserDropdown, RequestType } from "../../interfaces";
import { IdentityService, MessageService, RadarrService, RequestService, SettingsService, SonarrService } from "../../services"; import { IdentityService, MessageService, RadarrService, RequestService, SettingsService, SonarrService } from "../../services";
@ -55,7 +55,7 @@ export class AdminRequestDialogComponent implements OnInit {
radarrFolderId: [null] radarrFolderId: [null]
}) })
this.options = await this.identityService.getUsersDropdown().toPromise(); this.options = await firstValueFrom(this.identityService.getUsersDropdown());
this.filteredOptions = this.form.controls['username'].valueChanges.pipe( this.filteredOptions = this.form.controls['username'].valueChanges.pipe(
startWith(""), startWith(""),
@ -96,7 +96,10 @@ export class AdminRequestDialogComponent implements OnInit {
public displayFn(user: IUserDropdown): string { public displayFn(user: IUserDropdown): string {
const username = user?.username ? user.username : ""; const username = user?.username ? user.username : "";
const email = user?.email ? `(${user.email})` : ""; const email = user?.email ? `(${user.email})` : "";
return `${username} ${email}`; if (username && email) {
return `${username} ${email}`;
}
return '';
} }
private _filter(value: string | IUserDropdown): IUserDropdown[] { private _filter(value: string | IUserDropdown): IUserDropdown[] {