github/Ombi
1
0
Fork 0
mirror of https://github.com/Ombi-app/Ombi.git synced 2025-07-06 13:11:13 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Cron Validation (#4842)

Browse source 
* Add Cron Next Time Validation

The cron job can't be created if the year is more than 100 years in the future.
Getting the next valid time will return null if this is the case.

* add next cron validation to api
* add next cron validation to job settings page

* Add Missing Import
This commit is contained in:
Alexander Russell 2023-05-02 07:36:07 -06:00 • committed by GitHub
parent ca947bd302
commit 97cc42ffa8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/Ombi.Settings/Settings/Models/JobSettingsHelper.cs
View file

@ -1,5 +1,6 @@
using Ombi.Helpers;
using Quartz;
using System;
namespace Ombi.Settings.Settings.Models
{
@ -104,7 +105,9 @@ namespace Ombi.Settings.Settings.Models
private static string ValidateCron(string cron)
{
if (CronExpression.IsValidExpression(cron))
CronExpression expression = new CronExpression(cron);
DateTimeOffset? nextFireUTCTime = expression.GetNextValidTimeAfter(DateTime.Now);
if (CronExpression.IsValidExpression(cron) && nextFireUTCTime != null)
{
return cron;
}

4
src/Ombi/Controllers/V1/SettingsController.cs
View file

@ -652,7 +652,9 @@ namespace Ombi.Controllers.V1
try
{
var isValid = CronExpression.IsValidExpression(expression);
if (!isValid)
CronExpression cron = new CronExpression(expression);
DateTimeOffset? nextFireUTCTime = cron.GetNextValidTimeAfter(DateTime.Now);
if (!isValid || nextFireUTCTime == null)
{
return new JobSettingsViewModel
{