From 4d9fddf68c84bd82d3bac7b31676b4ca768fc4f1 Mon Sep 17 00:00:00 2001 From: Matt Jeanes Date: Sun, 1 Jul 2018 02:39:39 +0100 Subject: [PATCH] Comment out envparam stuff This parameter on WebpackDevMiddlewareOptions doesn't actually exist until aspnetcore spa services 2.1 so now breaks with @tidusjar's downgrade but luckily not needed See https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.spaservices.webpack.webpackdevmiddlewareoptions.envparam?view=aspnetcore-2.1#Microsoft_AspNetCore_SpaServices_Webpack_WebpackDevMiddlewareOptions_EnvParam Still want to keep it around though because it's useful to explain why AOT isn't on with HMR --- src/Ombi/Startup.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Ombi/Startup.cs b/src/Ombi/Startup.cs index b31900019..db8d40a56 100644 --- a/src/Ombi/Startup.cs +++ b/src/Ombi/Startup.cs @@ -151,10 +151,11 @@ namespace Ombi { HotModuleReplacement = true, ConfigFile = "webpack.config.ts", - EnvParam = new - { - aot = false // can't use AOT with HMR currently https://github.com/angular/angular-cli/issues/6347 - } + + //EnvParam = new + //{ + // aot = true // can't use AOT with HMR currently https://github.com/angular/angular-cli/issues/6347 + //} }); }