linting !wip

src/Ombi/ClientApp/app/app.component.ts

@@ -40,7 +40,7 @@ export class AppComponent implements OnInit {
                         __webpack_public_path__ = base + "/dist/";
                     }
 
-                    this.translate.addLangs(["en", "de", "fr","da","es","it","nl","sv","no"]);
+                    this.translate.addLangs(["en", "de", "fr", "da", "es", "it", "nl", "sv", "no"]);
                     // this language will be used as a fallback when a translation isn't found in the current language
                     this.translate.setDefaultLang("en");
 
@@ -88,8 +88,8 @@ export class AppComponent implements OnInit {
 
     public openMobileApp(event: any) {
         event.preventDefault();
-        if(!this.customizationSettings.applicationUrl) {
+        if (!this.customizationSettings.applicationUrl) {
-            this.notificationService.warning("Mobile","Please ask your admin to setup the Application URL!");
+            this.notificationService.warning("Mobile", "Please ask your admin to setup the Application URL!");
             return;
         }
 

src/Ombi/ClientApp/app/auth/auth.service.ts

@@ -53,9 +53,9 @@ export class AuthService extends ServiceHelpers {
             } else {
                 u.roles.push(roles);
             }
-            return <ILocalUser>u;
+            return <ILocalUser> u;
         }
-        return <ILocalUser>{};
+        return <ILocalUser> { };
     }
 
     public hasRole(role: string): boolean {

src/Ombi/ClientApp/app/auth/cookie.component.ts

@@ -11,7 +11,7 @@ export class CookieComponent implements OnInit {
 
     public ngOnInit() {
         const cookie = this.cookieService.getAll();
-        if(cookie.Auth) {
+        if (cookie.Auth) {
             const jwtVal = cookie.Auth;
             localStorage.setItem("id_token", jwtVal);
             this.router.navigate(["search"]);

src/Ombi/ClientApp/app/issues/issueDetails.component.ts

@@ -63,8 +63,8 @@ export class IssueDetailsComponent implements OnInit {
                 issueCategoryId: x.issueCategoryId,
                 subject: x.subject,
                 description: x.description,
-                status:x.status,
+                status: x.status,
-                resolvedDate:x.resolvedDate,
+                resolvedDate: x.resolvedDate,
                 title: x.title,
                 requestType: x.requestType,
                 requestId: x.requestId,
@@ -117,7 +117,7 @@ export class IssueDetailsComponent implements OnInit {
 
         } else {
             this.imageService.getTvBackground(Number(issue.providerId)).subscribe(x => {
-                if(x) {
+                if (x) {
                     this.backgroundPath = this.sanitizer.bypassSecurityTrustStyle
                         ("url(" + x + ")");
                 }

src/Ombi/ClientApp/app/issues/issues.component.ts

@@ -61,5 +61,4 @@ export class IssuesComponent implements OnInit {
             this.resolvedIssues = x;
         });
     }
-    
 }

src/Ombi/ClientApp/app/login/login.component.ts

@@ -32,7 +32,7 @@ export class LoginComponent implements OnDestroy, OnInit {
     public loginWithOmbi: boolean;
 
     public get appName(): string {
-        if(this.customizationSettings.applicationName) {
+        if (this.customizationSettings.applicationName) {
             return this.customizationSettings.applicationName;
         } else {
             return "Ombi";
@@ -72,7 +72,7 @@ export class LoginComponent implements OnDestroy, OnInit {
             }
         });
 
-        if(authService.loggedIn()) {
+        if (authService.loggedIn()) {
             this.router.navigate(["search"]);
         }
     }
@@ -103,9 +103,9 @@ export class LoginComponent implements OnDestroy, OnInit {
             return;
         }
         const value = form.value;
-        const user = { password: value.password, username: value.username, rememberMe: value.rememberMe, usePlexOAuth: false, plexTvPin: { id: 0, code: ""} };
+        const user = { password: value.password, username: value.username, rememberMe: value.rememberMe, usePlexOAuth: false, plexTvPin: { id: 0, code: "" } };
         this.authService.requiresPassword(user).subscribe(x => {
-            if(x && this.authenticationSettings.allowNoPassword) {
+            if (x && this.authenticationSettings.allowNoPassword) {
                 // Looks like this user requires a password
                 this.authenticationSettings.allowNoPassword = false;
                 return;
@@ -125,9 +125,9 @@ export class LoginComponent implements OnDestroy, OnInit {
     }
 
     public oauth() {
-        this.plexTv.GetPin(this.clientId, this.appName).subscribe(pin => {
+        this.plexTv.GetPin(this.clientId, this.appName).subscribe((pin: any) => {
 
-            this.authService.login({usePlexOAuth: true, password:"",rememberMe:true,username:"", plexTvPin: pin}).subscribe(x => {
+            this.authService.login({ usePlexOAuth: true, password: "", rememberMe: true, username: "", plexTvPin: pin }).subscribe(x => {
                 if (window.frameElement) {
                     // in frame
                     window.open(x.url, "_blank");

src/Ombi/ClientApp/app/login/loginoauth.component.ts

@@ -16,7 +16,6 @@ export class LoginOAuthComponent implements OnInit {
         this.route.params
             .subscribe((params: any) => {
                 this.pin = params.pin;
-                
             });
     }
 
@@ -26,7 +25,7 @@ export class LoginOAuthComponent implements OnInit {
 
     public auth() {
       this.authService.oAuth(this.pin).subscribe(x => {
-          if(x.access_token) {
+          if (x.access_token) {
             localStorage.setItem("id_token", x.access_token);
 
             if (this.authService.loggedIn()) {
@@ -34,13 +33,12 @@ export class LoginOAuthComponent implements OnInit {
                 return;
             }
         }
-          if(x.errorMessage) {
+          if (x.errorMessage) {
             this.error = x.errorMessage;
         }
 
         }, err => {
             this.notify.error(err.statusText);
-            
             this.router.navigate(["login"]);
         });
     }

src/Ombi/ClientApp/app/login/resetpassword.component.ts

@@ -4,7 +4,7 @@ import { FormBuilder, FormGroup, Validators } from "@angular/forms";
 import { DomSanitizer } from "@angular/platform-browser";
 
 import { ICustomizationSettings } from "../interfaces";
-import { IdentityService, ImageService,NotificationService, SettingsService } from "../services";
+import { IdentityService, ImageService, NotificationService, SettingsService } from "../services";
 
 @Component({
     templateUrl: "./resetpassword.component.html",

src/Ombi/ClientApp/app/recentlyAdded/recentlyAdded.component.ts

@@ -67,10 +67,10 @@ export class RecentlyAddedComponent implements OnInit {
      }
 
      public close() {
-         if(this.range.length < 2) {
+         if (this.range.length < 2) {
              return;
          }
-         if(!this.range[1]) {
+         if (!this.range[1]) {
              // If we do not have a second date then just set it to now
             this.range[1] = new Date();
          }
@@ -82,13 +82,13 @@ export class RecentlyAddedComponent implements OnInit {
      }
 
      private getShows() {
-         if(this.groupTv) {
+         if (this.groupTv) {
             this.recentlyAddedService.getRecentlyAddedTvGrouped().subscribe(x => {
                 this.tv = x;
 
                 this.tv.forEach((t) => {
                     this.imageService.getTvPoster(t.tvDbId).subscribe(p => {
-                        if(p) {
+                        if (p) {
                             t.posterPath = p;
                         }
                     });
@@ -100,7 +100,7 @@ export class RecentlyAddedComponent implements OnInit {
 
                 this.tv.forEach((t) => {
                     this.imageService.getTvPoster(t.tvDbId).subscribe(p => {
-                        if(p) {
+                        if (p) {
                             t.posterPath = p;
                         }
                     });
@@ -114,11 +114,11 @@ export class RecentlyAddedComponent implements OnInit {
             this.movies = x;
 
             this.movies.forEach((movie) => {
-                if(movie.theMovieDbId) {
+                if (movie.theMovieDbId) {
                 this.imageService.getMoviePoster(movie.theMovieDbId).subscribe(p => {
                     movie.posterPath = p;
                 });
-                } else if(movie.imdbId) {
+                } else if (movie.imdbId) {
                     this.imageService.getMoviePoster(movie.imdbId).subscribe(p => {
                         movie.posterPath = p;
                     });

src/Ombi/ClientApp/app/requests/tvrequest-children.component.ts

@@ -4,7 +4,7 @@ import { IChildRequests } from "../interfaces";
 import { NotificationService, RequestService } from "../services";
 
 @Component({
-    selector:"tvrequests-children",
+    selector: "tvrequests-children",
     templateUrl: "./tvrequest-children.component.html",
 })
 export class TvRequestChildrenComponent {
@@ -26,12 +26,12 @@ export class TvRequestChildrenComponent {
 
     public changeAvailability(request: IChildRequests, available: boolean) {
         request.available = available;
-        request.seasonRequests.forEach((season)=> {
+        request.seasonRequests.forEach((season) => {
-            season.episodes.forEach((ep)=> {
+            season.episodes.forEach((ep) => {
                 ep.available = available;
             });
         });
-        if(available) {
+        if (available) {
             this.requestService.markTvAvailable({ id: request.id }).subscribe(x => {
                 if (x.result) {
                     this.notificationService.success(

src/Ombi/ClientApp/app/search/moviesearchgrid.component.ts

@@ -155,7 +155,6 @@ export class MovieSearchGridComponent implements OnInit {
                 this.movieResultGrid.push(container);
                 container = <ISearchMovieResultContainer>{ movies: [] };
             } else {
-
                 container.movies.push(movie);
             }
         });

src/Ombi/ClientApp/app/services/applications/plextv.service.ts

@@ -2,7 +2,7 @@
 import { HttpClient, HttpHeaders } from "@angular/common/http";
 import { Injectable } from "@angular/core";
 
-import { Observable } from "rxjs/Rx";
+import { Observable } from "rxjs";
 
 import { IPlexPin } from "../../interfaces";
 
@@ -10,11 +10,10 @@ import { IPlexPin } from "../../interfaces";
 export class PlexTvService {
 
     constructor(private http: HttpClient, public platformLocation: PlatformLocation) {
-      
     }
 
     public GetPin(clientId: string, applicationName: string): Observable<IPlexPin> {
-        const headers = new HttpHeaders({"Content-Type":"application/json",
+        const headers = new HttpHeaders({"Content-Type": "application/json",
         "X-Plex-Client-Identifier": clientId,
         "X-Plex-Product": applicationName,
         "X-Plex-Version": "3",

src/Ombi/ClientApp/app/settings/customization/customization.component.ts

@@ -25,13 +25,13 @@ export class CustomizationComponent implements OnInit {
                     return item.fullName === this.settings.presetThemeName;
                 })[0];
 
-                if(existingTheme) {
+                if (existingTheme) {
                     const index = this.themes.indexOf(existingTheme, 0);
                     if (index > -1) {
                         this.themes.splice(index, 1);
                     }
                 }
-                if(x.hasPresetTheme) {
+                if (x.hasPresetTheme) {
                     this.themes.unshift({displayName: x.presetThemeDisplayName, fullName: x.presetThemeName, url: existingTheme.url, version: x.presetThemeVersion});
                     this.themes.unshift({displayName: "None", fullName: "None", url: "", version: ""});
                 } else {
@@ -45,8 +45,8 @@ export class CustomizationComponent implements OnInit {
     public save() {
 
         this.settingsService.verifyUrl(this.settings.applicationUrl).subscribe(x => {
-            if(this.settings.applicationUrl) {
+            if (this.settings.applicationUrl) {
-                if(!x) {
+                if (!x) {
                     this.notificationService.error(`The URL "${this.settings.applicationUrl}" is not valid. Please format it correctly e.g. http://www.google.com/`);
                     return;
                 }
@@ -64,16 +64,16 @@ export class CustomizationComponent implements OnInit {
     }
 
     public dropDownChange(event: any): void {
-        const selectedThemeFullName = <string>event.target.value;
+        const selectedThemeFullName = <string> event.target.value;
         const selectedTheme = this.themes.filter((val) => {
             return val.fullName === selectedThemeFullName;
         })[0];
 
-        if(selectedTheme.fullName === this.settings.presetThemeName) {
+        if (selectedTheme.fullName === this.settings.presetThemeName) {
             return;
         }
 
-        if(selectedTheme.fullName === "None" || selectedTheme.fullName === "-1") {
+        if (selectedTheme.fullName === "None" || selectedTheme.fullName === "-1") {
             this.settings.presetThemeName = "";
             this.settings.presetThemeContent = "";
             return;

src/Ombi/ClientApp/app/usermanagement/usermanagement.component.ts

@@ -1,6 +1,6 @@
 import { Component, OnInit } from "@angular/core";
 
-import { ICheckbox, ICustomizationSettings, IEmailNotificationSettings,IUser } from "../interfaces";
+import { ICheckbox, ICustomizationSettings, IEmailNotificationSettings, IUser } from "../interfaces";
 import { IdentityService, NotificationService, SettingsService } from "../services";
 
 @Component({
@@ -21,9 +21,9 @@ export class UserManagementComponent implements OnInit {
     public bulkMovieLimit?: number;
     public bulkEpisodeLimit?: number;
 
-    constructor(private readonly identityService: IdentityService,
+    constructor(private identityService: IdentityService,
-                private readonly settingsService: SettingsService,
+        private settingsService: SettingsService,
-                private readonly notificationService: NotificationService) { }
+        private notificationService: NotificationService) { }
 
     public ngOnInit() {
         this.users = [];
@@ -37,7 +37,7 @@ export class UserManagementComponent implements OnInit {
     }
 
     public welcomeEmail(user: IUser) {
-        if(!user.emailAddress) {
+        if (!user.emailAddress) {
             this.notificationService.error("The user needs an email address.");
             return;
         }
@@ -45,7 +45,7 @@ export class UserManagementComponent implements OnInit {
             this.notificationService.error("Email Notifications are not setup, cannot send welcome email");
             return;
         }
-        if(!this.emailSettings.notificationTemplates.some(x => {
+        if (!this.emailSettings.notificationTemplates.some(x => {
             return x.enabled && x.notificationType === 8;
         })) {
             this.notificationService.error("The Welcome Email template is not enabled in the Email Setings");
@@ -74,20 +74,20 @@ export class UserManagementComponent implements OnInit {
         });
 
         this.users.forEach(x => {
-            if(!x.checked) {
+            if (!x.checked) {
                 return;
             }
-            if(anyRoles) {
+            if (anyRoles) {
                 x.claims = this.availableClaims;
             }
-            if(this.bulkEpisodeLimit) {
+            if (this.bulkEpisodeLimit) {
                 x.episodeRequestLimit = this.bulkEpisodeLimit;
             }
-            if(this.bulkMovieLimit) {
+            if (this.bulkMovieLimit) {
                 x.movieRequestLimit = this.bulkMovieLimit;
             }
             this.identityService.updateUser(x).subscribe(y => {
-                if(!y.successful) {
+                if (!y.successful) {
                     this.notificationService.error(`Could not update user ${x.userName}. Reason ${y.errors[0]}`);
                 }
             });

src/Ombi/ClientApp/app/wizard/emby/emby.component.ts

@@ -21,7 +21,7 @@ export class EmbyComponent implements OnInit {
     public ngOnInit() {
         this.embySettings = {
             servers: [],
-            id:0,
+            id: 0,
             enable: true,
         };
         this.embySettings.servers.push({

src/Ombi/ClientApp/app/wizard/plex/plex.component.ts

@@ -42,14 +42,14 @@ export class PlexComponent implements OnInit {
                     return;
                 }
             });
-              },
+        }
         );
     }
 
     public oauth() {
-        this.plexTv.GetPin(this.clientId, "Ombi").subscribe(pin => {
+        this.plexTv.GetPin(this.clientId, "Ombi").subscribe((pin: any) => {
-            this.plexService.oAuth({wizard: true, pin}).subscribe(x => {
+            this.plexService.oAuth({ wizard: true, pin }).subscribe(x => {
-                if(x.url) {
+                if (x.url) {
                     window.location.href = x.url;
                 }
             });

src/Ombi/ClientApp/app/wizard/plex/plexoauth.component.ts

@@ -25,7 +25,7 @@ export class PlexOAuthComponent implements OnInit {
 
     public ngOnInit(): void {
         this.plexOauth.oAuth(this.pinId).subscribe(x => {
-            if(!x.accessToken) {
+            if (!x.accessToken) {
                 return;
                 // RETURN
             }
@@ -51,7 +51,6 @@ export class PlexOAuthComponent implements OnInit {
                                         this.router.navigate(["login"]);
                                     });
                                 });
-  
                             });
                         });
                     });
@@ -60,8 +59,6 @@ export class PlexOAuthComponent implements OnInit {
                     return;
                 }
             });
-                 
         });
     }
-    
 }

src/Ombi/tslint.json

@@ -8,7 +8,7 @@
     ],
     "max-line-length": [
       true,
-      200
+      250
     ],
     "arrow-parens": false,
     "radix": false,
@@ -16,22 +16,22 @@
     "indent": [
       false
     ],
-    "whitespace": [
-      false
-    ],
     "no-unused-expression": [
       true,
       "allow-new"
     ],
-    "no-trailing-whitespace": [
-      false
-    ],
     "max-classes-per-file": [
       false
     ],
     "no-shadowed-variable": false,
     "comment-format": [
       false
+    ],
+    "no-namespace": [
+      false
+    ],
+    "no-internal-module": [
+      false
     ]
   }
 }