Added error handling to DNS and SMB servers when port is in use

Added check to see if a plugins options were called without loading the actual plugin

core/dnschef/DNSchef.py

@@ -474,10 +474,14 @@ class DNSChef(ConfigWatcher):
         self.onConfigChange()
         self.startConfigWatch()
 
-        if self.config['MITMf']['DNS']['tcp'].lower() == 'on':
-            self.startTCP()
-        else:
-            self.startUDP()
+        try:
+            if self.config['MITMf']['DNS']['tcp'].lower() == 'on':
+                self.startTCP()
+            else:
+                self.startUDP()
+        except socket.error as e:
+            if "Address already in use" in e:
+                sys.exit("\n[-] Unable to start DNS server on port {}: port already in use".format(self.config['MITMf']['DNS']['port']))
 
     # Initialize and start the DNS Server        
     def startUDP(self):

core/protocols/smb/SMBServer_Responder.py

@@ -1,6 +1,3 @@
-##################################################################################
-#SMB stuff starts here
-##################################################################################
 
 class ThreadingTCPServer(ThreadingMixIn, TCPServer):
 
@@ -333,8 +330,4 @@ class SMB1LM(BaseRequestHandler):
 
 		except Exception:
 			self.request.close()
-			pass
-
-##################################################################################
-#SMB Server stuff ends here
-##################################################################################
+			pass

core/protocols/smb/SMBserver.py

@@ -1,6 +1,7 @@
 import logging
 import sys
 import threading
+from socket import error as socketerror
 from impacket import version, smbserver, LOG
 from core.configwatcher import ConfigWatcher
 
@@ -22,9 +23,13 @@ class SMBserver(ConfigWatcher):
     impacket_ver = version.VER_MINOR
 
     def __init__(self, listenAddress = '0.0.0.0', listenPort=445, configFile=''):
-
-        self.server = smbserver.SimpleSMBServer(listenAddress, listenPort, configFile)
-        self.server.setSMBChallenge(self.config["MITMf"]["SMB"]["Challenge"])
+        
+        try:
+            self.server = smbserver.SimpleSMBServer(listenAddress, listenPort, configFile)
+            self.server.setSMBChallenge(self.config["MITMf"]["SMB"]["Challenge"])
+        except socketerror as e:
+            if "Address already in use" in e:
+                sys.exit("\n[-] Unable to start SMB server on port 445: port already in use")
 
     def start(self):
         t = threading.Thread(name='SMBserver', target=self.server.start)

core/responder/imap/IMAPServer.py

@@ -16,7 +16,7 @@ class IMAPServer():
 			t = threading.Thread(name="IMAPServer", target=server.serve_forever)
 			t.setDaemon(True)
 			t.start()
-		except Exception, e:
+		except Exception as e:
 			mitmf_logger.error("[IMAPServer] Error starting on port {}: {}".format(143, e))
 
 class ThreadingTCPServer(ThreadingMixIn, TCPServer):

core/responder/ldap/LDAPServer.py

@@ -20,7 +20,7 @@ class LDAPServer():
 			t = threading.Thread(name="LDAPServer", target=server.serve_forever)
 			t.setDaemon(True)
 			t.start()
-		except Exception, e:
+		except Exception as e:
 			mitmf_logger.error("[LDAPServer] Error starting on port {}: {}".format(389, e))
 
 class ThreadingTCPServer(ThreadingMixIn, TCPServer):

core/responder/mssql/MSSQLServer.py

@@ -12,14 +12,14 @@ class MSSQLServer():
 
     def start(self, chal):
         global Challenge; Challenge = chal
-        
+
         try:
             mitmf_logger.debug("[MSSQLServer] online")
             server = ThreadingTCPServer(("0.0.0.0", 1433), MSSQL)
             t = threading.Thread(name="MSSQLServer", target=server.serve_forever)
             t.setDaemon(True)
             t.start()
-        except Exception, e:
+        except Exception as e:
             mitmf_logger.error("[MSSQLServer] Error starting on port {}: {}".format(1433, e))
 
 class ThreadingTCPServer(ThreadingMixIn, TCPServer):